From: "Paul E. McKenney" <paulmck@kernel.org>
To: tglx@linutronix.de
Cc: linux-kernel@vger.kernel.org, john.stultz@linaro.org,
sboyd@kernel.org, corbet@lwn.net, Mark.Rutland@arm.com,
maz@kernel.org, kernel-team@meta.com, neeraju@codeaurora.org,
ak@linux.intel.com, feng.tang@intel.com, zhengjun.xing@intel.com
Subject: [PATCH clocksource 0/3] Reject bogus watchdog clocksource measurements
Date: Mon, 14 Nov 2022 15:28:07 -0800 [thread overview]
Message-ID: <20221114232807.GA834337@paulmck-ThinkPad-P17-Gen-1> (raw)
Hello!
This series adds comments classifying bogus measurements and adds capped
exponential backoff for messages that are likely caused by overly busy
systems.
1. Reject bogus watchdog clocksource measurements.
2. Add comments to classify bogus measurements.
3. Exponential backoff for load-induced bogus watchdog reads.
Changes since v1:
o Merge the "Reject bogus watchdog clocksource measurements" [1] series
with the "Clocksource-watchdog classification and backoff" [2] series.
o Updated messages to indicate timer bug for too-short watchdog
intervals based on Feng Tang feedback.
o Added explanatory comments before error messages based on Feng
Tang feedback.
o Check both the reference clocksource and the clocksource under
test to handle clocksource-internal counter wrap, based on Feng
Tang feedback.
o Reversed the order of the checks, so that the too-long check
preceeds the too-short check. This avoids too-short false
positives due to counter wrap.
o Simplified exponential-backoff time checks based on feedback
from Waiman Long.
o Updated the exponentially backed off messages to more clearly
indicate that the counts are instances since the last printed
message.
o Applied Reviewed-by tags.
[1] https://lore.kernel.org/all/20221019230904.GA2502730@paulmck-ThinkPad-P17-Gen-1
[2] https://lore.kernel.org/all/20221102184001.GA1306489@paulmck-ThinkPad-P17-Gen-1/
Thanx, Paul
------------------------------------------------------------------------
b/include/linux/clocksource.h | 3 +++
b/kernel/time/clocksource.c | 13 ++++++++++++-
kernel/time/clocksource.c | 33 +++++++++++++++++++++++++++------
3 files changed, 42 insertions(+), 7 deletions(-)
next reply other threads:[~2022-11-14 23:28 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-14 23:28 Paul E. McKenney [this message]
2022-11-14 23:28 ` [PATCH clocksource 1/3] clocksource: Reject bogus watchdog clocksource measurements Paul E. McKenney
2022-11-17 21:57 ` Thomas Gleixner
2022-11-17 23:09 ` Paul E. McKenney
2022-11-21 0:55 ` Feng Tang
2022-11-21 15:21 ` Paul E. McKenney
2022-11-21 18:14 ` Paul E. McKenney
2022-11-22 15:55 ` Feng Tang
2022-11-22 22:07 ` Paul E. McKenney
2022-11-23 2:36 ` Feng Tang
2022-11-23 21:23 ` Paul E. McKenney
2022-11-28 2:15 ` Feng Tang
2022-11-29 19:29 ` Paul E. McKenney
2022-11-30 1:38 ` Feng Tang
2022-11-30 4:12 ` Paul E. McKenney
2022-11-30 4:49 ` Feng Tang
2022-11-30 5:16 ` Paul E. McKenney
2022-11-30 5:35 ` Feng Tang
2022-11-30 5:50 ` Paul E. McKenney
2022-11-30 6:00 ` Feng Tang
2022-12-01 17:24 ` Paul E. McKenney
2022-12-02 1:10 ` Feng Tang
2022-12-02 1:44 ` Paul E. McKenney
2022-12-02 2:02 ` Feng Tang
2022-12-02 22:24 ` Paul E. McKenney
2022-12-03 2:51 ` Feng Tang
2022-11-14 23:28 ` [PATCH clocksource 2/3] clocksource: Add comments to classify bogus measurements Paul E. McKenney
2022-11-14 23:28 ` [PATCH clocksource 3/3] clocksource: Exponential backoff for load-induced bogus watchdog reads Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221114232807.GA834337@paulmck-ThinkPad-P17-Gen-1 \
--to=paulmck@kernel.org \
--cc=Mark.Rutland@arm.com \
--cc=ak@linux.intel.com \
--cc=corbet@lwn.net \
--cc=feng.tang@intel.com \
--cc=john.stultz@linaro.org \
--cc=kernel-team@meta.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maz@kernel.org \
--cc=neeraju@codeaurora.org \
--cc=sboyd@kernel.org \
--cc=tglx@linutronix.de \
--cc=zhengjun.xing@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.