All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Alex Bennée" <alex.bennee@linaro.org>
To: qemu-devel@nongnu.org
Cc: fam@euphon.net, berrange@redhat.com, f4bug@amsat.org,
	aurelien@aurel32.net, pbonzini@redhat.com, stefanha@redhat.com,
	crosa@redhat.com, "Alex Bennée" <alex.bennee@linaro.org>,
	"Philippe Mathieu-Daudé" <philmd@linaro.org>,
	"Thomas Huth" <thuth@redhat.com>,
	"Wainer dos Santos Moschetta" <wainersm@redhat.com>,
	"Beraldo Leal" <bleal@redhat.com>
Subject: [PATCH  v3 03/13] tests/docker: allow user to override check target
Date: Thu, 17 Nov 2022 17:25:22 +0000	[thread overview]
Message-ID: <20221117172532.538149-4-alex.bennee@linaro.org> (raw)
In-Reply-To: <20221117172532.538149-1-alex.bennee@linaro.org>

This is useful when trying to bisect a particular failing test behind
a docker run. For example:

  make docker-test-clang@fedora \
    TARGET_LIST=arm-softmmu \
    TEST_COMMAND="meson test qtest-arm/qos-test" \
    J=9 V=1

Signed-off-by: Alex Bennée <alex.bennee@linaro.org>
Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
Message-Id: <20221111145529.4020801-5-alex.bennee@linaro.org>
---
 tests/docker/Makefile.include | 2 ++
 tests/docker/common.rc        | 6 +++---
 2 files changed, 5 insertions(+), 3 deletions(-)

diff --git a/tests/docker/Makefile.include b/tests/docker/Makefile.include
index c87f14477a..fc7a3b7e71 100644
--- a/tests/docker/Makefile.include
+++ b/tests/docker/Makefile.include
@@ -184,6 +184,7 @@ docker:
 	@echo '    TARGET_LIST=a,b,c    Override target list in builds.'
 	@echo '    EXTRA_CONFIGURE_OPTS="..."'
 	@echo '                         Extra configure options.'
+	@echo '    TEST_COMMAND="..."   Override the default `make check` target.'
 	@echo '    IMAGES="a b c ..":   Restrict available images to subset.'
 	@echo '    TESTS="x y z .."     Restrict available tests to subset.'
 	@echo '    J=[0..9]*            Overrides the -jN parameter for make commands'
@@ -230,6 +231,7 @@ docker-run: docker-qemu-src
 			$(if $(NETWORK),$(if $(subst $(NETWORK),,1),--net=$(NETWORK)),--net=none) \
 			-e TARGET_LIST=$(subst $(SPACE),$(COMMA),$(TARGET_LIST))	\
 			-e EXTRA_CONFIGURE_OPTS="$(EXTRA_CONFIGURE_OPTS)" \
+			-e TEST_COMMAND="$(TEST_COMMAND)" 		\
 			-e V=$V -e J=$J -e DEBUG=$(DEBUG)		\
 			-e SHOW_ENV=$(SHOW_ENV) 			\
 			$(if $(NOUSER),,				\
diff --git a/tests/docker/common.rc b/tests/docker/common.rc
index e6f8cee0d6..9a33df2832 100755
--- a/tests/docker/common.rc
+++ b/tests/docker/common.rc
@@ -63,12 +63,12 @@ check_qemu()
 {
     # default to make check unless the caller specifies
     if [ $# = 0 ]; then
-        INVOCATION="check"
+        INVOCATION="${TEST_COMMAND:-make $MAKEFLAGS check}"
     else
-        INVOCATION="$@"
+        INVOCATION="make $MAKEFLAGS $@"
     fi
 
-    make $MAKEFLAGS $INVOCATION
+    $INVOCATION
 }
 
 test_fail()
-- 
2.34.1



  parent reply	other threads:[~2022-11-17 17:29 UTC|newest]

Thread overview: 27+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-17 17:25 [PATCH for 7.2 v3 00/13] testing and doc updates (pre-PR) Alex Bennée
2022-11-17 17:25 ` [PATCH v3 01/13] Run docker probe only if docker or podman are available Alex Bennée
2022-11-17 17:25 ` [PATCH v3 02/13] tests/avocado/machine_aspeed.py: Reduce noise on the console for SDK tests Alex Bennée
2022-11-17 17:25 ` Alex Bennée [this message]
2022-11-17 17:25 ` [PATCH v3 04/13] docs/devel: add a maintainers section to development process Alex Bennée
2022-11-18  7:49   ` Philippe Mathieu-Daudé
2022-11-22  9:45     ` Alex Bennée
2022-11-17 17:25 ` [PATCH v3 05/13] docs/devel: make language a little less code centric Alex Bennée
2022-11-18  7:52   ` Philippe Mathieu-Daudé
2022-11-17 17:25 ` [PATCH v3 06/13] docs/devel: simplify the minimal checklist Alex Bennée
2022-11-18  7:55   ` Philippe Mathieu-Daudé
2023-07-05 11:44   ` Philippe Mathieu-Daudé
2023-08-25  7:25     ` Philippe Mathieu-Daudé
2023-09-01 10:08       ` Alex Bennée
2023-09-01 10:23         ` Daniel P. Berrangé
2022-11-17 17:25 ` [PATCH v3 07/13] docs/devel: try and improve the language around patch review Alex Bennée
2022-11-18  7:57   ` Philippe Mathieu-Daudé
2022-11-17 17:25 ` [PATCH v3 08/13] tests/avocado: Raise timeout for boot_linux.py:BootLinuxPPC64.test_pseries_tcg Alex Bennée
2022-11-17 17:25 ` [PATCH v3 09/13] tests/avocado: introduce alpine virt test for CI Alex Bennée
2022-11-18  8:04   ` Philippe Mathieu-Daudé
2022-11-17 17:25 ` [PATCH v3 10/13] tests/avocado: skip aarch64 cloud TCG tests in CI Alex Bennée
2022-11-18  8:05   ` Philippe Mathieu-Daudé
2022-11-17 17:25 ` [PATCH v3 11/13] gitlab: integrate coverage report Alex Bennée
2022-11-17 17:25 ` [PATCH v3 12/13] tests/avocado/boot_linux.py: Bump aarch64 virt test timeout to 720s Alex Bennée
2022-11-18  8:07   ` Philippe Mathieu-Daudé
2022-11-21 21:25   ` Peter Maydell
2022-11-17 17:25 ` [PATCH v3 13/13] ci: replace x86_64 macos-11 with aarch64 macos-12 Alex Bennée

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221117172532.538149-4-alex.bennee@linaro.org \
    --to=alex.bennee@linaro.org \
    --cc=aurelien@aurel32.net \
    --cc=berrange@redhat.com \
    --cc=bleal@redhat.com \
    --cc=crosa@redhat.com \
    --cc=f4bug@amsat.org \
    --cc=fam@euphon.net \
    --cc=pbonzini@redhat.com \
    --cc=philmd@linaro.org \
    --cc=qemu-devel@nongnu.org \
    --cc=stefanha@redhat.com \
    --cc=thuth@redhat.com \
    --cc=wainersm@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.