[PATCH v3 1/3] certs: log hash value on blacklist error

From: "Thomas Weißschuh" <linux@weissschuh.net>
To: "Mickaël Salaün" <mic@digikod.net>,
	"David Howells" <dhowells@redhat.com>,
	"David Woodhouse" <dwmw2@infradead.org>,
	"Jarkko Sakkinen" <jarkko@kernel.org>,
	"Eric Snowberg" <eric.snowberg@oracle.com>
Cc: "Thomas Weißschuh" <linux@weissschuh.net>,
	keyrings@vger.kernel.org, linux-kernel@vger.kernel.org,
	"Mark Pearson" <markpearson@lenovo.com>,
	linux-integrity@vger.kernel.org,
	linux-security-module@vger.kernel.org
Subject: [PATCH v3 1/3] certs: log hash value on blacklist error
Date: Fri, 18 Nov 2022 05:03:41 +0100	[thread overview]
Message-ID: <20221118040343.2958-2-linux@weissschuh.net> (raw)
In-Reply-To: <20221118040343.2958-1-linux@weissschuh.net>

Without this information these logs are not actionable.

For example on duplicate blacklisted hashes reported by the system
firmware users should be able to report the erroneous hashes to their
system vendors.

While we are at it use the dedicated format string for ERR_PTR.

Fixes: 6364d106e041 ("certs: Allow root user to append signed hashes to the blacklist keyring")
Signed-off-by: Thomas Weißschuh <linux@weissschuh.net>
---
 certs/blacklist.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/certs/blacklist.c b/certs/blacklist.c
index 41f10601cc72..6e260c4b6a19 100644
--- a/certs/blacklist.c
+++ b/certs/blacklist.c
@@ -192,7 +192,7 @@ static int mark_raw_hash_blacklisted(const char *hash)
 				   KEY_ALLOC_NOT_IN_QUOTA |
 				   KEY_ALLOC_BUILT_IN);
 	if (IS_ERR(key)) {
-		pr_err("Problem blacklisting hash (%ld)\n", PTR_ERR(key));
+		pr_err("Problem blacklisting hash %s: %pe\n", hash, key);
 		return PTR_ERR(key);
 	}
 	return 0;
-- 
2.38.1

