From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1owLH6-0002S5-05 for mharc-grub-devel@gnu.org; Sat, 19 Nov 2022 05:40:40 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1owLH2-0002RH-3f for grub-devel@gnu.org; Sat, 19 Nov 2022 05:40:36 -0500 Received: from szxga08-in.huawei.com ([45.249.212.255]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1owLGw-0008Gg-7r for grub-devel@gnu.org; Sat, 19 Nov 2022 05:40:34 -0500 Received: from dggemv703-chm.china.huawei.com (unknown [172.30.72.53]) by szxga08-in.huawei.com (SkyGuard) with ESMTP id 4NDqsg6HD7z15MZQ; Sat, 19 Nov 2022 18:39:51 +0800 (CST) Received: from kwepemm600019.china.huawei.com (7.193.23.64) by dggemv703-chm.china.huawei.com (10.3.19.46) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Sat, 19 Nov 2022 18:40:17 +0800 Received: from huawei.com (10.44.134.232) by kwepemm600019.china.huawei.com (7.193.23.64) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2375.31; Sat, 19 Nov 2022 18:40:16 +0800 From: t.feng To: CC: , , , Subject: [PATCH 3/9] fs/minix: Fix memory leak in grub_minix_lookup_symlink Date: Sat, 19 Nov 2022 18:39:40 +0800 Message-ID: <20221119103946.657744-4-fengtao40@huawei.com> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20221119103946.657744-1-fengtao40@huawei.com> References: <20221119103946.657744-1-fengtao40@huawei.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain X-Originating-IP: [10.44.134.232] X-ClientProxiedBy: dggems703-chm.china.huawei.com (10.3.19.180) To kwepemm600019.china.huawei.com (7.193.23.64) X-CFilter-Loop: Reflected Received-SPF: pass client-ip=45.249.212.255; envelope-from=fengtao40@huawei.com; helo=szxga08-in.huawei.com X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 19 Nov 2022 10:40:36 -0000 Fix memory leaks in grub_minix_lookup_symlink. Fixes: a07e6ad01(Remove variable length arrays) Signed-off-by: "t.feng" --- grub-core/fs/minix.c | 11 +++++++++-- 1 file changed, 9 insertions(+), 2 deletions(-) diff --git a/grub-core/fs/minix.c b/grub-core/fs/minix.c index 953df1191..2176b6e93 100644 --- a/grub-core/fs/minix.c +++ b/grub-core/fs/minix.c @@ -374,7 +374,10 @@ grub_minix_lookup_symlink (struct grub_minix_data *data, grub_minix_ino_t ino) if (!symlink) return grub_errno; if (grub_minix_read_file (data, 0, 0, 0, sz, symlink) < 0) - return grub_errno; + { + grub_free (symlink); + return grub_errno; + } symlink[sz] = '\0'; @@ -384,10 +387,14 @@ grub_minix_lookup_symlink (struct grub_minix_data *data, grub_minix_ino_t ino) /* Now load in the old inode. */ if (grub_minix_read_inode (data, ino)) - return grub_errno; + { + grub_free (symlink); + return grub_errno; + } grub_minix_find_file (data, symlink); + grub_free (symlink); return grub_errno; } -- 2.27.0