From: Jakub Kicinski <kuba@kernel.org>
To: Jacob Keller <jacob.e.keller@intel.com>
Cc: <netdev@vger.kernel.org>, Jiri Pirko <jiri@nvidia.com>
Subject: Re: [PATCH net-next 2/8] devlink: use min_t to calculate data_size
Date: Mon, 21 Nov 2022 11:06:02 -0800 [thread overview]
Message-ID: <20221121110602.6cc663f4@kernel.org> (raw)
In-Reply-To: <8b8d2f27-7295-4740-3264-9b4883153dd5@intel.com>
On Mon, 21 Nov 2022 10:35:34 -0800 Jacob Keller wrote:
> > Sure, that makes sense.
>
> This becomes the only variable in patch 5 of 8. It ends up making the
> diff look more complicated if I change it back to a combined
> declare+assign in that patch.
Don't change it back to declare+assign, then? :)
In general declare+assign should be used sparingly IMO.
My eyes are trained to skip right past the variable declarations,
the goal is to make the code clear, not short :S
BTW you can probably make DEVLINK_REGION_READ_CHUNK_SIZE a ULL to switch
from min_t() to min() ?
next prev parent reply other threads:[~2022-11-21 19:06 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-17 22:07 [PATCH net-next 0/8] devlink: support direct read from region Jacob Keller
2022-11-17 22:07 ` [PATCH net-next 1/8] devlink: find snapshot in devlink_nl_cmd_region_read_dumpit Jacob Keller
2022-11-17 22:07 ` [PATCH net-next 2/8] devlink: use min_t to calculate data_size Jacob Keller
2022-11-19 1:36 ` Jakub Kicinski
2022-11-21 17:51 ` Jacob Keller
2022-11-21 18:35 ` Jacob Keller
2022-11-21 19:06 ` Jakub Kicinski [this message]
2022-11-21 21:16 ` Jacob Keller
2022-11-17 22:07 ` [PATCH net-next 3/8] devlink: report extended error message in region_read_dumpit Jacob Keller
2022-11-19 1:40 ` Jakub Kicinski
2022-11-21 17:53 ` Jacob Keller
2022-11-21 19:10 ` Jacob Keller
2022-11-21 19:23 ` Jakub Kicinski
2022-11-21 21:18 ` Jacob Keller
2022-11-22 4:07 ` Jakub Kicinski
2022-11-17 22:07 ` [PATCH net-next 4/8] devlink: remove unnecessary parameter from chunk_fill function Jacob Keller
2022-11-17 22:08 ` [PATCH net-next 5/8] devlink: refactor region_read_snapshot_fill to use a callback function Jacob Keller
2022-11-19 1:31 ` Jakub Kicinski
2022-11-19 1:48 ` Jakub Kicinski
2022-11-21 17:55 ` Jacob Keller
2022-11-17 22:08 ` [PATCH net-next 6/8] devlink: support directly reading from region memory Jacob Keller
2022-11-19 1:49 ` Jakub Kicinski
2022-11-23 19:20 ` Jacob Keller
2022-11-17 22:08 ` [PATCH net-next 7/8] ice: use same function to snapshot both NVM and Shadow RAM Jacob Keller
2022-11-17 22:08 ` [PATCH net-next 8/8] ice: implement direct read for NVM and Shadow RAM regions Jacob Keller
2022-11-23 20:51 ` [PATCH net-next 0/8] devlink: support direct read from region Jacob Keller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221121110602.6cc663f4@kernel.org \
--to=kuba@kernel.org \
--cc=jacob.e.keller@intel.com \
--cc=jiri@nvidia.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.