From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id AF8A8C4332F for ; Wed, 23 Nov 2022 11:00:37 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 806268549F; Wed, 23 Nov 2022 12:00:35 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="HLMKsV6G"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id A43B9854A7; Wed, 23 Nov 2022 12:00:33 +0100 (CET) Received: from mail-lf1-x133.google.com (mail-lf1-x133.google.com [IPv6:2a00:1450:4864:20::133]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 2CAD88541E for ; Wed, 23 Nov 2022 12:00:31 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=ilin.mikhail.ol@gmail.com Received: by mail-lf1-x133.google.com with SMTP id a29so27572269lfj.9 for ; Wed, 23 Nov 2022 03:00:31 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=C6H+/lnfWxiXAo2AI/7gtd42B3LutwSeXlksMOWdork=; b=HLMKsV6GQgu8jlEbVxKjakHXjqx0tTlgoOKNlwL95SR32G/a05SBzWCNw/ptmQ9vrs cx+BvYR9VIjKu+PCAXl2hajAYP2F4GG5KmGBQIo5nLJkGoZokcxA70/a9wQ9gdOMuFUL IeLhmcwFlG8i9Fwm8hKEGIzzO1un/1xaM20reu+2sRUQe/rQ9WbHveHkWqki/eT6GpPM 8fqrdPrewaUx0k7BnCWO+eaPMexaMPOj67GXiRYhiOdYkljegHryHkyWsMJh5UXPGyNW kJHoZxIfc/9+rmswg52eOWgcNFzbmW5Sts/0DadmovFc8XjKqrRBEDG2z35q3gDe/LNh sraA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=C6H+/lnfWxiXAo2AI/7gtd42B3LutwSeXlksMOWdork=; b=J3VsbkESNyqms1mUzEUWDecgEbUE7uVrLI9+yYK4QGnLgKUFEAZtWjA0hPOnmWvCgi 7ImG0R7cwY6FuO4BhM+q6o19mCh6rVdQCaHJrrxjRVv1N/JKAmhz7wOeJBtE+gI8YjU/ WuhPRGqCg9vLv/AigmhxY9T9kr9rjnKLGQsnaElNtMvLZK+r5H+9wA99woT0mqCMTCTs VK9tJp07c2uDklAtxBiQ5WYT2rttFDHr48P2fzqJxGv/ZEluQ+1TcHpPd1rGGmiq7z4+ 2HVINJJkBsQ4OD1UhUhLlxBwF8M5REdiUnGsq8GHZje2Gv4mkJTePqwmYh0Id08mtTVZ RoeA== X-Gm-Message-State: ANoB5pkq3rFU4hCxxVmOwOAbByg9fEdApR7wysd6CErA/bRCpAXO4Tx5 Gid4ZirHfvH8ObCw3m/6jGQmH7xtYdA= X-Google-Smtp-Source: AA0mqf40aTsQOyHenFGCZJnx0L8lOuaCsD26CEZfenks7DL40xIEh95a3OzFy5ntWlPjIff+S3NxJw== X-Received: by 2002:a19:6b1a:0:b0:4b4:3313:feaf with SMTP id d26-20020a196b1a000000b004b43313feafmr9067947lfa.365.1669201230555; Wed, 23 Nov 2022 03:00:30 -0800 (PST) Received: from milin-wrk.rasu.local ([178.70.40.200]) by smtp.gmail.com with ESMTPSA id h22-20020a05651c125600b00267232d0652sm2179849ljh.46.2022.11.23.03.00.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 23 Nov 2022 03:00:29 -0800 (PST) From: Mikhail Ilin To: Peng Fan Cc: Mikhail Ilin , u-boot@lists.denx.de Subject: [PATCH] tools: imx8image: Fix handle leak Date: Wed, 23 Nov 2022 13:59:49 +0300 Message-Id: <20221123105949.26475-1-ilin.mikhail.ol@gmail.com> X-Mailer: git-send-email 2.17.1 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean The handle "fd" was created in imx8image.c:249 by calling the "fopen" function and is lost in imx8image.c:282. Should close the 'fd' file descriptor before exiting the parse_cfg_file(image_t *param_stack, char *name) function. Fixes: a2b96ece5be1 ("tools: add i.MX8/8X image support") Signed-off-by: Mikhail Ilin --- tools/imx8image.c | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/imx8image.c b/tools/imx8image.c index 01e1486911..395d5c64bd 100644 --- a/tools/imx8image.c +++ b/tools/imx8image.c @@ -279,6 +279,7 @@ static uint32_t parse_cfg_file(image_t *param_stack, char *name) } } + fclose(fd); return 0; } -- 2.17.1