All of lore.kernel.org
 help / color / mirror / Atom feed
From: Liam Howlett <liam.howlett@oracle.com>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Geert Uytterhoeven <geert@linux-m68k.org>,
	kernel test robot <lkp@intel.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	"linux-mm@kvack.org" <linux-mm@kvack.org>
Subject: Re: [PATCH] maple_tree: allow TEST_MAPLE_TREE only when DEBUG_KERNEL is set
Date: Wed, 23 Nov 2022 18:53:54 +0000	[thread overview]
Message-ID: <20221123185346.q6sfeb74ahj3rdcu@revolver> (raw)
In-Reply-To: <20221119055117.14094-1-rdunlap@infradead.org>


Thanks Randy.  I'm going to look into doing as Geert requested and avoid
pulling in dependencies, but this is the right thing to do for now.

Reviewed-by: Liam R. Howlett <Liam.Howlett@oracle.com>


* Randy Dunlap <rdunlap@infradead.org> [221119 00:51]:
> Prevent a kconfig warning that is caused by TEST_MAPLE_TREE by adding a
> "depends on" clause for TEST_MAPLE_TREE since 'select' does not follow
> any kconfig dependencies.
> 
> WARNING: unmet direct dependencies detected for DEBUG_MAPLE_TREE
>   Depends on [n]: DEBUG_KERNEL [=n]
>   Selected by [y]:
>   - TEST_MAPLE_TREE [=y] && RUNTIME_TESTING_MENU [=y]
> 
> Reported-by: Geert Uytterhoeven <geert@linux-m68k.org>
> Reported-by: kernel test robot <lkp@intel.com>
> Fixes: 120b116208a0 ("maple_tree: reorganize testing to restore module testing")
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Liam Howlett <liam.howlett@oracle.com>
> Cc: Andrew Morton <akpm@linux-foundation.org>
> Cc: linux-mm@kvack.org
> ---
>  lib/Kconfig.debug |    1 +
>  1 file changed, 1 insertion(+)
> 
> diff -- a/lib/Kconfig.debug b/lib/Kconfig.debug
> --- a/lib/Kconfig.debug
> +++ b/lib/Kconfig.debug
> @@ -2259,6 +2259,7 @@ config TEST_XARRAY
>  	tristate "Test the XArray code at runtime"
>  
>  config TEST_MAPLE_TREE
> +	depends on DEBUG_KERNEL
>  	select DEBUG_MAPLE_TREE
>  	tristate "Test the Maple Tree code at runtime"
>  

      reply	other threads:[~2022-11-23 18:54 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-19  5:51 [PATCH] maple_tree: allow TEST_MAPLE_TREE only when DEBUG_KERNEL is set Randy Dunlap
2022-11-23 18:53 ` Liam Howlett [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221123185346.q6sfeb74ahj3rdcu@revolver \
    --to=liam.howlett@oracle.com \
    --cc=akpm@linux-foundation.org \
    --cc=geert@linux-m68k.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=lkp@intel.com \
    --cc=rdunlap@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.