:::::: :::::: Manual check reason: "low confidence bisect report" :::::: Manual check reason: "low confidence static check warning: drivers/usb/repeater/repeater-qcom-pmic-eusb2.c:116:13: warning: use of uninitialized value '' [CWE-457] [-Wanalyzer-use-of-uninitialized-value]" :::::: BCC: lkp@intel.com CC: oe-kbuild-all@lists.linux.dev In-Reply-To: <20221116123019.2753230-4-abel.vesa@linaro.org> References: <20221116123019.2753230-4-abel.vesa@linaro.org> TO: Abel Vesa Hi Abel, [FYI, it's a private test report for your RFC patch.] [auto build test WARNING on usb/usb-testing] [also build test WARNING on usb/usb-next usb/usb-linus linus/master v6.1-rc6 next-20221125] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Abel-Vesa/usb-Add-generic-repeater-framework-and-SM8550-driver/20221116-203345 base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git usb-testing patch link: https://lore.kernel.org/r/20221116123019.2753230-4-abel.vesa%40linaro.org patch subject: [RFC PATCH 3/3] usb: repeater: Add Qualcomm PMIC eUSB2 driver :::::: branch date: 10 days ago :::::: commit date: 10 days ago config: arm-randconfig-c002-20221124 compiler: arm-linux-gnueabi-gcc (GCC) 12.1.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/a98d43fcc06b2362ba74489be29fa2eb730df8ea git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Abel-Vesa/usb-Add-generic-repeater-framework-and-SM8550-driver/20221116-203345 git checkout a98d43fcc06b2362ba74489be29fa2eb730df8ea # save the config file COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross ARCH=arm KBUILD_USERCFLAGS='-fanalyzer -Wno-error' If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot gcc_analyzer warnings: (new ones prefixed by >>) drivers/usb/repeater/repeater-qcom-pmic-eusb2.c: In function 'qcom_eusb2_repeater_init': >> drivers/usb/repeater/repeater-qcom-pmic-eusb2.c:116:13: warning: use of uninitialized value '' [CWE-457] [-Wanalyzer-use-of-uninitialized-value] 116 | u32 val; | ^~~ 'qcom_eusb2_repeater_init': event 1 | | 116 | u32 val; | | ^~~ | | | | | (1) use of uninitialized value '' here | drivers/usb/repeater/repeater-qcom-pmic-eusb2.c: In function 'qcom_eusb2_repeater_probe': drivers/usb/repeater/repeater-qcom-pmic-eusb2.c:178:13: warning: use of uninitialized value '' [CWE-457] [-Wanalyzer-use-of-uninitialized-value] 178 | u32 res; | ^~~ 'qcom_eusb2_repeater_probe': event 1 | | 178 | u32 res; | | ^~~ | | | | | (1) use of uninitialized value '' here | vim +116 drivers/usb/repeater/repeater-qcom-pmic-eusb2.c a98d43fcc06b23 Abel Vesa 2022-11-16 111 a98d43fcc06b23 Abel Vesa 2022-11-16 112 static int qcom_eusb2_repeater_init(struct usb_repeater *r) a98d43fcc06b23 Abel Vesa 2022-11-16 113 { a98d43fcc06b23 Abel Vesa 2022-11-16 114 struct qcom_eusb2_repeater *rptr = to_qcom_eusb2_repeater(r); a98d43fcc06b23 Abel Vesa 2022-11-16 115 int ret = 0; a98d43fcc06b23 Abel Vesa 2022-11-16 @116 u32 val; a98d43fcc06b23 Abel Vesa 2022-11-16 117 a98d43fcc06b23 Abel Vesa 2022-11-16 118 qcom_eusb2_repeater_cfg_init(rptr); a98d43fcc06b23 Abel Vesa 2022-11-16 119 a98d43fcc06b23 Abel Vesa 2022-11-16 120 if (r->flags & PHY_HOST_MODE) { a98d43fcc06b23 Abel Vesa 2022-11-16 121 /* a98d43fcc06b23 Abel Vesa 2022-11-16 122 * CM.Lx is prohibited when repeater is already into Lx state as a98d43fcc06b23 Abel Vesa 2022-11-16 123 * per eUSB 1.2 Spec. Below implement software workaround until a98d43fcc06b23 Abel Vesa 2022-11-16 124 * PHY and controller is fixing seen observation. a98d43fcc06b23 Abel Vesa 2022-11-16 125 */ a98d43fcc06b23 Abel Vesa 2022-11-16 126 regmap_update_bits(rptr->regmap, rptr->base + EUSB2_FORCE_EN_5, a98d43fcc06b23 Abel Vesa 2022-11-16 127 F_CLK_19P2M_EN, F_CLK_19P2M_EN); a98d43fcc06b23 Abel Vesa 2022-11-16 128 regmap_update_bits(rptr->regmap, rptr->base + EUSB2_FORCE_VAL_5, a98d43fcc06b23 Abel Vesa 2022-11-16 129 V_CLK_19P2M_EN, V_CLK_19P2M_EN); a98d43fcc06b23 Abel Vesa 2022-11-16 130 } else { a98d43fcc06b23 Abel Vesa 2022-11-16 131 /* a98d43fcc06b23 Abel Vesa 2022-11-16 132 * In device mode clear host mode related workaround as there a98d43fcc06b23 Abel Vesa 2022-11-16 133 * is no repeater reset available, and enable/disable of a98d43fcc06b23 Abel Vesa 2022-11-16 134 * repeater doesn't clear previous value due to shared a98d43fcc06b23 Abel Vesa 2022-11-16 135 * regulators (say host <-> device mode switch). a98d43fcc06b23 Abel Vesa 2022-11-16 136 */ a98d43fcc06b23 Abel Vesa 2022-11-16 137 regmap_update_bits(rptr->regmap, rptr->base + EUSB2_FORCE_EN_5, a98d43fcc06b23 Abel Vesa 2022-11-16 138 F_CLK_19P2M_EN, 0); a98d43fcc06b23 Abel Vesa 2022-11-16 139 regmap_update_bits(rptr->regmap, rptr->base + EUSB2_FORCE_VAL_5, a98d43fcc06b23 Abel Vesa 2022-11-16 140 V_CLK_19P2M_EN, 0); a98d43fcc06b23 Abel Vesa 2022-11-16 141 } a98d43fcc06b23 Abel Vesa 2022-11-16 142 a98d43fcc06b23 Abel Vesa 2022-11-16 143 ret = regmap_read_poll_timeout(rptr->regmap, rptr->base + EUSB2_RPTR_STATUS, val, a98d43fcc06b23 Abel Vesa 2022-11-16 144 val & RPTR_OK, 10, 5); a98d43fcc06b23 Abel Vesa 2022-11-16 145 if (ret) a98d43fcc06b23 Abel Vesa 2022-11-16 146 dev_err(r->dev, "initialization timed-out\n"); a98d43fcc06b23 Abel Vesa 2022-11-16 147 a98d43fcc06b23 Abel Vesa 2022-11-16 148 return ret; a98d43fcc06b23 Abel Vesa 2022-11-16 149 } a98d43fcc06b23 Abel Vesa 2022-11-16 150 -- 0-DAY CI Kernel Test Service https://01.org/lkp