From: "Kirill A . Shutemov" <kirill.shutemov@linux.intel.com>
To: Vincent Mailhol <mailhol.vincent@wanadoo.fr>,
Steven Rostedt <rostedt@goodmis.org>
Cc: Sean Christopherson <seanjc@google.com>,
Paolo Bonzini <pbonzini@redhat.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Borislav Petkov <bp@alien8.de>,
Dave Hansen <dave.hansen@linux.intel.com>,
x86@kernel.org, "H . Peter Anvin" <hpa@zytor.com>,
Josh Poimboeuf <jpoimboe@kernel.org>,
Kuppuswamy Sathyanarayanan
<sathyanarayanan.kuppuswamy@linux.intel.com>,
Al Viro <viro@zeniv.linux.org.uk>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86/asm: Remove unused COMPILE_OFFSETS macro from asm-offsets.c
Date: Mon, 28 Nov 2022 12:15:06 +0300 [thread overview]
Message-ID: <20221128091506.gp4l6klznqhigjxv@box.shutemov.name> (raw)
In-Reply-To: <20221127062335.330758-1-mailhol.vincent@wanadoo.fr>
On Sun, Nov 27, 2022 at 03:23:35PM +0900, Vincent Mailhol wrote:
> Following [1], the macro COMPILE_OFFSETS becomes unused:
Really? I see #ifdef COMPILE_OFFSETS in ftrace.h. Hm?
Have you tested your patch with CONFIG_FTRACE_SYSCALLS=y and
CONFIG_IA32_EMULATION=y?
> $ make W=2 arch/x86/kernel/asm-offsets.o
> <...>
> arch/x86/kernel/asm-offsets.c:7: warning: macro "COMPILE_OFFSETS" is not used [-Wunused-macros]
> <...>
>
> Remove COMPILE_OFFSETS macro.
>
> [1] commit debc5a1ec0d1 ("KVM: x86: use a separate asm-offsets.c file")
> Link: https://git.kernel.org/torvalds/linux/c/debc5a1ec0d1
>
> Fixes: debc5a1ec0d1 ("KVM: x86: use a separate asm-offsets.c file")
> Signed-off-by: Vincent Mailhol <mailhol.vincent@wanadoo.fr>
> ---
> arch/x86/kernel/asm-offsets.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/x86/kernel/asm-offsets.c b/arch/x86/kernel/asm-offsets.c
> index 437308004ef2..cf2e02bafbef 100644
> --- a/arch/x86/kernel/asm-offsets.c
> +++ b/arch/x86/kernel/asm-offsets.c
> @@ -4,7 +4,6 @@
> * This code generates raw asm output which is post-processed to extract
> * and format the required data.
> */
> -#define COMPILE_OFFSETS
>
> #include <linux/crypto.h>
> #include <linux/sched.h>
> --
> 2.37.4
>
--
Kiryl Shutsemau / Kirill A. Shutemov
next prev parent reply other threads:[~2022-11-28 9:15 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-27 6:23 [PATCH] x86/asm: Remove unused COMPILE_OFFSETS macro from asm-offsets.c Vincent Mailhol
2022-11-28 9:15 ` Kirill A . Shutemov [this message]
2022-11-28 10:11 ` Vincent Mailhol
2022-11-28 11:11 ` kirill.shutemov
2022-11-28 11:30 ` Vincent MAILHOL
2022-11-28 17:45 ` Steven Rostedt
2022-11-28 18:00 ` Paolo Bonzini
2022-11-28 18:06 ` Sean Christopherson
2022-11-28 19:10 ` Steven Rostedt
2022-11-29 10:14 ` Vincent MAILHOL
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221128091506.gp4l6klznqhigjxv@box.shutemov.name \
--to=kirill.shutemov@linux.intel.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=jpoimboe@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mailhol.vincent@wanadoo.fr \
--cc=mingo@redhat.com \
--cc=pbonzini@redhat.com \
--cc=rostedt@goodmis.org \
--cc=sathyanarayanan.kuppuswamy@linux.intel.com \
--cc=seanjc@google.com \
--cc=tglx@linutronix.de \
--cc=viro@zeniv.linux.org.uk \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.