From: "Michael S. Tsirkin" <mst@redhat.com>
To: Alvaro Karsz <alvaro.karsz@solid-run.com>
Cc: Jens Axboe <axboe@kernel.dk>, Paolo Bonzini <pbonzini@redhat.com>,
Chaitanya Kulkarni <chaitanyak@nvidia.com>,
Stefan Hajnoczi <stefanha@redhat.com>,
"virtualization@lists.linux-foundation.org"
<virtualization@lists.linux-foundation.org>
Subject: Re: [PATCH v2] virtio_blk: add VIRTIO_BLK_F_LIFETIME feature support
Date: Mon, 28 Nov 2022 15:02:57 -0500 [thread overview]
Message-ID: <20221128145949-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <CAJs=3_AY_1eGwsu5MvzUr4N03=3qgYiVdu5=EV+VSj6+yUYeyg@mail.gmail.com>
On Fri, Nov 25, 2022 at 12:09:45AM +0200, Alvaro Karsz wrote:
> > I suggest defining a separate UAPI struct for this ioctl.
>
> Sounds fine to me.
> I could use the following struct
>
> struct virtio_blk_lifetime_ioctl {
> u16 pre_eol_info;
> u16 device_lifetime_est_typ_a;
> u16 device_lifetime_est_typ_b;
> u16 padding;
> };
OK. What makes it virtio specific though? Don't any other block
devices report lifetime? And shouldn't they share the same
ioctl then? Maybe this belongs to a generic lifetime.h ?
Comments documenting meaning of the fields would also be good.
--
MST
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization
next prev parent reply other threads:[~2022-11-28 20:03 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-21 8:59 [PATCH v2] virtio_blk: add VIRTIO_BLK_F_LIFETIME feature support Alvaro Karsz
[not found] ` <1bd1c77e-d8c3-b04a-4fbc-bbc85391e630@nvidia.com>
2022-11-24 6:42 ` Michael S. Tsirkin
2022-11-24 20:38 ` Stefan Hajnoczi
2022-11-24 22:02 ` Alvaro Karsz
2022-11-24 22:09 ` Alvaro Karsz
2022-11-28 19:07 ` Stefan Hajnoczi
[not found] ` <dc8bf007-a6f6-9824-63e1-9447335da732@nvidia.com>
2022-11-29 5:28 ` Michael S. Tsirkin
[not found] ` <b76ad252-3f6a-8f4b-cb2d-0a4f45860aae@nvidia.com>
2022-12-04 8:19 ` Alvaro Karsz
2022-12-04 10:59 ` Michael S. Tsirkin
2022-12-04 12:00 ` Alvaro Karsz
2022-12-04 12:27 ` Michael S. Tsirkin
2022-12-04 14:37 ` Alvaro Karsz
2022-12-04 16:51 ` Michael S. Tsirkin
[not found] ` <ce455ec6-353b-d273-0d52-44673f4dc0cc@nvidia.com>
2022-12-05 5:43 ` Michael S. Tsirkin
2022-11-28 20:02 ` Michael S. Tsirkin [this message]
[not found] ` <1b8d59e1-8702-8b81-f82c-a743116da799@nvidia.com>
2022-11-24 6:46 ` Michael S. Tsirkin
2022-11-24 8:07 ` Alvaro Karsz
2022-11-24 20:35 ` Stefan Hajnoczi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221128145949-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=alvaro.karsz@solid-run.com \
--cc=axboe@kernel.dk \
--cc=chaitanyak@nvidia.com \
--cc=pbonzini@redhat.com \
--cc=stefanha@redhat.com \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.