From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9AD3CC433FE for ; Mon, 28 Nov 2022 17:27:59 +0000 (UTC) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CF83440691; Mon, 28 Nov 2022 18:27:58 +0100 (CET) Received: from linux.microsoft.com (linux.microsoft.com [13.77.154.182]) by mails.dpdk.org (Postfix) with ESMTP id 6A56C4067E for ; Mon, 28 Nov 2022 18:27:57 +0100 (CET) Received: by linux.microsoft.com (Postfix, from userid 1086) id AE0B420B717A; Mon, 28 Nov 2022 09:27:56 -0800 (PST) DKIM-Filter: OpenDKIM Filter v2.11.0 linux.microsoft.com AE0B420B717A DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.microsoft.com; s=default; t=1669656476; bh=pMbYZTMrvnPWyG1o+VIZT6GtC3C9TmUteHTblyQE5Cw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=K2M7wJiC24PbnBkiw1yRzFo7TTSnLq95id1PJEY8eaTv5DqaPVq/L1yr67sSjcL2d cMWKc/drUyNfPr9+1kE7rIEYaRDcw9JyOoxB26+AbBWo6cEYOP3PbbJFtVVCQ6RQds haMarL5GFfjYaGmxtU3nCVU0uqHSzAim5iwE7eq4= Date: Mon, 28 Nov 2022 09:27:56 -0800 From: Tyler Retzlaff To: Morten =?iso-8859-1?Q?Br=F8rup?= Cc: dev@dpdk.org Subject: Re: [PATCH v2 1/2] eal: provide leading and trailing zero bit count abstraction Message-ID: <20221128172756.GC28869@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> References: <1669241687-18810-1-git-send-email-roretzla@linux.microsoft.com> <1669246997-30592-1-git-send-email-roretzla@linux.microsoft.com> <1669246997-30592-2-git-send-email-roretzla@linux.microsoft.com> <98CBD80474FA8B44BF855DF32C47DC35D874F9@smartserver.smartshare.dk> <20221128171332.GA28869@linuxonhyperv3.guj3yctzbm1etfxqx2vob5hsef.xx.internal.cloudapp.net> <98CBD80474FA8B44BF855DF32C47DC35D87520@smartserver.smartshare.dk> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <98CBD80474FA8B44BF855DF32C47DC35D87520@smartserver.smartshare.dk> User-Agent: Mutt/1.5.21 (2010-09-15) X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Mon, Nov 28, 2022 at 06:22:10PM +0100, Morten Brørup wrote: > > From: Tyler Retzlaff [mailto:roretzla@linux.microsoft.com] > > Sent: Monday, 28 November 2022 18.14 > > > > On Thu, Nov 24, 2022 at 11:17:23AM +0100, Morten Brørup wrote: > > > > From: Tyler Retzlaff [mailto:roretzla@linux.microsoft.com] > > > > Sent: Thursday, 24 November 2022 00.43 > > > > > > > > Provide an abstraction for leading and trailing zero bit counting > > > > functions to hide compiler specific intrinsics and builtins. > > > > > > > > Signed-off-by: Tyler Retzlaff > > > > --- > > > > > > > let me unpack what is being asked for here. > > > > > Related functions already exist in lib/eal/include/rte_common.h. > > > > i don't understand. are you saying these inline functions duplicate > > existing bit counting functionality? if so i'll relocate any you > > identify. > > Sorry about not being clear about my intentions with the feedback. > > I'm not asking for anything; I only wanted to point at the similar family of functions in rte_common.h, to make sure that you were aware of them. oh! not a problem. i'm very keen to catch any mistakes, thought i had missed something. > > > > > > > > > If some functions are missing, it would be good to add them. > > > > the change here is to address a specific family of functions that are > > impeding portability of the rte_common.h header and nothing more. > > > > i'm open to having a separate mail thread discussing what other > > functions we might want and whether to relocate code out of > > rte_common.h > > since that is likely to be a drawn out discussion it shouldn't be a > > blocking dependency of this series. > > I do not request any new functions; I'll leave it up to you to decide if anything would be good to add. > > > > > > > > > Also, it makes sense moving them out of rte_common.h. > > > > thanks! > > Thank you! Cleaning up is always appreciated. yes, if i can get more rapid approvals there is a lot more in the pipeline. i'd like gain some momentum if possible. ty