All of lore.kernel.org
 help / color / mirror / Atom feed
From: Sudeep Holla <sudeep.holla@arm.com>
To: 王洪辉 <honghui.wang@ucas.com.cn>
Cc: Cristian Marussi <cristian.marussi@arm.com>,
	Jassi Brar <jassisinghbrar@gmail.com>,
	Sudeep Holla <sudeep.holla@arm.com>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	linux-arm-kernel <linux-arm-kernel@lists.infradead.org>
Subject: Re: Re：Re: [PATCH]mailbox/arm_scpi: Add to support Phytium FT2000/4 CPUs, show temperature of cpu.
Date: Thu, 1 Dec 2022 11:41:07 +0000	[thread overview]
Message-ID: <20221201114107.2ig6pdncekzlpdq2@bogus> (raw)
In-Reply-To: <tencent_2F6BF4F403D4DD764FD3D0BF@qq.com>

On Thu, Dec 01, 2022 at 06:41:46PM +0800, 王洪辉 wrote:
> In DTS of FT2000/4 passed from uboot. Add the DTS file to kernel?
>

No, I was referring to the binding not the DTS file like
Documentation/devicetree/bindings/firmware/arm,scpi.yaml

> Of course, it's also a good way to modify DTS file built in uboot.
>

You need to add the binding to make use of this new compatible in the driver.
And when you add, the first question I have is why you need new compatible
or why you can't use the generic one. If you have valid reasons for that,
then we can add the driver change along with the binding. Please split the
binding that you are about to add and the SCPI driver changes separate from
the mailbox driver changes in this patch.

-- 
Regards,
Sudeep

WARNING: multiple messages have this Message-ID (diff)
From: Sudeep Holla <sudeep.holla@arm.com>
To: 王洪辉 <honghui.wang@ucas.com.cn>
Cc: Cristian Marussi <cristian.marussi@arm.com>,
	Jassi Brar <jassisinghbrar@gmail.com>,
	Sudeep Holla <sudeep.holla@arm.com>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	linux-arm-kernel <linux-arm-kernel@lists.infradead.org>
Subject: Re: Re：Re: [PATCH]mailbox/arm_scpi: Add to support Phytium FT2000/4 CPUs, show temperature of cpu.
Date: Thu, 1 Dec 2022 11:41:07 +0000	[thread overview]
Message-ID: <20221201114107.2ig6pdncekzlpdq2@bogus> (raw)
In-Reply-To: <tencent_2F6BF4F403D4DD764FD3D0BF@qq.com>

On Thu, Dec 01, 2022 at 06:41:46PM +0800, 王洪辉 wrote:
> In DTS of FT2000/4 passed from uboot. Add the DTS file to kernel?
>

No, I was referring to the binding not the DTS file like
Documentation/devicetree/bindings/firmware/arm,scpi.yaml

> Of course, it's also a good way to modify DTS file built in uboot.
>

You need to add the binding to make use of this new compatible in the driver.
And when you add, the first question I have is why you need new compatible
or why you can't use the generic one. If you have valid reasons for that,
then we can add the driver change along with the binding. Please split the
binding that you are about to add and the SCPI driver changes separate from
the mailbox driver changes in this patch.

-- 
Regards,
Sudeep

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2022-12-01 11:41 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-01 10:41 =?gb18030?B?UmWjulJlOiBbUEFUQ0hdbWFpbGJveC9hcm1fc2NwaTogQWRkIHRvIHN1cHBvcnQgUGh5dGl1bSBGVDIwMDAvNCBDUFVzLCBzaG93IHRlbXBlcmF0dXJlIG9mIGNwdS4=?= =?gb18030?B?zfW66bvU?=
2022-12-01 10:41 ` =?gb18030?B?UmWjulJlOiBbUEFUQ0hdbWFpbGJveC9hcm1fc2NwaTogQWRkIHRvIHN1cHBvcnQgUGh5dGl1bSBGVDIwMDAvNCBDUFVzLCBzaG93IHRlbXBlcmF0dXJlIG9mIGNwdS4=?= =?gb18030?B?zfW66bvU?=
2022-12-01 11:41 ` Sudeep Holla [this message]
2022-12-01 11:41   ` Re：Re: [PATCH]mailbox/arm_scpi: Add to support Phytium FT2000/4 CPUs, show temperature of cpu Sudeep Holla

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221201114107.2ig6pdncekzlpdq2@bogus \
    --to=sudeep.holla@arm.com \
    --cc=cristian.marussi@arm.com \
    --cc=honghui.wang@ucas.com.cn \
    --cc=jassisinghbrar@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.