All of lore.kernel.org
 help / color / mirror / Atom feed
From: Keith Busch <kbusch@meta.com>
To: <linux-mm@kvack.org>, <linux-kernel@vger.kernel.org>,
	Matthew Wilcox <willy@infradead.org>
Cc: Tony Battersby <tonyb@cybernetics.com>, Keith Busch <kbusch@kernel.org>
Subject: [PATCH 05/11] dmapool: speedup DMAPOOL_DEBUG with init_on_alloc
Date: Mon, 5 Dec 2022 06:59:31 -0800	[thread overview]
Message-ID: <20221205145937.54367-6-kbusch@meta.com> (raw)
In-Reply-To: <20221205145937.54367-1-kbusch@meta.com>

From: Tony Battersby <tonyb@cybernetics.com>

Avoid double-memset of the same allocated memory in dma_pool_alloc()
when both DMAPOOL_DEBUG is enabled and init_on_alloc=1.

Signed-off-by: Tony Battersby <tonyb@cybernetics.com>
Signed-off-by: Keith Busch <kbusch@kernel.org>
---
 mm/dmapool.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/mm/dmapool.c b/mm/dmapool.c
index ee993bb59fc27..eaed3ffb42aa8 100644
--- a/mm/dmapool.c
+++ b/mm/dmapool.c
@@ -356,7 +356,7 @@ void *dma_pool_alloc(struct dma_pool *pool, gfp_t mem_flags,
 			break;
 		}
 	}
-	if (!(mem_flags & __GFP_ZERO))
+	if (!want_init_on_alloc(mem_flags))
 		memset(retval, POOL_POISON_ALLOCATED, pool->size);
 #endif
 	spin_unlock_irqrestore(&pool->lock, flags);
-- 
2.30.2


  parent reply	other threads:[~2022-12-05 15:20 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-05 14:59 [PATCH 00/11] dmapool enhancements Keith Busch
2022-12-05 14:59 ` [PATCH 01/11] dmapool: add alloc/free performance test Keith Busch
2022-12-06  2:17   ` kernel test robot
2022-12-05 14:59 ` [PATCH 02/11] dmapool: remove checks for dev == NULL Keith Busch
2022-12-05 14:59 ` [PATCH 03/11] dmapool: use sysfs_emit() instead of scnprintf() Keith Busch
2022-12-05 14:59 ` [PATCH 04/11] dmapool: cleanup integer types Keith Busch
2022-12-05 14:59 ` Keith Busch [this message]
2022-12-05 14:59 ` [PATCH 06/11] dmapool: move debug code to own functions Keith Busch
2022-12-05 14:59 ` [PATCH 07/11] dmapool: rearrange page alloc failure handling Keith Busch
2022-12-05 14:59 ` [PATCH 08/11] dmapool: consolidate page initialization Keith Busch
2022-12-05 14:59 ` [PATCH 09/11] dmapool: simplify freeing Keith Busch
2022-12-05 14:59 ` [PATCH 10/11] dmapool: don't memset on free twice Keith Busch
2022-12-05 14:59 ` [PATCH 11/11] dmapool: link blocks across pages Keith Busch
2022-12-05 18:07   ` Tony Battersby
2022-12-05 22:34   ` kernel test robot
2022-12-11 15:24   ` kernel test robot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221205145937.54367-6-kbusch@meta.com \
    --to=kbusch@meta.com \
    --cc=kbusch@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=tonyb@cybernetics.com \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.