From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BF467C4708C for ; Tue, 6 Dec 2022 00:19:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230035AbiLFATj (ORCPT ); Mon, 5 Dec 2022 19:19:39 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43254 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229456AbiLFATi (ORCPT ); Mon, 5 Dec 2022 19:19:38 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 300DCFAFE; Mon, 5 Dec 2022 16:19:37 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id D8A64B8125A; Tue, 6 Dec 2022 00:19:35 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3B244C433D6; Tue, 6 Dec 2022 00:19:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1670285974; bh=dLQQ0NWaWk52bmt/xT4H3e0ztNisUGBWj/+Cz/N6eJc=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=IAewbV2I0ijd6AwZgCGYqfcwpr/mnsPvs+LJpPtl8/EDfdf+sGkxnOjVZZOlY7N4V N/l9aVxWIVgnNLSq2mkEa125lYI7CjSuJ9E5MwCWNCSvrgDh2e5yhciKE6AEuzSrt4 nXQ//j4VRO3OP62IElpc4kIxTXgkIIcSby10mK40TnQnIaxPMQLLtxGq4n4ab8xcg8 /eo1hLP6K08B9CHN/Z3XvG4ZDWmiYapldPyt5XaktjmQpoDB1Ks8IvBTDmp5Q+JOTP LGHKs741J9pr+Q/j1811cwQCMBN5Kp8ACpbuWwwwp0g/C5/4RjGyjMDByPO1LnhnU1 4w6V1x226XDdg== Date: Mon, 5 Dec 2022 16:19:33 -0800 From: Jakub Kicinski To: Jiri Pirko Cc: "Kubalewski, Arkadiusz" , Vadim Fedorenko , Jonathan Lemon , Paolo Abeni , "netdev@vger.kernel.org" , Vadim Fedorenko , linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, "Olech, Milena" , "Michalik, Michal" Subject: Re: [RFC PATCH v4 2/4] dpll: Add DPLL framework base functions Message-ID: <20221205161933.663ea611@kernel.org> In-Reply-To: References: <20221129213724.10119-1-vfedorenko@novek.ru> <20221129213724.10119-3-vfedorenko@novek.ru> <20221202212206.3619bd5f@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Mon, 5 Dec 2022 11:32:04 +0100 Jiri Pirko wrote: > >> I believe we should do it only the other way around. Assign > >> dpll_pin pointer to struct net_device and expose this over new attr > >> IFLA_DPLL_PIN over RT netlink. > > > >The ID table is global, what's the relationship between DPLLs > >and net namespaces? We tie DPLLs to a devlink instance which > >has a namespace? We pretend namespaces don't exist? :S > > Well, if would be odd to put dpll itself into a namespace. It might not > have anything to do with networking, for example in case of ptp_ocp. > What would mean for a dpll to be in a net namespace? Yeah, that's a slightly tricky one. We'd probably need some form of second order association. Easiest if we link it to a devlink instance, I reckon. The OCP clock card does not have netdevs so we can't follow the namespace of netdevs (which would be the second option). From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E043EC47089 for ; Tue, 6 Dec 2022 00:20:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=18ppupg3uX0UIyZyTNrj+yVUnKTm9W4nCd9aYs3LHtk=; b=WV5jzwicyNprLP 7HQNlZyQn9ZiAZMo3CqlFLwOIqWqfGGjMMgDKG+6lKV4kQjV6cdjw+CsZII768yEefJVQkENOktDa V6ZYtTZ4tOh6qdUKcH8CmnjiZGkXIr9ItRtt/nn6+sHdlHFxucrFlaS4IMRNtDtyE54xFzbn6ppbi PRaN2HMLD79rjLXVxqYvX675m3NSPLJzJtM2QnTEswNexrlpKOv0jdYKy8wjA7txmb4T6CZeNesaY DSb55sxKuubWAOtLJIN5RSiB2CR+NyZ0xnn3HRqyxc8JrE5xTrCWQOT08CRpDOdCobVCcslIdFJdg cAdYVvPZNqC0/kr7S92A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1p2LgV-00Dv6M-JU; Tue, 06 Dec 2022 00:19:43 +0000 Received: from ams.source.kernel.org ([2604:1380:4601:e00::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1p2LgS-00Dv4n-KA for linux-arm-kernel@lists.infradead.org; Tue, 06 Dec 2022 00:19:42 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id ECD8CB815D1; Tue, 6 Dec 2022 00:19:35 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3B244C433D6; Tue, 6 Dec 2022 00:19:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1670285974; bh=dLQQ0NWaWk52bmt/xT4H3e0ztNisUGBWj/+Cz/N6eJc=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=IAewbV2I0ijd6AwZgCGYqfcwpr/mnsPvs+LJpPtl8/EDfdf+sGkxnOjVZZOlY7N4V N/l9aVxWIVgnNLSq2mkEa125lYI7CjSuJ9E5MwCWNCSvrgDh2e5yhciKE6AEuzSrt4 nXQ//j4VRO3OP62IElpc4kIxTXgkIIcSby10mK40TnQnIaxPMQLLtxGq4n4ab8xcg8 /eo1hLP6K08B9CHN/Z3XvG4ZDWmiYapldPyt5XaktjmQpoDB1Ks8IvBTDmp5Q+JOTP LGHKs741J9pr+Q/j1811cwQCMBN5Kp8ACpbuWwwwp0g/C5/4RjGyjMDByPO1LnhnU1 4w6V1x226XDdg== Date: Mon, 5 Dec 2022 16:19:33 -0800 From: Jakub Kicinski To: Jiri Pirko Cc: "Kubalewski, Arkadiusz" , Vadim Fedorenko , Jonathan Lemon , Paolo Abeni , "netdev@vger.kernel.org" , Vadim Fedorenko , linux-arm-kernel@lists.infradead.org, linux-clk@vger.kernel.org, "Olech, Milena" , "Michalik, Michal" Subject: Re: [RFC PATCH v4 2/4] dpll: Add DPLL framework base functions Message-ID: <20221205161933.663ea611@kernel.org> In-Reply-To: References: <20221129213724.10119-1-vfedorenko@novek.ru> <20221129213724.10119-3-vfedorenko@novek.ru> <20221202212206.3619bd5f@kernel.org> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221205_161940_863002_019FC933 X-CRM114-Status: GOOD ( 13.35 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, 5 Dec 2022 11:32:04 +0100 Jiri Pirko wrote: > >> I believe we should do it only the other way around. Assign > >> dpll_pin pointer to struct net_device and expose this over new attr > >> IFLA_DPLL_PIN over RT netlink. > > > >The ID table is global, what's the relationship between DPLLs > >and net namespaces? We tie DPLLs to a devlink instance which > >has a namespace? We pretend namespaces don't exist? :S > > Well, if would be odd to put dpll itself into a namespace. It might not > have anything to do with networking, for example in case of ptp_ocp. > What would mean for a dpll to be in a net namespace? Yeah, that's a slightly tricky one. We'd probably need some form of second order association. Easiest if we link it to a devlink instance, I reckon. The OCP clock card does not have netdevs so we can't follow the namespace of netdevs (which would be the second option). _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel