All of lore.kernel.org
 help / color / mirror / Atom feed
From: Rob Herring <robh@kernel.org>
To: Carl Philipp Klemm <philipp@uvos.xyz>
Cc: linux-omap@vger.kernel.org, tony@atomide.com, sre@kernel.org,
	devicetree@vger.kernel.org
Subject: Re: [PATCH 4/4] arch: arm: dts: cpcap-mapphone: Move cpcap leds from common dts file to devices as apropriate
Date: Mon, 5 Dec 2022 16:16:10 -0600	[thread overview]
Message-ID: <20221205221610.GA2778910-robh@kernel.org> (raw)
In-Reply-To: <20221204104313.17478-4-philipp@uvos.xyz>

On Sun, Dec 04, 2022 at 11:43:13AM +0100, Carl Philipp Klemm wrote:
> Removes non-functional leds from xt875 and adds its touchscreen
> button light
> 
> Signed-off-by: Carl Philipp Klemm <philipp@uvos.xyz>
> ---
>  .../arm/boot/dts/motorola-cpcap-mapphone.dtsi | 47 ++++++++-----------
>  .../arm/boot/dts/omap4-droid-bionic-xt875.dts |  7 +++
>  arch/arm/boot/dts/omap4-droid4-xt894.dts      | 14 ++++++
>  3 files changed, 41 insertions(+), 27 deletions(-)

Looks like you are breaking the ABI with this series. What happens in a 
system with only the DT change or only the kernel change?

Rob

  reply	other threads:[~2022-12-05 22:16 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-04 10:43 [PATCH 1/4] leds: cpcap: add support for the keyboard light channel Carl Philipp Klemm
2022-12-04 10:43 ` [PATCH 2/4] leds: cpcap: make leds-cpcap an independent platform device to allow varying led setups Carl Philipp Klemm
2022-12-05 17:48   ` Sebastian Reichel
2022-12-05 18:15     ` Carl Philipp Klemm
2022-12-05 21:41       ` Sebastian Reichel
2022-12-04 10:43 ` [PATCH 3/4] dt-bindings: leds: leds-cpcap Carl Philipp Klemm
2022-12-04 10:43 ` [PATCH 4/4] arch: arm: dts: cpcap-mapphone: Move cpcap leds from common dts file to devices as apropriate Carl Philipp Klemm
2022-12-05 22:16   ` Rob Herring [this message]
2022-12-05 17:41 ` [PATCH 1/4] leds: cpcap: add support for the keyboard light channel Sebastian Reichel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221205221610.GA2778910-robh@kernel.org \
    --to=robh@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=philipp@uvos.xyz \
    --cc=sre@kernel.org \
    --cc=tony@atomide.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.