Hi Jisheng, I love your patch! Yet something to improve: [auto build test ERROR on tty/tty-testing] [also build test ERROR on tty/tty-next tty/tty-linus krzk/for-next krzk-dt/for-next linus/master v6.1-rc8 next-20221205] [cannot apply to robh/for-next] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Jisheng-Zhang/riscv-add-Bouffalolab-bl808-support/20221127-213728 base: https://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git tty-testing patch link: https://lore.kernel.org/r/20221127132448.4034-3-jszhang%40kernel.org patch subject: [PATCH v2 2/9] serial: bflb_uart: add Bouffalolab UART Driver config: openrisc-randconfig-c032-20221205 compiler: or1k-linux-gcc (GCC) 12.1.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/0bb4f3a3f1d685809b24d1b93aadd7b67e04eb5a git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Jisheng-Zhang/riscv-add-Bouffalolab-bl808-support/20221127-213728 git checkout 0bb4f3a3f1d685809b24d1b93aadd7b67e04eb5a # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=openrisc SHELL=/bin/bash drivers/tty/serial/ If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot All errors (new ones prefixed by >>): In file included from drivers/tty/serial/bflb_uart.c:15: >> include/linux/module.h:130:49: error: redefinition of '__inittest' 130 | static inline initcall_t __maybe_unused __inittest(void) \ | ^~~~~~~~~~ drivers/tty/serial/bflb_uart.c:605:1: note: in expansion of macro 'module_init' 605 | module_init(bflb_uart_init); | ^~~~~~~~~~~ include/linux/module.h:130:49: note: previous definition of '__inittest' with type 'int (*(void))(void)' 130 | static inline initcall_t __maybe_unused __inittest(void) \ | ^~~~~~~~~~ include/linux/module.h:126:41: note: in expansion of macro 'module_init' 126 | #define console_initcall(fn) module_init(fn) | ^~~~~~~~~~~ drivers/tty/serial/bflb_uart.c:470:1: note: in expansion of macro 'console_initcall' 470 | console_initcall(bflb_uart_console_init); | ^~~~~~~~~~~~~~~~ >> include/linux/module.h:132:13: error: redefinition of 'init_module' 132 | int init_module(void) __copy(initfn) \ | ^~~~~~~~~~~ drivers/tty/serial/bflb_uart.c:605:1: note: in expansion of macro 'module_init' 605 | module_init(bflb_uart_init); | ^~~~~~~~~~~ include/linux/module.h:132:13: note: previous definition of 'init_module' with type 'int(void)' 132 | int init_module(void) __copy(initfn) \ | ^~~~~~~~~~~ include/linux/module.h:126:41: note: in expansion of macro 'module_init' 126 | #define console_initcall(fn) module_init(fn) | ^~~~~~~~~~~ drivers/tty/serial/bflb_uart.c:470:1: note: in expansion of macro 'console_initcall' 470 | console_initcall(bflb_uart_console_init); | ^~~~~~~~~~~~~~~~ Kconfig warnings: (for reference only) WARNING: unmet direct dependencies detected for DEBUG_MAPLE_TREE Depends on [n]: DEBUG_KERNEL [=n] Selected by [m]: - TEST_MAPLE_TREE [=m] && RUNTIME_TESTING_MENU [=y] vim +/__inittest +130 include/linux/module.h 0fd972a7d91d6e Paul Gortmaker 2015-05-01 127 0fd972a7d91d6e Paul Gortmaker 2015-05-01 128 /* Each module must use one module_init(). */ 0fd972a7d91d6e Paul Gortmaker 2015-05-01 129 #define module_init(initfn) \ 1f318a8bafcfba Arnd Bergmann 2017-02-01 @130 static inline initcall_t __maybe_unused __inittest(void) \ 0fd972a7d91d6e Paul Gortmaker 2015-05-01 131 { return initfn; } \ cf68fffb66d60d Sami Tolvanen 2021-04-08 @132 int init_module(void) __copy(initfn) \ cf68fffb66d60d Sami Tolvanen 2021-04-08 133 __attribute__((alias(#initfn))); \ 92efda8eb15295 Sami Tolvanen 2022-09-08 134 ___ADDRESSABLE(init_module, __initdata); 0fd972a7d91d6e Paul Gortmaker 2015-05-01 135 -- 0-DAY CI Kernel Test Service https://01.org/lkp