From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 60A57C352A1 for ; Wed, 7 Dec 2022 02:33:19 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229614AbiLGCdS (ORCPT ); Tue, 6 Dec 2022 21:33:18 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33814 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229479AbiLGCdR (ORCPT ); Tue, 6 Dec 2022 21:33:17 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CE4EA3C6FD; Tue, 6 Dec 2022 18:33:16 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 86E7DB81BEE; Wed, 7 Dec 2022 02:33:15 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DD980C433D6; Wed, 7 Dec 2022 02:33:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1670380394; bh=uau8K4Bi989Gk/f36wEfZYxbGAyT5HJO4AKtGNiCC9c=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=trP45bn61KSi/RVwH9HOyQY4Wz/UfZKELUj3Kh00u1+iHR94MxndXVGBscHiF6PkX wi4bbLKa25j6SuRbmE2ZMvxM0jubQMGiuNAJqqrmutp2ytXsKYVej4OAUxrxAUqCA3 Ds/IiIX0f+GeigueQ5oOHXxfiUgrE8EOeoKsj2TdHmRlhYJUqZRs/xUL+cOuYbA+kr 9QyBe1TJrc7YzY+kF8PPEwlnq5X3x7beo1410Vg4A56VrtvN1d/h1e3cYwFp65XGxx LK/RZMDJrcIHGqg9tFxWlKVYHpicexSGM+zZK536y4BOGo1m8RnO/4FeQ3ipID/aSl +plXP7ybcd7XA== Date: Tue, 6 Dec 2022 18:33:13 -0800 From: Jakub Kicinski To: "Kubalewski, Arkadiusz" Cc: Jiri Pirko , Vadim Fedorenko , Jonathan Lemon , Paolo Abeni , "netdev@vger.kernel.org" , Vadim Fedorenko , "linux-arm-kernel@lists.infradead.org" , "linux-clk@vger.kernel.org" Subject: Re: [RFC PATCH v4 4/4] ptp_ocp: implement DPLL ops Message-ID: <20221206183313.713656f8@kernel.org> In-Reply-To: References: <20221129213724.10119-1-vfedorenko@novek.ru> <20221129213724.10119-5-vfedorenko@novek.ru> MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org On Fri, 2 Dec 2022 14:39:17 +0000 Kubalewski, Arkadiusz wrote: > >>>Btw, did you consider having dpll instance here as and auxdev? It > >>>would be suitable I believe. It is quite simple to do it. See > >>>following patch as an example: > >> > >>I haven't think about it, definetly gonna take a look to see if there > >>any benefits in ice. > > > >Please do. The proper separation and bus/device modelling is at least one > >of the benefits. The other one is that all dpll drivers would happily live > >in drivers/dpll/ side by side. > > Well, makes sense, but still need to take a closer look on that. > I could do that on ice-driver part, don't feel strong enough yet to introduce > Changes here in ptp_ocp. FWIW auxdev makes absolutely no sense to me for DPLL :/ So Jiri, please say why. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C1361C352A1 for ; Wed, 7 Dec 2022 02:34:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=4qdDvX8yALorZyf4ts9Ci322M6aUq09n+ilTY70IKYs=; b=AeNOKP2S4r4RXY 9xzWmX2G6SWjrFc48DMSTyN9T8fPsEEj6/UZdL93tmKFJIJcBJkeo59kmdUqtLvNzd8ocgIVLXbm0 drQGfYFLPsr6peu61eVoCF5EYjLfaJay080hEdRC4mclbMpTX3YBF9zwD5k+vv6tijUaboDfte9jE tXeCrnsjcEQvYE60XLmWpP6ju3TpXpk/geVfQLKTY2tOcx5SCeckR7qtwmns1wBBi5vyJUj8Ko/nI uNCYsrb2foIF2P6lXkVng2kVEHlmpUIQRe38J+nFWZbgm0sY77iZiS+1fgToudjMcdax5b/1/HoD5 X4WLk4BaxQt4ZT/A5nFw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1p2kFK-008a1a-KI; Wed, 07 Dec 2022 02:33:18 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1p2kFH-008a0r-Si for linux-arm-kernel@lists.infradead.org; Wed, 07 Dec 2022 02:33:17 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id BF95A6114F; Wed, 7 Dec 2022 02:33:14 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DD980C433D6; Wed, 7 Dec 2022 02:33:13 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1670380394; bh=uau8K4Bi989Gk/f36wEfZYxbGAyT5HJO4AKtGNiCC9c=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=trP45bn61KSi/RVwH9HOyQY4Wz/UfZKELUj3Kh00u1+iHR94MxndXVGBscHiF6PkX wi4bbLKa25j6SuRbmE2ZMvxM0jubQMGiuNAJqqrmutp2ytXsKYVej4OAUxrxAUqCA3 Ds/IiIX0f+GeigueQ5oOHXxfiUgrE8EOeoKsj2TdHmRlhYJUqZRs/xUL+cOuYbA+kr 9QyBe1TJrc7YzY+kF8PPEwlnq5X3x7beo1410Vg4A56VrtvN1d/h1e3cYwFp65XGxx LK/RZMDJrcIHGqg9tFxWlKVYHpicexSGM+zZK536y4BOGo1m8RnO/4FeQ3ipID/aSl +plXP7ybcd7XA== Date: Tue, 6 Dec 2022 18:33:13 -0800 From: Jakub Kicinski To: "Kubalewski, Arkadiusz" Cc: Jiri Pirko , Vadim Fedorenko , Jonathan Lemon , Paolo Abeni , "netdev@vger.kernel.org" , Vadim Fedorenko , "linux-arm-kernel@lists.infradead.org" , "linux-clk@vger.kernel.org" Subject: Re: [RFC PATCH v4 4/4] ptp_ocp: implement DPLL ops Message-ID: <20221206183313.713656f8@kernel.org> In-Reply-To: References: <20221129213724.10119-1-vfedorenko@novek.ru> <20221129213724.10119-5-vfedorenko@novek.ru> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221206_183315_999033_34B24205 X-CRM114-Status: GOOD ( 15.59 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, 2 Dec 2022 14:39:17 +0000 Kubalewski, Arkadiusz wrote: > >>>Btw, did you consider having dpll instance here as and auxdev? It > >>>would be suitable I believe. It is quite simple to do it. See > >>>following patch as an example: > >> > >>I haven't think about it, definetly gonna take a look to see if there > >>any benefits in ice. > > > >Please do. The proper separation and bus/device modelling is at least one > >of the benefits. The other one is that all dpll drivers would happily live > >in drivers/dpll/ side by side. > > Well, makes sense, but still need to take a closer look on that. > I could do that on ice-driver part, don't feel strong enough yet to introduce > Changes here in ptp_ocp. FWIW auxdev makes absolutely no sense to me for DPLL :/ So Jiri, please say why. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel