Re: [Buildroot] [PATCH v3 1/1] package/shadow: new package

["Yann E. MORIN" <yann.morin.1998@free.fr>]

Nicolas, All,

On 2022-12-09 11:07 +0000, Nicolas Carrier spake thusly:
> About the author name, don't bother, I don't mind if you take the
> ownership (read: the blame :D) of the script.

What one can do in this case, is add a co-author tag, like;

    Co-authored-by: Nicolas Carrier <Nicolas.Carrier@orolia.com>
    [Nicolas.Carrier@orolia.com provided the test case]
    Signed-off-by: Raphael Pavlidis <raphael.pavlidis@gmail.com>

> That said, maybe buildroot maintainers would like it to be expanded?
> I don't know the policy for this kind of tests, is it sufficient
> that it demonstrates that the package is able to build something that
> works or is it expected to have something more exhaustive?

It is perfectly fine to have a test case that demonstrates the basics of
the package. This helps prove that there are no missing runtime
dependencies (e.g. for pythn packages), that the basic features do work
as expected, at least in the use-case the submitter is interested in.

If there are more to test, it can be added as time passes (e.g. when we
get a report that something does not work).

We definitely do not want to be able to run the full test-suite of the
package itself; that's not our role.

> Also, there are those:
> self.assertRunOk(f'userdel {username} || true')
> self.assertRunOk(f'groupdel {username} || true')
> Which I had to had, but I never fully understood why they were needed.

assertRunOk() checks that the return code is zero, and drops the output.
So, if self.assertRunOk(f'userdel {username}') fails, then it means that
userdel in the target did fail, so it would be interesting to check why:

    output, ret = self.emulator.run(f'userdel {username}')
    self.assertEqual(ret, 0, f'Failed with {output!r}')

(I think in fact ythat this is what we should do in assertRunOk())

Regards,
Yann E. MORIN.

-- 
.-----------------.--------------------.------------------.--------------------.
|  Yann E. MORIN  | Real-Time Embedded | /"\ ASCII RIBBON | Erics' conspiracy: |
| +33 662 376 056 | Software  Designer | \ / CAMPAIGN     |  ___               |
| +33 561 099 427 `------------.-------:  X  AGAINST      |  \e/  There is no  |
| http://ymorin.is-a-geek.org/ | _/*\_ | / \ HTML MAIL    |   v   conspiracy.  |
'------------------------------^-------^------------------^--------------------'
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot