All of lore.kernel.org
 help / color / mirror / Atom feed
From: Palmer Dabbelt <palmer@rivosinc.com>
To: Arnd Bergmann <arnd@arndb.de>,
	linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Palmer Dabbelt <palmerdabbelt@google.com>,
	Palmer Dabbelt <palmer@rivosinc.com>
Subject: [PATCH v2 12/24] asm-generic: Remove COMMAND_LINE_SIZE from uapi
Date: Sat, 10 Dec 2022 22:13:46 -0800	[thread overview]
Message-ID: <20221211061358.28035-13-palmer@rivosinc.com> (raw)
In-Reply-To: <20221211061358.28035-1-palmer@rivosinc.com>

From: Palmer Dabbelt <palmerdabbelt@google.com>

As far as I can tell this is not used by userspace and thus should not
be part of the user-visible API.  Since <uapi/asm-generic/setup.h> only
contains COMMAND_LINE_SIZE we can just move it out of uapi to hide the
definition and fix up the only direct use in Loongarch.

Signed-off-by: Palmer Dabbelt <palmerdabbelt@google.com>
Link: https://lore.kernel.org/r/20210423025545.313965-1-palmer@dabbelt.com
Signed-off-by: Palmer Dabbelt <palmer@rivosinc.com>
---
The various empty <uapi/asm/setup.h> will soon be removed.
---
 Documentation/admin-guide/kernel-parameters.rst | 2 +-
 arch/loongarch/include/asm/setup.h              | 2 +-
 include/{uapi => }/asm-generic/setup.h          | 0
 include/uapi/asm-generic/Kbuild                 | 1 -
 4 files changed, 2 insertions(+), 3 deletions(-)
 rename include/{uapi => }/asm-generic/setup.h (100%)

diff --git a/Documentation/admin-guide/kernel-parameters.rst b/Documentation/admin-guide/kernel-parameters.rst
index 959f73a32712..3ba84ef68c4d 100644
--- a/Documentation/admin-guide/kernel-parameters.rst
+++ b/Documentation/admin-guide/kernel-parameters.rst
@@ -208,7 +208,7 @@ The number of kernel parameters is not limited, but the length of the
 complete command line (parameters including spaces etc.) is limited to
 a fixed number of characters. This limit depends on the architecture
 and is between 256 and 4096 characters. It is defined in the file
-./include/uapi/asm-generic/setup.h as COMMAND_LINE_SIZE.
+./include/asm-generic/setup.h as COMMAND_LINE_SIZE.
 
 Finally, the [KMG] suffix is commonly described after a number of kernel
 parameter values. These 'K', 'M', and 'G' letters represent the _binary_
diff --git a/arch/loongarch/include/asm/setup.h b/arch/loongarch/include/asm/setup.h
index ca373f8e3c4d..7a2afc95cc25 100644
--- a/arch/loongarch/include/asm/setup.h
+++ b/arch/loongarch/include/asm/setup.h
@@ -7,7 +7,7 @@
 #define _LOONGARCH_SETUP_H
 
 #include <linux/types.h>
-#include <uapi/asm/setup.h>
+#include <asm-generic/setup.h>
 
 #define VECSIZE 0x200
 
diff --git a/include/uapi/asm-generic/setup.h b/include/asm-generic/setup.h
similarity index 100%
rename from include/uapi/asm-generic/setup.h
rename to include/asm-generic/setup.h
diff --git a/include/uapi/asm-generic/Kbuild b/include/uapi/asm-generic/Kbuild
index ebb180aac74e..0e7122339ee9 100644
--- a/include/uapi/asm-generic/Kbuild
+++ b/include/uapi/asm-generic/Kbuild
@@ -20,7 +20,6 @@ mandatory-y += posix_types.h
 mandatory-y += ptrace.h
 mandatory-y += resource.h
 mandatory-y += sembuf.h
-mandatory-y += setup.h
 mandatory-y += shmbuf.h
 mandatory-y += sigcontext.h
 mandatory-y += siginfo.h
-- 
2.38.1


  parent reply	other threads:[~2022-12-11  6:19 UTC|newest]

Thread overview: 33+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-11  6:13 [PATCH v2 00/24] Remove COMMAND_LINE_SIZE from uapi Palmer Dabbelt
2022-12-11  6:13 ` [PATCH v2 01/24] alpha: " Palmer Dabbelt
2022-12-11  6:13 ` [PATCH v2 02/24] arm: " Palmer Dabbelt
2022-12-11  6:13 ` [PATCH v2 03/24] arm64: " Palmer Dabbelt
2022-12-11  6:13 ` [PATCH v2 04/24] ia64: " Palmer Dabbelt
2022-12-11  8:03   ` kernel test robot
2022-12-11  6:13 ` [PATCH v2 05/24] m68k: " Palmer Dabbelt
2023-01-16 10:07   ` Geert Uytterhoeven
2022-12-11  6:13 ` [PATCH v2 06/24] microblaze: " Palmer Dabbelt
2022-12-11  6:13 ` [PATCH v2 07/24] mips: " Palmer Dabbelt
2022-12-11  6:13 ` [PATCH v2 08/24] parisc: " Palmer Dabbelt
2022-12-11  6:13 ` [PATCH v2 09/24] powerpc: " Palmer Dabbelt
2022-12-11  6:13 ` [PATCH v2 10/24] sparc: " Palmer Dabbelt
2022-12-11  6:13 ` [PATCH v2 11/24] xtensa: " Palmer Dabbelt
2022-12-11  6:13 ` Palmer Dabbelt [this message]
2022-12-11  7:42   ` [PATCH v2 12/24] asm-generic: " kernel test robot
2022-12-11 11:04   ` kernel test robot
2022-12-11  6:13 ` [PATCH v2 13/24] alpha: Remove empty <uapi/asm/setup.h> Palmer Dabbelt
2022-12-11  6:13 ` [PATCH v2 14/24] arc: " Palmer Dabbelt
2022-12-11  6:13 ` [PATCH v2 15/24] arm64: " Palmer Dabbelt
2022-12-11  6:13 ` [PATCH v2 16/24] m68k: " Palmer Dabbelt
2023-01-16 10:07   ` Geert Uytterhoeven
2022-12-11  6:13 ` [PATCH v2 17/24] microblaze: " Palmer Dabbelt
2022-12-11  6:13 ` [PATCH v2 18/24] mips: " Palmer Dabbelt
2022-12-11  6:13 ` [PATCH v2 19/24] parisc: " Palmer Dabbelt
2022-12-11  6:13 ` [PATCH v2 20/24] powerpc: " Palmer Dabbelt
2022-12-11  6:13 ` [PATCH v2 21/24] s390: " Palmer Dabbelt
2022-12-11  6:13 ` [PATCH v2 22/24] sparc: " Palmer Dabbelt
2022-12-11  6:13 ` [PATCH v2 23/24] x86: " Palmer Dabbelt
2022-12-11  6:13 ` [PATCH v2 24/24] xtensa: " Palmer Dabbelt
2023-02-10 17:10 ` [PATCH v2 00/24] Remove COMMAND_LINE_SIZE from uapi Alexandre Ghiti
2023-02-10 19:37   ` Arnd Bergmann
2023-02-13  7:40     ` Alexandre Ghiti

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221211061358.28035-13-palmer@rivosinc.com \
    --to=palmer@rivosinc.com \
    --cc=arnd@arndb.de \
    --cc=linux-arch@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=palmerdabbelt@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.