From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C1809C4332F for ; Thu, 15 Dec 2022 21:02:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229562AbiLOVCw (ORCPT ); Thu, 15 Dec 2022 16:02:52 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48188 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229471AbiLOVCv (ORCPT ); Thu, 15 Dec 2022 16:02:51 -0500 Received: from relay07.th.seeweb.it (relay07.th.seeweb.it [5.144.164.168]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 39B0A528AF for ; Thu, 15 Dec 2022 13:02:49 -0800 (PST) Received: from SoMainline.org (94-209-172-39.cable.dynamic.v4.ziggo.nl [94.209.172.39]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by m-r2.th.seeweb.it (Postfix) with ESMTPSA id 242233EEE0; Thu, 15 Dec 2022 22:02:48 +0100 (CET) Date: Thu, 15 Dec 2022 22:02:46 +0100 From: Marijn Suijten To: Konrad Dybcio Cc: phone-devel@vger.kernel.org, Bjorn Andersson , ~postmarketos/upstreaming@lists.sr.ht, AngeloGioacchino Del Regno , Konrad Dybcio , Martin Botka , Jami Kettunen , Andy Gross , Rob Herring , Krzysztof Kozlowski , AngeloGioacchino Del Regno , Luca Weiss , Adam Skladowski , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 4/6] arm64: dts: qcom: msm8976: Declare and use SDC1 pins Message-ID: <20221215210246.rcx7f6unbhj52dkb@SoMainline.org> Mail-Followup-To: Marijn Suijten , Konrad Dybcio , phone-devel@vger.kernel.org, Bjorn Andersson , ~postmarketos/upstreaming@lists.sr.ht, AngeloGioacchino Del Regno , Konrad Dybcio , Martin Botka , Jami Kettunen , Andy Gross , Rob Herring , Krzysztof Kozlowski , AngeloGioacchino Del Regno , Luca Weiss , Adam Skladowski , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20221214232049.703484-1-marijn.suijten@somainline.org> <20221214232049.703484-5-marijn.suijten@somainline.org> <60a40ace-d4e9-df74-88f9-4354d80efaac@linaro.org> <20221215210010.on44gmoefbnsokvt@SoMainline.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221215210010.on44gmoefbnsokvt@SoMainline.org> Precedence: bulk List-ID: X-Mailing-List: linux-arm-msm@vger.kernel.org On 2022-12-15 22:00:12, Marijn Suijten wrote: > On 2022-12-15 14:19:41, Konrad Dybcio wrote: > > > > > > On 15.12.2022 00:20, Marijn Suijten wrote: > > > Add the pinctrl states for SDC1 and use them on sdhc_1. > > > > > > Signed-off-by: Marijn Suijten > > > --- > > > arch/arm64/boot/dts/qcom/msm8976.dtsi | 55 +++++++++++++++++++++++++++ > > > 1 file changed, 55 insertions(+) > > > > > > diff --git a/arch/arm64/boot/dts/qcom/msm8976.dtsi b/arch/arm64/boot/dts/qcom/msm8976.dtsi > > > index 05dcb30b0779..7d4c7548882c 100644 > > > --- a/arch/arm64/boot/dts/qcom/msm8976.dtsi > > > +++ b/arch/arm64/boot/dts/qcom/msm8976.dtsi > > > @@ -508,6 +508,56 @@ tlmm: pinctrl@1000000 { > > > interrupt-controller; > > > #interrupt-cells = <2>; > > > > > > + sdc1_off_state: sdc1-off-state { > > > + clk-pins { > > > + pins = "sdc1_clk"; > > > + drive-strength = <2>; > > > + bias-disable; > > > + }; > > > + > > > + cmd-pins { > > > + pins = "sdc1_cmd"; > > > + drive-strength = <2>; > > > + bias-pull-up; > > > + }; > > > + > > > + data-pins { > > > + pins = "sdc1_data"; > > > + drive-strength = <2>; > > > + bias-pull-up; > > > + }; > > > + > > > + rclk-pins { > > > + pins = "sdc1_rclk"; > > > + bias-pull-down; > > > + }; > > > + }; > > > + > > > + sdc1_on_state: sdc1-on-state { > > > + clk-pins { > > > + pins = "sdc1_clk"; > > > + drive-strength = <16>; > > > + bias-disable; > > > + }; > > > + > > > + cmd-pins { > > > + pins = "sdc1_cmd"; > > > + drive-strength = <10>; > > > + bias-pull-up; > > > + }; > > > + > > > + data-pins { > > > + pins = "sdc1_data"; > > > + drive-strength = <10>; > > > + bias-pull-up; > > > + }; > > > + > > > + rclk-pins { > > > + pins = "sdc1_rclk"; > > > + bias-pull-down; > > > + }; > > > + }; > > > + > > > spi1_default: spi0-default-state { > > > spi-pins { > > > pins = "gpio0", "gpio1", "gpio3"; > > > @@ -680,6 +730,11 @@ sdhc_1: mmc@7824000 { > > > <&gcc GCC_SDCC1_APPS_CLK>, > > > <&rpmcc RPM_SMD_XO_CLK_SRC>; > > > clock-names = "iface", "core", "xo"; > > > + > > > + pinctrl-0 = <&sdc1_on_state>; > > > + pinctrl-1 = <&sdc1_off_state>; > > > + pinctrl-names = "default", "sleep"; > > pinctrl-names usually goes before pinctrl-N > > I thought I had seen them _after_ nowadays, same for reg-names, > phy-names, interrupt-names and clock-names. What is it? > > Regardless, I'd rather keep this consistent across this file (sdc2 also > has it after, same for other *-names) Excuse me, I was looking at sm6125 DT while writing this, sdc2 for msm8976 is introduced _and used by sdhc_2 in a followup patch. The other points still stand though, everything has -names last. - Marijn > and correct it at once in a > separate patch, if someone really cares. > > But really, we should have a checker/autoformatter for these "rules", > instead of all this manual back-and-forth (is this order already set in > stone under Documentation/ or something?). > > - Marijn