Hi Thomas, I love your patch! Yet something to improve: [auto build test ERROR on drm-misc/drm-misc-next] [also build test ERROR on linus/master next-20221216] [cannot apply to v6.1] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Thomas-Zimmermann/fbdev-Remove-struct-fb_ops-fb_release-return-type/20221216-195534 base: git://anongit.freedesktop.org/drm/drm-misc drm-misc-next patch link: https://lore.kernel.org/r/20221216115404.20742-3-tzimmermann%40suse.de patch subject: [PATCH 2/2] fbdev: Don't return value from struct fb_ops.fb_release config: m68k-allmodconfig compiler: m68k-linux-gcc (GCC) 12.1.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/72db2b622f0ef071b50d271a4992cb5a1c2b0a2a git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Thomas-Zimmermann/fbdev-Remove-struct-fb_ops-fb_release-return-type/20221216-195534 git checkout 72db2b622f0ef071b50d271a4992cb5a1c2b0a2a # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=m68k olddefconfig COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=m68k SHELL=/bin/bash drivers/video/ If you fix the issue, kindly add following tag where applicable | Reported-by: kernel test robot All errors (new ones prefixed by >>): >> drivers/video/fbdev/omap2/omapfb/omapfb-main.c:1282:27: error: initialization of 'void (*)(struct fb_info *, int)' from incompatible pointer type 'int (*)(struct fb_info *, int)' [-Werror=incompatible-pointer-types] 1282 | .fb_release = omapfb_release, | ^~~~~~~~~~~~~~ drivers/video/fbdev/omap2/omapfb/omapfb-main.c:1282:27: note: (near initialization for 'omapfb_ops.fb_release') cc1: some warnings being treated as errors vim +1282 drivers/video/fbdev/omap2/omapfb/omapfb-main.c b39a982ddecf1d drivers/video/omap2/omapfb/omapfb-main.c Tomi Valkeinen 2009-08-04 1278 8a48ac339398f2 drivers/video/fbdev/omap2/omapfb/omapfb-main.c Jani Nikula 2019-12-03 1279 static const struct fb_ops omapfb_ops = { b39a982ddecf1d drivers/video/omap2/omapfb/omapfb-main.c Tomi Valkeinen 2009-08-04 1280 .owner = THIS_MODULE, b39a982ddecf1d drivers/video/omap2/omapfb/omapfb-main.c Tomi Valkeinen 2009-08-04 1281 .fb_open = omapfb_open, b39a982ddecf1d drivers/video/omap2/omapfb/omapfb-main.c Tomi Valkeinen 2009-08-04 @1282 .fb_release = omapfb_release, b39a982ddecf1d drivers/video/omap2/omapfb/omapfb-main.c Tomi Valkeinen 2009-08-04 1283 .fb_fillrect = cfb_fillrect, b39a982ddecf1d drivers/video/omap2/omapfb/omapfb-main.c Tomi Valkeinen 2009-08-04 1284 .fb_copyarea = cfb_copyarea, b39a982ddecf1d drivers/video/omap2/omapfb/omapfb-main.c Tomi Valkeinen 2009-08-04 1285 .fb_imageblit = cfb_imageblit, b39a982ddecf1d drivers/video/omap2/omapfb/omapfb-main.c Tomi Valkeinen 2009-08-04 1286 .fb_blank = omapfb_blank, b39a982ddecf1d drivers/video/omap2/omapfb/omapfb-main.c Tomi Valkeinen 2009-08-04 1287 .fb_ioctl = omapfb_ioctl, b39a982ddecf1d drivers/video/omap2/omapfb/omapfb-main.c Tomi Valkeinen 2009-08-04 1288 .fb_check_var = omapfb_check_var, b39a982ddecf1d drivers/video/omap2/omapfb/omapfb-main.c Tomi Valkeinen 2009-08-04 1289 .fb_set_par = omapfb_set_par, b39a982ddecf1d drivers/video/omap2/omapfb/omapfb-main.c Tomi Valkeinen 2009-08-04 1290 .fb_pan_display = omapfb_pan_display, b39a982ddecf1d drivers/video/omap2/omapfb/omapfb-main.c Tomi Valkeinen 2009-08-04 1291 .fb_mmap = omapfb_mmap, b39a982ddecf1d drivers/video/omap2/omapfb/omapfb-main.c Tomi Valkeinen 2009-08-04 1292 .fb_setcolreg = omapfb_setcolreg, b39a982ddecf1d drivers/video/omap2/omapfb/omapfb-main.c Tomi Valkeinen 2009-08-04 1293 .fb_setcmap = omapfb_setcmap, b39a982ddecf1d drivers/video/omap2/omapfb/omapfb-main.c Tomi Valkeinen 2009-08-04 1294 /*.fb_write = omapfb_write,*/ b39a982ddecf1d drivers/video/omap2/omapfb/omapfb-main.c Tomi Valkeinen 2009-08-04 1295 }; b39a982ddecf1d drivers/video/omap2/omapfb/omapfb-main.c Tomi Valkeinen 2009-08-04 1296 -- 0-DAY CI Kernel Test Service https://01.org/lkp