All of lore.kernel.org
 help / color / mirror / Atom feed
From: shravan kumar <shravan.chippa@microchip.com>
To: <paul.j.murphy@intel.com>, <daniele.alessandrelli@intel.com>,
	<mchehab@kernel.org>
Cc: <linux-media@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	"shravan kumar" <shravan.chippa@microchip.com>,
	Jacopo Mondi <jacopo@jmondi.org>
Subject: [PATCH v7 2/5] media: i2c: imx334: replace __v4l2_ctrl_s_ctrl to __v4l2_ctrl_modify_range
Date: Mon, 19 Dec 2022 11:45:23 +0530	[thread overview]
Message-ID: <20221219061526.3169369-3-shravan.chippa@microchip.com> (raw)
In-Reply-To: <20221219061526.3169369-1-shravan.chippa@microchip.com>

From: Shravan Chippa <shravan.chippa@microchip.com>

For evry mode we will get new set of values for hbalnk so use
__v4l2_ctrl_modify_range() to support multi modes for hblank.

The hblank value is readonly in the driver. because of this the function
returns error if we try to change. so added dumy return case in
imx334_set_ctrl function

Suggested-by: Jacopo Mondi <jacopo@jmondi.org>
Signed-off-by: Shravan Chippa <shravan.chippa@microchip.com>
---
 drivers/media/i2c/imx334.c | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/drivers/media/i2c/imx334.c b/drivers/media/i2c/imx334.c
index acc9f9f15e47..a742b60ea3b0 100644
--- a/drivers/media/i2c/imx334.c
+++ b/drivers/media/i2c/imx334.c
@@ -382,7 +382,8 @@ static int imx334_update_controls(struct imx334 *imx334,
 	if (ret)
 		return ret;
 
-	ret = __v4l2_ctrl_s_ctrl(imx334->hblank_ctrl, mode->hblank);
+	ret = __v4l2_ctrl_modify_range(imx334->hblank_ctrl, mode->hblank,
+				       mode->hblank, 1, mode->hblank);
 	if (ret)
 		return ret;
 
@@ -480,6 +481,9 @@ static int imx334_set_ctrl(struct v4l2_ctrl *ctrl)
 
 		pm_runtime_put(imx334->dev);
 
+		break;
+	case V4L2_CID_HBLANK:
+		ret = 0;
 		break;
 	default:
 		dev_err(imx334->dev, "Invalid control %d", ctrl->id);
-- 
2.34.1


  parent reply	other threads:[~2022-12-19  6:15 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-19  6:15 [PATCH v7 0/5] media: i2c: imx334: support lower bandwidth mode shravan kumar
2022-12-19  6:15 ` [PATCH v7 1/5] media: i2c: imx334: modify link frequency as for the configureation shravan kumar
2022-12-19 14:44   ` Jacopo Mondi
2022-12-20 11:11     ` Shravan.Chippa
2022-12-21  8:43       ` Jacopo Mondi
2022-12-19  6:15 ` shravan kumar [this message]
2022-12-19  6:15 ` [PATCH v7 3/5] media: i2c: imx334: add missing reset values for mode 3840x2160_regs[] shravan kumar
2022-12-19  6:15 ` [PATCH v7 4/5] media: i2c: imx334: support lower bandwidth mode shravan kumar
2022-12-19  6:15 ` [PATCH v7 5/5] media: i2c: imx334: update pixel and link frequency shravan kumar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221219061526.3169369-3-shravan.chippa@microchip.com \
    --to=shravan.chippa@microchip.com \
    --cc=daniele.alessandrelli@intel.com \
    --cc=jacopo@jmondi.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mchehab@kernel.org \
    --cc=paul.j.murphy@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.