All of lore.kernel.org
 help / color / mirror / Atom feed
From: Gustavo Sousa <gustavo.sousa@intel.com>
To: Jani Nikula <jani.nikula@linux.intel.com>,
	<intel-gfx@lists.freedesktop.org>
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Subject: Re: [Intel-gfx] [PATCH 2/2] drm/i915/dmc: Use unversioned firmware paths
Date: Wed, 21 Dec 2022 12:08:36 -0300	[thread overview]
Message-ID: <20221221150836.vgzyogiyv5oogawi@gjsousa-mobl2> (raw)
In-Reply-To: <87wn6l1299.fsf@intel.com>

On Wed, Dec 21, 2022 at 12:26:26PM +0200, Jani Nikula wrote:
> > -	request_firmware(&fw, dev_priv->display.dmc.fw_path, dev_priv->drm.dev);
> > +	err = firmware_request_nowarn(&fw, dev_priv->display.dmc.fw_path, dev_priv->drm.dev);
> > +
> > +	if (err == -ENOENT && !dev_priv->params.dmc_firmware_path) {
> > +		legacy_path = dmc_legacy_path(dev_priv);
> > +		if (legacy_path) {
> > +			drm_dbg_kms(&dev_priv->drm,
> > +				    "%s not found, falling back to %s\n",
> > +				    dmc->fw_path,
> > +				    legacy_path);
> > +			err = firmware_request_nowarn(&fw, legacy_path, dev_priv->drm.dev);
> > +			if (err == 0)
> > +				dev_priv->display.dmc.fw_path = legacy_path;
> > +		}
> > +	}
> > +
> 
> I'd keep the request_firmware() with warnings.

Thanks. Just sent a v2 with that.

--
Gustavo Sousa

  reply	other threads:[~2022-12-21 15:08 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-20 20:11 [Intel-gfx] [PATCH 0/2] drm/i915/dmc: Make firmware loading backwards-compatible Gustavo Sousa
2022-12-20 20:11 ` [Intel-gfx] [PATCH 1/2] drm/i915/dmc: Do not require specific versions Gustavo Sousa
2022-12-20 20:11 ` [Intel-gfx] [PATCH 2/2] drm/i915/dmc: Use unversioned firmware paths Gustavo Sousa
2022-12-21 10:26   ` Jani Nikula
2022-12-21 15:08     ` Gustavo Sousa [this message]
2022-12-22  0:23     ` Lucas De Marchi
2022-12-22 22:12       ` Gustavo Sousa
2022-12-23  0:52         ` Lucas De Marchi
2022-12-23 11:51           ` Gustavo Sousa
2022-12-23 15:36             ` Rodrigo Vivi
2022-12-28 22:00               ` Gustavo Sousa
2022-12-28 22:04                 ` Vivi, Rodrigo
2022-12-28 22:19                   ` Gustavo Sousa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221221150836.vgzyogiyv5oogawi@gjsousa-mobl2 \
    --to=gustavo.sousa@intel.com \
    --cc=intel-gfx@lists.freedesktop.org \
    --cc=jani.nikula@linux.intel.com \
    --cc=rodrigo.vivi@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.