From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B3510C4332F for ; Thu, 22 Dec 2022 08:57:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=fhksycmUaU+NX73Numw2Y1nUT8DHjRhcXfmXurG0ciA=; b=nuhiYvxjv1i0btP8B0ZpPyDvjT wzHGNXwHPDtktoWau0B0Aj9QkFgfgk/WmqrelLQkm8nBMnicsr7QpXj/8KyujKm/h4R82WsXQYloS QexYRE4vnBzFKYkswGhHUvvB2RIbL3wctgUezP0yWmhsqQaPI2DS9jc+Tu/eFATTaTmWTRem9lMjY PLUz8Aj3u4xbte7P43KyFLbParGK43XoUmdJHYFr7BgBglF2Al+821Ji+72UfpFssRz8eJBmOD4Pa 5PRmmVPM7VUJLkVfS7/fWFgpIRBWqBvsGvIaEXZR1HchNvAcg0Cr+158mrdYsiqt9ibyrl5svxWl2 OkqcnIZA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1p8HOe-009Ort-Tv; Thu, 22 Dec 2022 08:57:48 +0000 Received: from verein.lst.de ([213.95.11.211]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1p8HOX-009Ogj-Sa for linux-nvme@lists.infradead.org; Thu, 22 Dec 2022 08:57:43 +0000 Received: by verein.lst.de (Postfix, from userid 2407) id 125AD67373; Thu, 22 Dec 2022 09:57:38 +0100 (CET) Date: Thu, 22 Dec 2022 09:57:37 +0100 From: Christoph Hellwig To: Keith Busch Cc: Christoph Hellwig , Sagi Grimberg , Chaitanya Kulkarni , Kanchan Joshi , linux-nvme@lists.infradead.org Subject: Re: [PATCH 5/6] nvme: also return I/O command effects from nvme_command_effects Message-ID: <20221222085737.GA13174@lst.de> References: <20221221101050.759606-1-hch@lst.de> <20221221101050.759606-6-hch@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221222_005742_130349_5715D736 X-CRM114-Status: GOOD ( 12.41 ) X-BeenThere: linux-nvme@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "Linux-nvme" Errors-To: linux-nvme-bounces+linux-nvme=archiver.kernel.org@lists.infradead.org On Wed, Dec 21, 2022 at 02:42:47PM -0700, Keith Busch wrote: > Just noticed we need to mask out the CSE value for IO commands in case > some crazy controller sets it. If the driver were to see that value as > non-zero, it will freeze the IO queue the ioctl requires to to submit > its own IO request. I'd rather reject passthrough of I/O commands with that effect entirely, does that sound reasonable?