All of
 help / color / mirror / Atom feed
From: Ammar Faizi <>
To: Greg Kroah-Hartman <>
Cc: Ammar Faizi <>,
	"Rafael J. Wysocki" <>,
	Linux Kernel Mailing List <>,
	Nathan Chancellor <>,
	Nick Desaulniers <>,
	Tom Rix <>,
	LLVM Mailing List <>
Subject: [PATCH v1] driver core: Silence 'unused-but-set variable' warning
Date: Fri, 23 Dec 2022 21:51:37 +0700	[thread overview]
Message-ID: <> (raw)

From: Ammar Faizi <>

Compiling with clang-16:

  drivers/base/module.c:36:6: error: variable 'no_warn' set but not \
  used [-Werror,-Wunused-but-set-variable]
          int no_warn;
  1 error generated.

A reason the @no_warn variable exists is:
sysfs_create_link() return value needs not be ignored to silence
another warning.

So don't remove @no_warn, but add a '(void)no_warn;'.

Cc: LLVM Mailing List <>
Signed-off-by: Ammar Faizi <>
 drivers/base/module.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/base/module.c b/drivers/base/module.c
index 46ad4d636731..42f0b3b9e7f8 100644
--- a/drivers/base/module.c
+++ b/drivers/base/module.c
@@ -59,22 +59,23 @@ void module_add_driver(struct module *mod, struct device_driver *drv)
 	/* Don't check return codes; these calls are idempotent */
 	no_warn = sysfs_create_link(&drv->p->kobj, &mk->kobj, "module");
 	driver_name = make_driver_name(drv);
 	if (driver_name) {
 		no_warn = sysfs_create_link(mk->drivers_dir, &drv->p->kobj,
+	(void)no_warn;
 void module_remove_driver(struct device_driver *drv)
 	struct module_kobject *mk = NULL;
 	char *driver_name;
 	if (!drv)
 	sysfs_remove_link(&drv->p->kobj, "module");

base-commit: 8395ae05cb5a2e31d36106e8c85efa11cda849be
Ammar Faizi

             reply	other threads:[~2022-12-23 14:52 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-23 14:51 Ammar Faizi [this message]
2022-12-23 15:02 ` [PATCH v1] driver core: Silence 'unused-but-set variable' warning Greg Kroah-Hartman
2022-12-23 15:31   ` Ammar Faizi
2022-12-23 17:31     ` Nathan Chancellor

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.