From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id CBF95C4332F for ; Fri, 23 Dec 2022 15:04:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236480AbiLWPEE (ORCPT ); Fri, 23 Dec 2022 10:04:04 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44404 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236485AbiLWPEC (ORCPT ); Fri, 23 Dec 2022 10:04:02 -0500 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id E94DD4494D for ; Fri, 23 Dec 2022 07:03:57 -0800 (PST) Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1p8jaF-0003OG-2Y; Fri, 23 Dec 2022 16:03:39 +0100 Received: from mfe by ptx.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1p8jaE-0003rM-Ea; Fri, 23 Dec 2022 16:03:38 +0100 Date: Fri, 23 Dec 2022 16:03:38 +0100 From: Marco Felsch To: Jonathan Cameron Cc: puranjay12@gmail.com, lars@metafoo.de, robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org, linux-iio@vger.kernel.org, devicetree@vger.kernel.org, kernel@pengutronix.de Subject: Re: [PATCH v2 2/4] dt-bindings: iio: ti,tmp117: add binding for the TMP116 Message-ID: <20221223150338.iqpnp6z3m35eb5hz@pengutronix.de> References: <20221221092801.1977499-1-m.felsch@pengutronix.de> <20221221092801.1977499-3-m.felsch@pengutronix.de> <20221223150803.37e2939d@jic23-huawei> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221223150803.37e2939d@jic23-huawei> User-Agent: NeoMutt/20180716 X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: mfe@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: devicetree@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 22-12-23, Jonathan Cameron wrote: > On Wed, 21 Dec 2022 10:27:59 +0100 > Marco Felsch wrote: > > > The TMP116 is the predecessor of the TMP117. > > > > Signed-off-by: Marco Felsch > I'm not sure this is introducing a valid fallback. The driver changes > imply some things the tmp117 driver supports, that this device > does not. A fallback compatible would mean that a new DT > with an old kernel would load the tmp117 against a tmp116 and > expect it to fully work. Since driver does all the detection an update of the bindings isn't really necessary. It is just to have a compatible already in place in case there a things we can't detected during runtime. This flow is common for a lot of SoC drivers. The fallback will be used as long as possible and once a specific feature can't be detected only via the binding, the driver adds the new binding to it of_compatible. Regards, Marco > An example is calibbias which you've dropped from the channels > array entry. > > Jonathan > > > > --- > > v2: > > - drop items from single enum > > > > .../bindings/iio/temperature/ti,tmp117.yaml | 14 ++++++++++---- > > 1 file changed, 10 insertions(+), 4 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/iio/temperature/ti,tmp117.yaml b/Documentation/devicetree/bindings/iio/temperature/ti,tmp117.yaml > > index 8d1ec4d39b28..9b78357d6a79 100644 > > --- a/Documentation/devicetree/bindings/iio/temperature/ti,tmp117.yaml > > +++ b/Documentation/devicetree/bindings/iio/temperature/ti,tmp117.yaml > > @@ -7,8 +7,9 @@ $schema: "http://devicetree.org/meta-schemas/core.yaml#" > > title: "TI TMP117 - Digital temperature sensor with integrated NV memory" > > > > description: | > > - TI TMP117 - Digital temperature sensor with integrated NV memory that supports > > - I2C interface. > > + TI TMP116/117 - Digital temperature sensor with integrated NV memory that > > + supports I2C interface. > > + https://www.ti.com/lit/gpn/tmp116 > > https://www.ti.com/lit/gpn/tmp117 > > > > maintainers: > > @@ -16,8 +17,13 @@ maintainers: > > > > properties: > > compatible: > > - enum: > > - - ti,tmp117 > > + oneOf: > > + - enum: > > + - ti,tmp117 > > + - items: > > + - enum: > > + - ti,tmp116 > > + - const: ti,tmp117 > > > > reg: > > maxItems: 1 > >