All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] iio:adc:twl6030: Enable measurement of VAC
@ 2022-12-17 22:13 Andreas Kemnade
  2022-12-23 16:02 ` Jonathan Cameron
  0 siblings, 1 reply; 2+ messages in thread
From: Andreas Kemnade @ 2022-12-17 22:13 UTC (permalink / raw)
  To: jic23, lars, andreas, paul, jiasheng, oleksandr.kozaruk, gg,
	balajitk, linux-iio, linux-kernel
  Cc: kernel test robot, Julia Lawall

VAC needs to be wired up to produce proper measurements,
without this change only near zero values are reported.

Reported-by: kernel test robot <lkp@intel.com>
Reported-by: Julia Lawall <julia.lawall@lip6.fr>
Fixes: 1696f36482e7 ("iio: twl6030-gpadc: TWL6030, TWL6032 GPADC driver")
Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
---
 drivers/iio/adc/twl6030-gpadc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/iio/adc/twl6030-gpadc.c b/drivers/iio/adc/twl6030-gpadc.c
index 40438e5b4970..32873fb5f367 100644
--- a/drivers/iio/adc/twl6030-gpadc.c
+++ b/drivers/iio/adc/twl6030-gpadc.c
@@ -952,7 +952,7 @@ static int twl6030_gpadc_probe(struct platform_device *pdev)
 	}
 
 	ret = twl_i2c_write_u8(TWL6030_MODULE_ID0,
-				VBAT_MEAS | BB_MEAS | BB_MEAS,
+				VBAT_MEAS | BB_MEAS | VAC_MEAS,
 				TWL6030_MISC1);
 	if (ret < 0) {
 		dev_err(dev, "failed to wire up inputs\n");
-- 
2.30.2


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] iio:adc:twl6030: Enable measurement of VAC
  2022-12-17 22:13 [PATCH] iio:adc:twl6030: Enable measurement of VAC Andreas Kemnade
@ 2022-12-23 16:02 ` Jonathan Cameron
  0 siblings, 0 replies; 2+ messages in thread
From: Jonathan Cameron @ 2022-12-23 16:02 UTC (permalink / raw)
  To: Andreas Kemnade
  Cc: lars, paul, jiasheng, oleksandr.kozaruk, gg, balajitk, linux-iio,
	linux-kernel, kernel test robot, Julia Lawall

On Sat, 17 Dec 2022 23:13:05 +0100
Andreas Kemnade <andreas@kemnade.info> wrote:

> VAC needs to be wired up to produce proper measurements,
> without this change only near zero values are reported.
> 
> Reported-by: kernel test robot <lkp@intel.com>
> Reported-by: Julia Lawall <julia.lawall@lip6.fr>
> Fixes: 1696f36482e7 ("iio: twl6030-gpadc: TWL6030, TWL6032 GPADC driver")
> Signed-off-by: Andreas Kemnade <andreas@kemnade.info>
Applied to the fixes-togreg branch of iio.git.

Thanks,

Jonathan

> ---
>  drivers/iio/adc/twl6030-gpadc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/iio/adc/twl6030-gpadc.c b/drivers/iio/adc/twl6030-gpadc.c
> index 40438e5b4970..32873fb5f367 100644
> --- a/drivers/iio/adc/twl6030-gpadc.c
> +++ b/drivers/iio/adc/twl6030-gpadc.c
> @@ -952,7 +952,7 @@ static int twl6030_gpadc_probe(struct platform_device *pdev)
>  	}
>  
>  	ret = twl_i2c_write_u8(TWL6030_MODULE_ID0,
> -				VBAT_MEAS | BB_MEAS | BB_MEAS,
> +				VBAT_MEAS | BB_MEAS | VAC_MEAS,
>  				TWL6030_MISC1);
>  	if (ret < 0) {
>  		dev_err(dev, "failed to wire up inputs\n");


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2022-12-23 15:48 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-12-17 22:13 [PATCH] iio:adc:twl6030: Enable measurement of VAC Andreas Kemnade
2022-12-23 16:02 ` Jonathan Cameron

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.