All of lore.kernel.org
 help / color / mirror / Atom feed
From: Armin Wolf <W_Armin@gmx.de>
To: jdelvare@suse.com, linux@roeck-us.net
Cc: linux-hwmon@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: [PATCH 0/3] hwmon: (ftsteutates) Various fixes
Date: Sat, 24 Dec 2022 05:18:52 +0100	[thread overview]
Message-ID: <20221224041855.83981-1-W_Armin@gmx.de> (raw)

Merry Christmas,

a user reported strange sensors values when using the ftsteutates driver
on kernel 6.1. A bit of research revealed that the drivers was omiting
any scaling of the measurements, causing strange sensor values being
reported with the sensors command. This was likely done since when the
ftsteutates driver was still out-of-tree, all scaling was done by
libsensors with an custom config file provided by Fujitsu.
The first patch fixes this issue.

The seconds patch converts the driver to use the modern *_with_info() API
and also adds support for fanX_fault and pwmX_auto_channels_temp attributes.
Since the behaviour of the pwmX_auto_channels_temp attributes is a bit
special with the teutates BMC, it is added to the drivers documentation.

The last patch is a minor improvement regarding the watchdog registration.

All changes where tested on a Fujitsu DS3401-B1 and apppear to work.

Armin Wolf (3):
  hwmon: (ftsteutates) Fix scaling of measurements
  hwmon: (ftsteutates) Convert to devm_hwmon_device_register_with_info()
  hwmon: (ftsteutates) Use devm_watchdog_register_device()

 Documentation/hwmon/ftsteutates.rst |   9 +
 drivers/hwmon/ftsteutates.c         | 551 ++++++++++------------------
 2 files changed, 213 insertions(+), 347 deletions(-)

--
2.30.2


             reply	other threads:[~2022-12-24  4:19 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-24  4:18 Armin Wolf [this message]
2022-12-24  4:18 ` [PATCH 1/3] hwmon: (ftsteutates) Fix scaling of measurements Armin Wolf
2022-12-29 14:26   ` Guenter Roeck
2022-12-24  4:18 ` [PATCH 2/3] hwmon: (ftsteutates) Convert to devm_hwmon_device_register_with_info() Armin Wolf
2022-12-24 15:18   ` Guenter Roeck
2022-12-31 11:40     ` Armin Wolf
2022-12-31 14:52       ` Guenter Roeck
2022-12-24  4:18 ` [PATCH 3/3] hwmon: (ftsteutates) Use devm_watchdog_register_device() Armin Wolf
2022-12-29 14:29   ` Guenter Roeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221224041855.83981-1-W_Armin@gmx.de \
    --to=w_armin@gmx.de \
    --cc=jdelvare@suse.com \
    --cc=linux-hwmon@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@roeck-us.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.