From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.90_1) id 1p8w16-0002m7-2i for mharc-grub-devel@gnu.org; Fri, 23 Dec 2022 23:20:12 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1p8w11-0002lS-J5 for grub-devel@gnu.org; Fri, 23 Dec 2022 23:20:08 -0500 Received: from mail-pj1-x102a.google.com ([2607:f8b0:4864:20::102a]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1p8w10-0000MT-4Z for grub-devel@gnu.org; Fri, 23 Dec 2022 23:20:07 -0500 Received: by mail-pj1-x102a.google.com with SMTP id hd14-20020a17090b458e00b0021909875bccso8934809pjb.1 for ; Fri, 23 Dec 2022 20:20:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=efficientek-com.20210112.gappssmtp.com; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=aTHZ5jwn+0RHFH4/dk7uWX8F0EF4dPOSIsyuKUfcy4s=; b=Kp0xl23rm1ey/uqz8pTayBvQ8Ixgj6zRblQFGUIkWNogbDZZNg6k5d2c6EFKN/7wGd u/+VrvMG5NSnpC6ANRUoMDM+cqQU4AntqrasQ2OVrfhCjqXE3vWni5XswDQxubmpeQIL M5D+iWG8C1WdZZEyVreiHVaI3eFIXxDfqr1UFuVhtLr9JHPcsB7C6f1xO3CkCOtEmLZ9 FeH0G/7UkZXvdFtlqUzC41w5GuwmZtXwibzcFS7UMH4SVmCc9fnJPZyhWKbeeFg1o7AH VOXys9Mow+bpUnglfK5AaJosqtyPlRzwkvSYRp3JEuvk9hwU9/PgQv9NSbG86VnWGigG Vqpw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=aTHZ5jwn+0RHFH4/dk7uWX8F0EF4dPOSIsyuKUfcy4s=; b=FIp0HFM83sI/Lc90hhoZtudtBUS9e1j6jcLSMXrSKo7phkrTisjOM+AjNQ4nW636ez FYp6Xrkj8yZiVXFm+iu/yHazkOhyGspaduFNAty6eTBMp80Rb5/J17kJk9Pz3OkRgFRL LkwfQfG9kQ1/IuXxXd6wL9WTvUk/AEkp+flpLWnr8pGTqS61tsbF07djA5/IExgccOwJ BAa/JKYgkMBVn86/RjMUIfHUN2VPDucE0vJHyJAa3QnliCZRtyBsCpwQdNI7zZeWkqVt 1K6wAgPgW++3EiMVIWkqxqn3s5zlgy4MCe2JV4ZYls2kY/fw8KNyu3jVW/Nhn5Zlxxkh jD1Q== X-Gm-Message-State: AFqh2kqj63zbnEOL8IkGBWhzadllLYd1kBKP1g0/IZZvdwhO7BxGursQ k+AffPexz/MThA4GGP8AYrRGvpOzzB+XtaK2 X-Google-Smtp-Source: AMrXdXvQQSvCa8BnG75q30i9WnAeBo9ujEEIk22+GRPAUdB6TcxBkdGUEhIk/tO7bAJCLAmdJbltgw== X-Received: by 2002:a05:6a20:d90f:b0:ad:db18:e94 with SMTP id jd15-20020a056a20d90f00b000addb180e94mr26369185pzb.49.1671855604329; Fri, 23 Dec 2022 20:20:04 -0800 (PST) Received: from localhost.localdomain ([204.13.164.84]) by smtp.gmail.com with ESMTPSA id x19-20020aa79413000000b005743b5ebd7csm3324185pfo.92.2022.12.23.20.20.02 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 23 Dec 2022 20:20:03 -0800 (PST) From: Glenn Washburn To: grub-devel@gnu.org, Daniel Kiper Cc: Robbie Harwood , Peter Jones , Glenn Washburn Subject: [PATCH v5 03/14] gdb: If no modules have been loaded, do not try to load module symbols Date: Fri, 23 Dec 2022 22:19:24 -0600 Message-Id: <20221224041935.787292-4-development@efficientek.com> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20221224041935.787292-1-development@efficientek.com> References: <20221224041935.787292-1-development@efficientek.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2607:f8b0:4864:20::102a; envelope-from=development@efficientek.com; helo=mail-pj1-x102a.google.com X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 24 Dec 2022 04:20:08 -0000 This prevents load_all_modules from failing when called before any modules have been loaded. Failures in GDB user-defined functions cause any function which called them to also fail. Signed-off-by: Glenn Washburn --- grub-core/gdb_grub.in | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/grub-core/gdb_grub.in b/grub-core/gdb_grub.in index edb5a8872c..fc17e3d899 100644 --- a/grub-core/gdb_grub.in +++ b/grub-core/gdb_grub.in @@ -63,7 +63,9 @@ define load_all_modules dump_module_sections $this set $this = $this->next end - match_and_load_symbols + if (grub_dl_head != 0) + match_and_load_symbols + end end document load_all_modules Load debugging information for all loaded modules. -- 2.34.1