From: Gaosheng Cui <cuigaosheng1@huawei.com>
To: <mchehab@kernel.org>, <gregkh@linuxfoundation.org>,
<hverkuil-cisco@xs4all.nl>, <ribalda@chromium.org>,
<neil.armstrong@linaro.org>, <cuigaosheng1@huawei.com>,
<geert+renesas@glider.be>
Cc: <linux-media@vger.kernel.org>, <linux-staging@lists.linux.dev>
Subject: [PATCH -next] media: staging: stkwebcam: Fix the build error with stkwebcam
Date: Mon, 26 Dec 2022 17:48:20 +0800 [thread overview]
Message-ID: <20221226094820.1157244-1-cuigaosheng1@huawei.com> (raw)
When I am building the kernel on arm64, set config CONFIG_USB=m &&
CONFIG_VIDEO_STKWEBCAM=y, I get some error reports as follows:
drivers/staging/media/deprecated/stkwebcam/stk-webcam.o: In
function `stk_v4l_dev_release':
stk-webcam.c:(.text+0x3e0): undefined reference to `usb_put_intf'
stk-webcam.c:(.text+0x3e8): undefined reference to `usb_put_dev'
drivers/staging/media/deprecated/stkwebcam/stk-webcam.o: In
function `stk_clean_iso':
stk-webcam.c:(.text+0xb0c): undefined reference to `usb_kill_urb'
stk-webcam.c:(.text+0xb14): undefined reference to `usb_free_urb'
Fix it by add dependency option on USB for VIDEO_STKWEBCAM.
Signed-off-by: Gaosheng Cui <cuigaosheng1@huawei.com>
---
drivers/staging/media/deprecated/stkwebcam/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/media/deprecated/stkwebcam/Kconfig b/drivers/staging/media/deprecated/stkwebcam/Kconfig
index 7234498e634a..083fadab232d 100644
--- a/drivers/staging/media/deprecated/stkwebcam/Kconfig
+++ b/drivers/staging/media/deprecated/stkwebcam/Kconfig
@@ -2,7 +2,7 @@
config VIDEO_STKWEBCAM
tristate "USB Syntek DC1125 Camera support (DEPRECATED)"
depends on VIDEO_DEV
- depends on MEDIA_USB_SUPPORT && MEDIA_CAMERA_SUPPORT
+ depends on USB && MEDIA_USB_SUPPORT && MEDIA_CAMERA_SUPPORT
help
Say Y here if you want to use this type of camera.
Supported devices are typically found in some Asus laptops,
--
2.25.1
next reply other threads:[~2022-12-26 10:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-26 9:48 Gaosheng Cui [this message]
2023-01-17 20:32 ` [PATCH -next] media: staging: stkwebcam: Fix the build error with stkwebcam Geert Uytterhoeven
2023-01-23 12:37 ` Hans Verkuil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221226094820.1157244-1-cuigaosheng1@huawei.com \
--to=cuigaosheng1@huawei.com \
--cc=geert+renesas@glider.be \
--cc=gregkh@linuxfoundation.org \
--cc=hverkuil-cisco@xs4all.nl \
--cc=linux-media@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mchehab@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=ribalda@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.