From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 326B7C3DA79 for ; Mon, 26 Dec 2022 22:36:07 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232453AbiLZWgG (ORCPT ); Mon, 26 Dec 2022 17:36:06 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:40218 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232416AbiLZWfw (ORCPT ); Mon, 26 Dec 2022 17:35:52 -0500 Received: from mail-oi1-f174.google.com (mail-oi1-f174.google.com [209.85.167.174]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1DAE8190; Mon, 26 Dec 2022 14:35:50 -0800 (PST) Received: by mail-oi1-f174.google.com with SMTP id i127so11155265oif.8; Mon, 26 Dec 2022 14:35:50 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=6w8kKcVpFv9sHFhyQKUNJ7xPpp7eSjH01obq6G78esM=; b=ovl62jHwSV69gPEJpLE/RUiQIMEhivNAVzxA4dgRpDdMUo1r1SrlY2sKRQAG9LP9d+ 1FSRVHjdyhdozRNZqKDukaCA1Q4N2G2F3xnAEuwxOpt0dTr7pwIDf4NEXHQnecNEdtvg AeEXhyEp88QlXjachZaCRnvi6HJqPdjHimxt8OaA3rT0GDdpQ/VlahPYrDpn4I3Hc1C6 F6Ay2GZevX0hleQ902x8ukpmlouQAl0TVDXzpUDr05lkLMnwWXWLNwZlFD/a6IbzQVmI 4TRATkZAJC+BsFjZjr0osHehGp7Aa6+JuAfOTrKMcuZkOhxBHx63IUYtsneVIhjfzE+1 7Egw== X-Gm-Message-State: AFqh2kpAoRGTIm8A/lYWMRODDik3uk5v+TF3XVt8nqcTZpgwvO//AWu+ wqMkzmrUVHGfqYjeU7MGdA== X-Google-Smtp-Source: AMrXdXvRtMoTBhVKR/CZ79z8z3Ws/NNsoYkejNK7cfwQZWHLQkthvL9GABaHe9DhiXLxVAhJmtYeQA== X-Received: by 2002:a05:6808:bcb:b0:355:1de9:390a with SMTP id o11-20020a0568080bcb00b003551de9390amr13711772oik.16.1672094150620; Mon, 26 Dec 2022 14:35:50 -0800 (PST) Received: from robh_at_kernel.org ([2605:ef80:80e8:2792:eb0e:539f:f657:547b]) by smtp.gmail.com with ESMTPSA id z10-20020a9d62ca000000b00660e833baddsm5879928otk.29.2022.12.26.14.35.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Dec 2022 14:35:50 -0800 (PST) Received: (nullmailer pid 70056 invoked by uid 1000); Mon, 26 Dec 2022 21:55:50 -0000 Date: Mon, 26 Dec 2022 15:55:50 -0600 From: Rob Herring To: Jacky Bai Cc: lee@kernel.org, krzysztof.kozlowski+dt@linaro.org, shawnguo@kernel.org, s.hauer@pengutronix.de, dmitry.torokhov@gmail.com, a.zummo@towertech.it, alexandre.belloni@bootlin.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-input@vger.kernel.org, linux-rtc@vger.kernel.org, kernel@pengutronix.de, linux-imx@nxp.com, festevam@gmail.com Subject: Re: [PATCH v2 1/4] dt-bindings: mfd: Add nxp bbnsm Message-ID: <20221226215550.GA67355-robh@kernel.org> References: <20221226023942.1027270-1-ping.bai@nxp.com> <20221226023942.1027270-2-ping.bai@nxp.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20221226023942.1027270-2-ping.bai@nxp.com> Precedence: bulk List-ID: X-Mailing-List: linux-rtc@vger.kernel.org On Mon, Dec 26, 2022 at 10:39:39AM +0800, Jacky Bai wrote: > Add binding for NXP BBNSM(Battery-Backed Non-Secure Module). > > Signed-off-by: Jacky Bai > --- > - v2 changes: > - remove the redundant 'bindings' string > - add ref to rtc.yaml > - add start-year property > - rename 'regmap' to 'nxp,bbnsm-regmap' and add description & type define > - add header files including in the example and correct the indentation > --- > .../devicetree/bindings/mfd/nxp,bbnsm.yaml | 113 ++++++++++++++++++ > 1 file changed, 113 insertions(+) > create mode 100644 Documentation/devicetree/bindings/mfd/nxp,bbnsm.yaml > > diff --git a/Documentation/devicetree/bindings/mfd/nxp,bbnsm.yaml b/Documentation/devicetree/bindings/mfd/nxp,bbnsm.yaml > new file mode 100644 > index 000000000000..8d213bce9119 > --- /dev/null > +++ b/Documentation/devicetree/bindings/mfd/nxp,bbnsm.yaml > @@ -0,0 +1,113 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/mfd/nxp,bbnsm.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: NXP Battery-Backed Non-Secure Module > + > +maintainers: > + - Jacky Bai > + > +description: | > + NXP BBNSM serves as non-volatile logic and storage for the system. > + it Intergrates RTC & ON/OFF control. > + The RTC can retain its state and continues counting even when the > + main chip is power down. A time alarm is generated once the most > + significant 32 bits of the real-time counter match the value in the > + Time Alarm register. > + The ON/OFF logic inside the BBNSM allows for connecting directly to > + a PMIC or other voltage regulator device. both smart PMIC mode and > + Dumb PMIC mode supported. > + > +properties: > + compatible: > + items: > + - enum: > + - nxp,bbnsm > + - const: syscon > + - const: simple-mfd > + > + reg: > + maxItems: 1 > + > + rtc: > + type: object > + $ref: /schemas/rtc/rtc.yaml# > + > + properties: > + compatible: > + const: nxp,bbnsm-rtc > + > + nxp,bbnsm-regmap: > + $ref: /schemas/types.yaml#/definitions/phandle > + description: > + phandle of the bbnsm node You don't need this now, it's the parent node. > + > + interrupts: > + maxItems: 1 > + > + start-year: true > + > + required: > + - compatible > + - nxp,bbnsm-regmap > + - interrupts > + > + additionalProperties: false > + > + pwrkey: > + type: object > + $ref: /schemas/input/input.yaml# > + > + properties: > + compatible: > + const: nxp,bbnsm-pwrkey > + > + nxp,bbnsm-regmap: > + $ref: /schemas/types.yaml#/definitions/phandle > + description: > + phandle of the bbnsm node Same here. > + > + interrupts: > + maxItems: 1 > + > + linux,code: true > + > + required: > + - compatible > + - nxp,bbnsm-regmap > + - interrupts > + > + additionalProperties: false > + > +required: > + - compatible > + - reg > + - rtc > + - pwrkey > + > +additionalProperties: false > + > +examples: > + - | > + #include > + #include > + > + bbnsm: bbnsm@44440000 { > + compatible = "nxp,bbnsm", "syscon", "simple-mfd"; > + reg = <0x44440000 0x10000>; > + > + bbnsm_rtc: rtc { > + compatible = "nxp,bbnsm-rtc"; > + nxp,bbnsm-regmap = <&bbnsm>; > + interrupts = ; > + }; > + > + bbnsm_pwrkey: pwrkey { > + compatible = "nxp,bbnsm-pwrkey"; > + nxp,bbnsm-regmap = <&bbnsm>; > + interrupts = ; > + linux,code = ; > + }; > + }; > -- > 2.37.1 > > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0E187C3DA79 for ; Mon, 26 Dec 2022 22:37:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=FPGJiaPzAwfwb8A9Tz7NN8Q2DdC0hgD9x1dae5hg38g=; b=thxWG65YY3/U/c Et2y+pajTxJa04D1skvMRP3ekU11oi0VWfT4ys1Ux8brNUGfHBlDMBtx6oQzcMxq2nW5AChLZy6TK u1wDZkJc5Or6TbNP9Kpqe0e5EuijMoO3mqmkpLoyYFnNoqKowL88E6/bkoC/Tc4K+xa5qE2c6lRPP gvif9sE/5CLK7QVTncIDTM3Wwzy3623/OJKHF1iVVLRa0tDXER4pao3wLA1aQiEaWrThhrwdKzRVo i+oKN+NBQevLp63+WoSZpi/+0AzzC2yU6dacPrOSP6R8VI7vua2uR9osbayI9b9DdCdjuWmEi6Jgc CmzsAbFvv+dIcfS2lHKw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1p9w4q-007vhb-Mj; Mon, 26 Dec 2022 22:36:12 +0000 Received: from mail-oi1-f174.google.com ([209.85.167.174]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1p9w4V-007vbP-T6 for linux-arm-kernel@lists.infradead.org; Mon, 26 Dec 2022 22:36:04 +0000 Received: by mail-oi1-f174.google.com with SMTP id r11so11122505oie.13 for ; Mon, 26 Dec 2022 14:35:51 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=6w8kKcVpFv9sHFhyQKUNJ7xPpp7eSjH01obq6G78esM=; b=BegcmaXTjFLpQib7mkasAP/Nt96pzP11JvmwuzfaF8kTbSMW75z32+RS4AD0vy5+lS LW4cTHZjGxhgosnXAKmIANlu3Hdwdd/KOJc5VO9QkWP0XLWrJuPtL/b+fjucTLUS82Dd wv0qSaZ5Mc6qy8hGQmGqEAjD7n2VaZSpqJRV8R8WYz+vwhkDakQGGcHDgCku+qoKWdCr Az6OMMaobAZ+JakfQ4Q9RKVSCg/ZGabF/oCXl0nfyOEVElDTozYxQPWqmbU1SxEqjqxS Rhy0JYPwQCKFLaTkbmWZbTT6w3/N+ZJ2l0Zjzwy/BCz/FHks62JCj+WKLeHlSMwWzo0O rGpQ== X-Gm-Message-State: AFqh2kpafbhVFZO2ZpQ7t9ASQ4CLgaPy+MynAiV7yuqqW1CrE93HiDdN HGlUeY3B7oNp3ggmxtINm0NCbzbrAg== X-Google-Smtp-Source: AMrXdXvRtMoTBhVKR/CZ79z8z3Ws/NNsoYkejNK7cfwQZWHLQkthvL9GABaHe9DhiXLxVAhJmtYeQA== X-Received: by 2002:a05:6808:bcb:b0:355:1de9:390a with SMTP id o11-20020a0568080bcb00b003551de9390amr13711772oik.16.1672094150620; Mon, 26 Dec 2022 14:35:50 -0800 (PST) Received: from robh_at_kernel.org ([2605:ef80:80e8:2792:eb0e:539f:f657:547b]) by smtp.gmail.com with ESMTPSA id z10-20020a9d62ca000000b00660e833baddsm5879928otk.29.2022.12.26.14.35.47 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Dec 2022 14:35:50 -0800 (PST) Received: (nullmailer pid 70056 invoked by uid 1000); Mon, 26 Dec 2022 21:55:50 -0000 Date: Mon, 26 Dec 2022 15:55:50 -0600 From: Rob Herring To: Jacky Bai Cc: lee@kernel.org, krzysztof.kozlowski+dt@linaro.org, shawnguo@kernel.org, s.hauer@pengutronix.de, dmitry.torokhov@gmail.com, a.zummo@towertech.it, alexandre.belloni@bootlin.com, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-input@vger.kernel.org, linux-rtc@vger.kernel.org, kernel@pengutronix.de, linux-imx@nxp.com, festevam@gmail.com Subject: Re: [PATCH v2 1/4] dt-bindings: mfd: Add nxp bbnsm Message-ID: <20221226215550.GA67355-robh@kernel.org> References: <20221226023942.1027270-1-ping.bai@nxp.com> <20221226023942.1027270-2-ping.bai@nxp.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20221226023942.1027270-2-ping.bai@nxp.com> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221226_143552_127233_0BA7046B X-CRM114-Status: GOOD ( 23.04 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, Dec 26, 2022 at 10:39:39AM +0800, Jacky Bai wrote: > Add binding for NXP BBNSM(Battery-Backed Non-Secure Module). > > Signed-off-by: Jacky Bai > --- > - v2 changes: > - remove the redundant 'bindings' string > - add ref to rtc.yaml > - add start-year property > - rename 'regmap' to 'nxp,bbnsm-regmap' and add description & type define > - add header files including in the example and correct the indentation > --- > .../devicetree/bindings/mfd/nxp,bbnsm.yaml | 113 ++++++++++++++++++ > 1 file changed, 113 insertions(+) > create mode 100644 Documentation/devicetree/bindings/mfd/nxp,bbnsm.yaml > > diff --git a/Documentation/devicetree/bindings/mfd/nxp,bbnsm.yaml b/Documentation/devicetree/bindings/mfd/nxp,bbnsm.yaml > new file mode 100644 > index 000000000000..8d213bce9119 > --- /dev/null > +++ b/Documentation/devicetree/bindings/mfd/nxp,bbnsm.yaml > @@ -0,0 +1,113 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/mfd/nxp,bbnsm.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: NXP Battery-Backed Non-Secure Module > + > +maintainers: > + - Jacky Bai > + > +description: | > + NXP BBNSM serves as non-volatile logic and storage for the system. > + it Intergrates RTC & ON/OFF control. > + The RTC can retain its state and continues counting even when the > + main chip is power down. A time alarm is generated once the most > + significant 32 bits of the real-time counter match the value in the > + Time Alarm register. > + The ON/OFF logic inside the BBNSM allows for connecting directly to > + a PMIC or other voltage regulator device. both smart PMIC mode and > + Dumb PMIC mode supported. > + > +properties: > + compatible: > + items: > + - enum: > + - nxp,bbnsm > + - const: syscon > + - const: simple-mfd > + > + reg: > + maxItems: 1 > + > + rtc: > + type: object > + $ref: /schemas/rtc/rtc.yaml# > + > + properties: > + compatible: > + const: nxp,bbnsm-rtc > + > + nxp,bbnsm-regmap: > + $ref: /schemas/types.yaml#/definitions/phandle > + description: > + phandle of the bbnsm node You don't need this now, it's the parent node. > + > + interrupts: > + maxItems: 1 > + > + start-year: true > + > + required: > + - compatible > + - nxp,bbnsm-regmap > + - interrupts > + > + additionalProperties: false > + > + pwrkey: > + type: object > + $ref: /schemas/input/input.yaml# > + > + properties: > + compatible: > + const: nxp,bbnsm-pwrkey > + > + nxp,bbnsm-regmap: > + $ref: /schemas/types.yaml#/definitions/phandle > + description: > + phandle of the bbnsm node Same here. > + > + interrupts: > + maxItems: 1 > + > + linux,code: true > + > + required: > + - compatible > + - nxp,bbnsm-regmap > + - interrupts > + > + additionalProperties: false > + > +required: > + - compatible > + - reg > + - rtc > + - pwrkey > + > +additionalProperties: false > + > +examples: > + - | > + #include > + #include > + > + bbnsm: bbnsm@44440000 { > + compatible = "nxp,bbnsm", "syscon", "simple-mfd"; > + reg = <0x44440000 0x10000>; > + > + bbnsm_rtc: rtc { > + compatible = "nxp,bbnsm-rtc"; > + nxp,bbnsm-regmap = <&bbnsm>; > + interrupts = ; > + }; > + > + bbnsm_pwrkey: pwrkey { > + compatible = "nxp,bbnsm-pwrkey"; > + nxp,bbnsm-regmap = <&bbnsm>; > + interrupts = ; > + linux,code = ; > + }; > + }; > -- > 2.37.1 > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel