From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0BDF41863 for ; Wed, 28 Dec 2022 15:39:48 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 85C06C433D2; Wed, 28 Dec 2022 15:39:47 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1672241987; bh=+2dJZuyYiHi5jVntV7hCl5NkvZc/l+kFFIZ04IK9BBs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=AaDf2QmVGDRKm6lkk1pHltXMgRXW/75yEwO8Xx9+7wyNtTDCmp62XwPAI9mCSDRmn Plt1YE6gKoGfOVpT6/XyJeRWAYmRb118vXfm/WCA/+MDMbmJvyErE9Y8pAxOrzRzxL ZUs8fBCtOoKkuLIwjEZGn8hzOB9iaQgZemu1vj6E= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Yuan Can , Joerg Roedel , Sasha Levin Subject: [PATCH 5.15 550/731] iommu/fsl_pamu: Fix resource leak in fsl_pamu_probe() Date: Wed, 28 Dec 2022 15:40:57 +0100 Message-Id: <20221228144312.483452430@linuxfoundation.org> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20221228144256.536395940@linuxfoundation.org> References: <20221228144256.536395940@linuxfoundation.org> User-Agent: quilt/0.67 Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit From: Yuan Can [ Upstream commit 73f5fc5f884ad0c5f7d57f66303af64f9f002526 ] The fsl_pamu_probe() returns directly when create_csd() failed, leaving irq and memories unreleased. Fix by jumping to error if create_csd() returns error. Fixes: 695093e38c3e ("iommu/fsl: Freescale PAMU driver and iommu implementation.") Signed-off-by: Yuan Can Link: https://lore.kernel.org/r/20221121082022.19091-1-yuancan@huawei.com Signed-off-by: Joerg Roedel Signed-off-by: Sasha Levin --- drivers/iommu/fsl_pamu.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/iommu/fsl_pamu.c b/drivers/iommu/fsl_pamu.c index fc38b1fba7cf..bb5d253188a1 100644 --- a/drivers/iommu/fsl_pamu.c +++ b/drivers/iommu/fsl_pamu.c @@ -865,7 +865,7 @@ static int fsl_pamu_probe(struct platform_device *pdev) ret = create_csd(ppaact_phys, mem_size, csd_port_id); if (ret) { dev_err(dev, "could not create coherence subdomain\n"); - return ret; + goto error; } } -- 2.35.1