From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B8B991C07 for ; Wed, 28 Dec 2022 16:13:36 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2260DC433EF; Wed, 28 Dec 2022 16:13:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1672244016; bh=wRClq7SGljjCXZoLOyDzzzCHYBZoHBsHr568OPeKIwQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=R93JVyHzL1cvLWZxHindu7r7wEkDj9SCw15r4kXbP29BnEfM/aN5nrWG0o2EEmaPU UX76LHDIfijQZEmLuRZMOBYGwINUlOkScqmLglLQAE0x+HjXpRxZ1zHOWzXyUaw7fE A0SgnG7PORgCkFQ6colUMYF8HqsqokSX0oilNvHU= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Yuan Can , Leon Romanovsky , Sasha Levin Subject: [PATCH 6.0 0632/1073] RDMA/nldev: Add checks for nla_nest_start() in fill_stat_counter_qps() Date: Wed, 28 Dec 2022 15:37:00 +0100 Message-Id: <20221228144345.207774577@linuxfoundation.org> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20221228144328.162723588@linuxfoundation.org> References: <20221228144328.162723588@linuxfoundation.org> User-Agent: quilt/0.67 Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit From: Yuan Can [ Upstream commit ea5ef136e215fdef35f14010bc51fcd6686e6922 ] As the nla_nest_start() may fail with NULL returned, the return value needs to be checked. Fixes: c4ffee7c9bdb ("RDMA/netlink: Implement counter dumpit calback") Signed-off-by: Yuan Can Link: https://lore.kernel.org/r/20221126043410.85632-1-yuancan@huawei.com Signed-off-by: Leon Romanovsky Signed-off-by: Sasha Levin --- drivers/infiniband/core/nldev.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/infiniband/core/nldev.c b/drivers/infiniband/core/nldev.c index f1e0755cd56e..54d4e693e03b 100644 --- a/drivers/infiniband/core/nldev.c +++ b/drivers/infiniband/core/nldev.c @@ -894,6 +894,8 @@ static int fill_stat_counter_qps(struct sk_buff *msg, int ret = 0; table_attr = nla_nest_start(msg, RDMA_NLDEV_ATTR_RES_QP); + if (!table_attr) + return -EMSGSIZE; rt = &counter->device->res[RDMA_RESTRACK_QP]; xa_lock(&rt->xa); -- 2.35.1