From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B81501C07 for ; Wed, 28 Dec 2022 16:22:43 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3E22BC433EF; Wed, 28 Dec 2022 16:22:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1672244563; bh=MtJxME0daBU8mxhlgoTcfsB+TZFPAlcvqI2POhUuFIA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=I1ycGRBcV4xzHK1ZZSQwxb0CxtoJMTp00mUDfltTOpQk6NhMpId+uBJT00NlUcwy2 gi9ORv5oSc9FPwlVEzvUkEYqATRAiRFlvhasyHrJFAxT3BkzvEECtnjwdGvUwmvZae Y/Vek+axAXaLYQp0QMLiuK6PoE13I4bkD2JELNFA= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Gaosheng Cui , Helge Deller , Sasha Levin Subject: [PATCH 6.0 0733/1073] fbdev: ep93xx-fb: Add missing clk_disable_unprepare in ep93xxfb_probe() Date: Wed, 28 Dec 2022 15:38:41 +0100 Message-Id: <20221228144347.932449040@linuxfoundation.org> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20221228144328.162723588@linuxfoundation.org> References: <20221228144328.162723588@linuxfoundation.org> User-Agent: quilt/0.67 Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit From: Gaosheng Cui [ Upstream commit c84bf485a5aaf9aa0764a58832b7ef4375c29f03 ] The clk_disable_unprepare() should be called in the error handling of register_framebuffer(), fix it. Fixes: 0937a7b3625d ("video: ep93xx: Prepare clock before using it") Signed-off-by: Gaosheng Cui Signed-off-by: Helge Deller Signed-off-by: Sasha Levin --- drivers/video/fbdev/ep93xx-fb.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/video/fbdev/ep93xx-fb.c b/drivers/video/fbdev/ep93xx-fb.c index 2398b3d48fed..305f1587bd89 100644 --- a/drivers/video/fbdev/ep93xx-fb.c +++ b/drivers/video/fbdev/ep93xx-fb.c @@ -552,12 +552,14 @@ static int ep93xxfb_probe(struct platform_device *pdev) err = register_framebuffer(info); if (err) - goto failed_check; + goto failed_framebuffer; dev_info(info->dev, "registered. Mode = %dx%d-%d\n", info->var.xres, info->var.yres, info->var.bits_per_pixel); return 0; +failed_framebuffer: + clk_disable_unprepare(fbi->clk); failed_check: if (fbi->mach_info->teardown) fbi->mach_info->teardown(pdev); -- 2.35.1