From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1379C1C08 for ; Wed, 28 Dec 2022 16:37:18 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6779DC433D2; Wed, 28 Dec 2022 16:37:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1672245438; bh=scuxibib/wgWJbiVOJ780gC72KxWU3lhTW97mM5HxNo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=hvhtObpWLwE7bximbuthgNFVGIVUCS7+ZcEGSmXAIFpiWVXTHBn2fe9tgSEMogoFo 0fbikTD2M4MyQg5MAQ5gZRmleRQlq2tIUyKht+9kExuXKgv3VpGY8pKQjwK6d1mq3+ UMSzJgmDQ7wUK7/S9dRAmsU0ENAQQ45wmAXc7dd8= From: Greg Kroah-Hartman To: stable@vger.kernel.org Cc: Greg Kroah-Hartman , patches@lists.linux.dev, Li Zhong , "Rafael J. Wysocki" , Sasha Levin Subject: [PATCH 6.0 0896/1073] ACPI: processor: idle: Check acpi_fetch_acpi_dev() return value Date: Wed, 28 Dec 2022 15:41:24 +0100 Message-Id: <20221228144352.366979745@linuxfoundation.org> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20221228144328.162723588@linuxfoundation.org> References: <20221228144328.162723588@linuxfoundation.org> User-Agent: quilt/0.67 Precedence: bulk X-Mailing-List: patches@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit From: Li Zhong [ Upstream commit 2437513a814b3e93bd02879740a8a06e52e2cf7d ] The return value of acpi_fetch_acpi_dev() could be NULL, which would cause a NULL pointer dereference to occur in acpi_device_hid(). Signed-off-by: Li Zhong [ rjw: Subject and changelog edits, added empty line after if () ] Signed-off-by: Rafael J. Wysocki Signed-off-by: Sasha Levin --- drivers/acpi/processor_idle.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/acpi/processor_idle.c b/drivers/acpi/processor_idle.c index 9f40917c49ef..4d1dd255c122 100644 --- a/drivers/acpi/processor_idle.c +++ b/drivers/acpi/processor_idle.c @@ -1134,6 +1134,9 @@ static int acpi_processor_get_lpi_info(struct acpi_processor *pr) status = acpi_get_parent(handle, &pr_ahandle); while (ACPI_SUCCESS(status)) { d = acpi_fetch_acpi_dev(pr_ahandle); + if (!d) + break; + handle = pr_ahandle; if (strcmp(acpi_device_hid(d), ACPI_PROCESSOR_CONTAINER_HID)) -- 2.35.1