Re: [PATCH] block: default BLOCK_LEGACY_AUTOLOAD to y

From: Anisse Astier <anisse@astier.eu>
To: mcgrof@kernel.org
Cc: axboe@kernel.dk, hare@suse.de, hch@lst.de, jeffm@suse.com,
	kzak@redhat.com, linux-block@vger.kernel.org,
	ming.lei@redhat.com, snitzer@redhat.com
Subject: Re: [PATCH] block: default BLOCK_LEGACY_AUTOLOAD to y
Date: Wed, 28 Dec 2022 17:55:47 +0100	[thread overview]
Message-ID: <20221228165547.27502-1-anisse@astier.eu> (raw)
In-Reply-To: <YhlI4bKqYpknNgBa@bombadil.infradead.org>

Hi,

On Fri, 25 Feb 2022 13:23:45 -0800, Luis Chamberlain wrote:
> On Fri, Feb 25, 2022 at 07:14:40PM +0100, Christoph Hellwig wrote:
> > As Luis reported, losetup currently doesn't properly create the loop
> > device without this if the device node already exists because old
> > scripts created it manually.  So default to y for now and remove the
> > aggressive removal schedule.
> > 
> > Reported-by: Luis Chamberlain <mcgrof@kernel.org>
> > Signed-off-by: Christoph Hellwig <hch@lst.de>
> 
> I'm saddened by the fact that we're not going to get an idea of how far
> and wide the stupid mknod prior to modprobe use is by making this
> as y default even though I know this is the right thing to do.
> 
> I think our ownly measure of success here is to really push
> Linux distributions to start disabling BLOCK_LEGACY_AUTOLOAD
> and getting their help to see what burts into flames.

I just spent some time bisecting another thing that regresses without
BLOCK_LEGACY_AUTOLOAD (which was disabled here): mdadm software raid
auto-assemble on boot (with udev).

I think it's because it tries to open /dev/md127 and then fails since it's not
created automatically.

Regards,

Anisse