From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C9706C4332F for ; Thu, 29 Dec 2022 00:11:45 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 0637785461; Thu, 29 Dec 2022 01:11:43 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="pXgjmgl3"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 429AF8545E; Thu, 29 Dec 2022 01:11:41 +0100 (CET) Received: from mail-qt1-x832.google.com (mail-qt1-x832.google.com [IPv6:2607:f8b0:4864:20::832]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id E831A85465 for ; Thu, 29 Dec 2022 01:11:38 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-qt1-x832.google.com with SMTP id s9so13917774qtx.6 for ; Wed, 28 Dec 2022 16:11:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=PiSCj/Lk1v2OO+1WFdu5tfmCiLhINIQsNsJITvVSENk=; b=pXgjmgl3U55x59SyylFtFH1J1ju2a8z9Q2AHtiqbhX85IqkU41z7lajQ9TZZ0RCEhZ VZXus+iBkX9Kk0Kv5a/Kf7Um6xH27BqDVD8QDc1E/1zrnXLqMwv2kp3EQlkquIX8oUnT 7qVEz9bxu8SvG+BVqEs4r+qXg5Npv+cZ426Yk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=PiSCj/Lk1v2OO+1WFdu5tfmCiLhINIQsNsJITvVSENk=; b=qMEfwz859uZ7xScqioGvYnglufzz/elM6EQo4McRiFbtd5IT7aVa0VnMBExM+vjRZZ hxuy4uhW5cP3Mv7J9clQrPwPnMzCCRhyYQw89gbxF2rjiCYqZP2nSoQdELS9bHwvGxm3 lnucvvq9yCZqpRFD37wmJWnaPntz73sMq6l4a3Y4sQ+nOfgqPzuxKT0Zh+X0wKXKg3IS kyocrmxqAIbRd9Tl6K0bvCiKprLVrcPT22vJhvIFlBYzCyeHt3t1Cb8fa4IWywpi4O5n bewoH+GXcKcsmcC5oNDAfUOiraCquJz9bHoV4n1NTZvTEZ4CTwISavGptFWMpDTGiQB1 iLtA== X-Gm-Message-State: AFqh2kpyMWBRAJpWQRemQtekF65foTMfPffuMk0JjLUuZR+AQ72JCQrz toHfLZfZAhDNPQvMyKOHpnndeQ== X-Google-Smtp-Source: AMrXdXuYyaBO5p85eig4D8fFstTO1Zkx8upMKrDEr8HStM0dMrV+gNlfmgcFTCkSqc/2YkGLMzNB6g== X-Received: by 2002:a05:622a:4116:b0:3a8:133a:9686 with SMTP id cc22-20020a05622a411600b003a8133a9686mr40113959qtb.12.1672272697298; Wed, 28 Dec 2022 16:11:37 -0800 (PST) Received: from bill-the-cat (2603-6081-7b00-6400-8816-6dad-deb3-15d8.res6.spectrum.com. [2603:6081:7b00:6400:8816:6dad:deb3:15d8]) by smtp.gmail.com with ESMTPSA id w26-20020a05620a095a00b006fc6529abaesm11985405qkw.101.2022.12.28.16.11.36 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 28 Dec 2022 16:11:36 -0800 (PST) Date: Wed, 28 Dec 2022 19:11:34 -0500 From: Tom Rini To: Pali =?iso-8859-1?Q?Roh=E1r?= Cc: Heiko Schocher , u-boot@lists.denx.de Subject: Re: [PATCH u-boot] powerpc/mpc85xx: socrates: Re-enable building u-boot-socrates.bin Message-ID: <20221229001134.GQ3787616@bill-the-cat> References: <20221228181839.22003-1-pali@kernel.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="VmYCn4Ji9K7xw/PH" Content-Disposition: inline In-Reply-To: <20221228181839.22003-1-pali@kernel.org> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean --VmYCn4Ji9K7xw/PH Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Dec 28, 2022 at 07:18:39PM +0100, Pali Roh=E1r wrote: > U-Boot build system builds final U-Boot binary for socrates board in cust= om > file u-boot-socrates.bin (instead of standard u-boot.bin). Output target > file u-boot-socrates.bin is generated by binman as defined in board binman > config file arch/powerpc/dts/socrates-u-boot.dtsi. >=20 > But binman was disabled in commit 5af42eafd7e1 ("Makefile: Reduce usage of > custom mpc85xx u-boot.bin target") for all mpc85xx boards which do not use > standard powerpc binman config file arch/powerpc/dts/u-boot.dtsi and boar= ds > which do not require binman at all. >=20 > The only such mpc85xx board is socrates. So since that commit, U-Boot does > not final binary for socrates board anymore. >=20 > Fix this issue by re-enabling binman for socrates board. And build process > starts again producing u-boot-socrates.bin binary. >=20 > Note that build process for this socrates board always produce u-boot.bin > binary which is broken and not usable for socrates board. Long term > solution should be to disable building broken binary u-boot.bin and then > renaming u-boot-socrates.bin to u-boot.bin, or switching to use common > powerpc binman config file arch/powerpc/dts/socrates-u-boot.dtsi (if it is > possible). >=20 > Fixes: 5af42eafd7e1 ("Makefile: Reduce usage of custom mpc85xx u-boot.bin= target") > Signed-off-by: Pali Roh=E1r > --- > Heiko Schocher: Could you test if u-boot is still working on this board? >=20 > Tom Rini: Cannot be this issue handled by CI? For example that CI check > build process produce required output binaries? So, in so far as CI can check for something like this, it does when we enable it (akin to the build time size checks). I think in this case, some settings for CONFIG_BUILD_TARGET would help. --=20 Tom --VmYCn4Ji9K7xw/PH Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmOs2zMACgkQFHw5/5Y0 tyxFFQv/dZW3hrSFpaIf4nOfRcVaY/NlB7ZmK6QTGugX4zx3Nt8j90+n0m+lJlPi iDWaFdJm+X++HdbpEwfHmmpWHMrF4L/BaQ4RokCQG7DsfpJhcOMm9Z9NsC0yKZid 0ZB33uvekV275bHpZZ5NQLMFjA2kxkSQkgEtqPZ8xN05IrgIBR3T2QvQ02kgW9zR QXo2IdIgRD4Jm14xaHDTSJPoTD3PRVahfgmfIu8mNfCck+6l/dASw0SRvzAlatfX 3J+F+xzdQobPBIf228fDmAEpvEHrqHrLqbIN1/BvDC6Sa7k3L3CxRj2koAznFFjC eaYFqUJoGX0FU9EKmz68ZK1x/mM9/GxFsMuWyXfvXYo2ok5F6hfZ1TsVZBCGJoxJ Z+ZZEGmfMCwBfLjup1h+qlrbgF8mwlt4D39ZNjfN219yPEESklF8stlPMGPgGgBP X2Slc+PYF/w7Rljxkr1aAZFrQ8b6x34Bz4/k1zFzDqvVcNhkAEOjF1R20MFrGBwW W14JDEna =Gr6l -----END PGP SIGNATURE----- --VmYCn4Ji9K7xw/PH--