From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7969DC4332F for ; Thu, 29 Dec 2022 08:21:23 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233159AbiL2IVL (ORCPT ); Thu, 29 Dec 2022 03:21:11 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43020 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232731AbiL2IVJ (ORCPT ); Thu, 29 Dec 2022 03:21:09 -0500 Received: from mailgw02.mediatek.com (unknown [210.61.82.184]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 3FC1CC28; Thu, 29 Dec 2022 00:21:06 -0800 (PST) X-UUID: 88ca326cd7674b848a6254c0d0564ccf-20221229 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Type:MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:CC:To:From; bh=HORV9bMIP2LGFNhuhm7UuJjpXIYYSO+nEqUSjtucA64=; b=ZqQORkXKc0FXCVkrXWlcGmciE2mqA3pl3o8oVeVjFL79KQvZtLwheEdRXYCvqB019ANXgSU+d+iNNrzEVvG9dB/JK16L1Qi5KzDJCdGTxd8mhI3+kzHke7OX6a5Qg0Rx2c2t/i7G7ZshW/fJIGPQhDdwJFBvB5lXEyh8mloPOo4=; X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.14,REQID:9564ab36-ded9-4df7-8f0b-db2fbc4aa091,IP:0,U RL:0,TC:0,Content:0,EDM:0,RT:0,SF:45,FILE:0,BULK:0,RULE:Release_Ham,ACTION :release,TS:45 X-CID-INFO: VERSION:1.1.14,REQID:9564ab36-ded9-4df7-8f0b-db2fbc4aa091,IP:0,URL :0,TC:0,Content:0,EDM:0,RT:0,SF:45,FILE:0,BULK:0,RULE:Release_Ham,ACTION:r elease,TS:45 X-CID-META: VersionHash:dcaaed0,CLOUDID:3db548f4-ff42-4fb0-b929-626456a83c14,B ulkID:221229162104179HRAPB,BulkQuantity:0,Recheck:0,SF:28|17|19|48|102,TC: nil,Content:0,EDM:-3,IP:nil,URL:0,File:nil,Bulk:nil,QS:nil,BEC:nil,COL:0 X-UUID: 88ca326cd7674b848a6254c0d0564ccf-20221229 Received: from mtkcas11.mediatek.inc [(172.21.101.40)] by mailgw02.mediatek.com (envelope-from ) (Generic MTA with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 311895922; Thu, 29 Dec 2022 16:21:04 +0800 Received: from mtkmbs13n1.mediatek.inc (172.21.101.193) by mtkmbs10n1.mediatek.inc (172.21.101.34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.792.15; Thu, 29 Dec 2022 16:21:03 +0800 Received: from mtksdccf07.mediatek.inc (172.21.84.99) by mtkmbs13n1.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.2.792.15 via Frontend Transport; Thu, 29 Dec 2022 16:21:03 +0800 From: Miles Chen To: CC: , , , , , , , , , , , , , , , , , , , , , , , , , , , Subject: Re: [PATCH v2 18/23] clk: mediatek: clk-mtk: Register MFG notifier in mtk_clk_simple_probe() Date: Thu, 29 Dec 2022 16:21:03 +0800 Message-ID: <20221229082103.21064-1-miles.chen@mediatek.com> X-Mailer: git-send-email 2.18.0 In-Reply-To: <20221223094259.87373-19-angelogioacchino.delregno@collabora.com> References: <20221223094259.87373-19-angelogioacchino.delregno@collabora.com> MIME-Version: 1.0 Content-Type: text/plain X-MTK: N Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >In preparation for commonizing topckgen probe on various MediaTek SoCs >clock drivers, add the ability to register the MFG MUX notifier in >mtk_clk_simple_probe() by passing a custom notifier register function >pointer, as this function will be slightly different across different >SoCs. > >Signed-off-by: AngeloGioacchino Del Regno >--- > drivers/clk/mediatek/clk-mtk.c | 8 ++++++++ > drivers/clk/mediatek/clk-mtk.h | 3 +++ > 2 files changed, 11 insertions(+) > >diff --git a/drivers/clk/mediatek/clk-mtk.c b/drivers/clk/mediatek/clk-mtk.c >index b0a6225cd7b2..df6281492fb6 100644 >--- a/drivers/clk/mediatek/clk-mtk.c >+++ b/drivers/clk/mediatek/clk-mtk.c >@@ -533,6 +533,14 @@ int mtk_clk_simple_probe(struct platform_device *pdev) > goto unregister_composites; > } > >+ if (mcd->clk_notifier_func) { >+ struct clk *mfg_mux = clk_data->hws[mcd->mfg_clk_idx]->clk; >+ >+ r = mcd->clk_notifier_func(&pdev->dev, mfg_mux); >+ if (r) >+ goto unregister_clks; >+ } Should we have a IS_ERR_OR_NULL() check for clk_data->hws[mcd->mfg_clk_idx]? thanks, Miles >+ > r = of_clk_add_hw_provider(node, of_clk_hw_onecell_get, clk_data); > if (r) From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 28595C4332F for ; Thu, 29 Dec 2022 08:23:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:CC:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=zOHIa4PAxbABQYtprHJG2H+0LXsK3RFe/4Y0ITduwtc=; b=bhlsplLd3OQAwt HnAYx2Z4PDEmylCF19VI+GEmzp90vh2eCY9V7g5kcNfLrOq+eb8H7dmwLQUvxBHXXCMRS6KtaBG9O Zvwt9n3mn9E+/T2CtctgFwYV3wntlWr7NT5Z9kdigDK4SDdcw+bDxmNXkX8B0lv8S3T0AmXc46QFD 3hHM98Bw5zQ311FErpoQ25jKul4zB3pI3SDEUs8oNqN/SWteN3y6RWOe5gNp2aUe5vpb5S9U9uC7S oco+pHb1csXZKgQL2vf5MoWYxNYQPyWQ1U/xCS4QCkpxeoR/IEAs3lEJHAqnyP+qb+PyFCkSvPVru ZOOM0iSd1KkkalAEw64A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pAoB0-00Dftz-Re; Thu, 29 Dec 2022 08:22:11 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pAoAz-00DfsY-5N; Thu, 29 Dec 2022 08:22:09 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Content-Type:MIME-Version:References: In-Reply-To:Message-ID:Date:Subject:CC:To:From:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=HORV9bMIP2LGFNhuhm7UuJjpXIYYSO+nEqUSjtucA64=; b=GcQ7DB2f2ARU0cWkWAsa+1anm+ jhcSC3FNX7BLREjbXMtBX/bNhGhnLRvQypsLEQ91perQEC/5CdtUHlik9+tn0vRQKB70oz1v8Duds ARaYvUPjtekxihNRIPmfghCT4jVK36Qelbx5Ifiws4Ag+fybIOJSk4n+c/WPHSXunIQ5k7S6CdBTl YN+bfldwCi9jzWa3Rhrb5lNmW5tE9wDTjtrNRkKWa2HVEeYHPcfAJNM6jjcqc+CmZgMD4yB/bRsXF vhc8H/x//2R6yR0wNOaDZho9JGFBqCpRJbv5tLCRKGQs/q7nnYD0iYKvNyaU/oxjVlj/Cc5hgBT97 eh3SH8aw==; Received: from mailgw02.mediatek.com ([216.200.240.185]) by desiato.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1pAoAq-00GL43-2n; Thu, 29 Dec 2022 08:22:04 +0000 X-UUID: cb3ae1033dad445a81f21e44eef1d8b6-20221229 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Type:MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:CC:To:From; bh=HORV9bMIP2LGFNhuhm7UuJjpXIYYSO+nEqUSjtucA64=; b=ZqQORkXKc0FXCVkrXWlcGmciE2mqA3pl3o8oVeVjFL79KQvZtLwheEdRXYCvqB019ANXgSU+d+iNNrzEVvG9dB/JK16L1Qi5KzDJCdGTxd8mhI3+kzHke7OX6a5Qg0Rx2c2t/i7G7ZshW/fJIGPQhDdwJFBvB5lXEyh8mloPOo4=; X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.14,REQID:4130a297-36a4-4fa0-bc41-47e032e9beaf,IP:0,U RL:0,TC:0,Content:0,EDM:0,RT:0,SF:0,FILE:0,BULK:0,RULE:Release_Ham,ACTION: release,TS:0 X-CID-META: VersionHash:dcaaed0,CLOUDID:4df6b98a-8530-4eff-9f77-222cf6e2895b,B ulkID:nil,BulkQuantity:0,Recheck:0,SF:102,TC:nil,Content:0,EDM:-3,IP:nil,U RL:0,File:nil,Bulk:nil,QS:nil,BEC:nil,COL:0 X-UUID: cb3ae1033dad445a81f21e44eef1d8b6-20221229 Received: from mtkmbs13n2.mediatek.inc [(172.21.101.108)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-GCM-SHA384 256/256) with ESMTP id 1865370965; Thu, 29 Dec 2022 01:21:40 -0700 Received: from mtkmbs13n1.mediatek.inc (172.21.101.193) by mtkmbs10n1.mediatek.inc (172.21.101.34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.792.15; Thu, 29 Dec 2022 16:21:03 +0800 Received: from mtksdccf07.mediatek.inc (172.21.84.99) by mtkmbs13n1.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.2.792.15 via Frontend Transport; Thu, 29 Dec 2022 16:21:03 +0800 From: Miles Chen To: CC: , , , , , , , , , , , , , , , , , , , , , , , , , , , Subject: Re: [PATCH v2 18/23] clk: mediatek: clk-mtk: Register MFG notifier in mtk_clk_simple_probe() Date: Thu, 29 Dec 2022 16:21:03 +0800 Message-ID: <20221229082103.21064-1-miles.chen@mediatek.com> X-Mailer: git-send-email 2.18.0 In-Reply-To: <20221223094259.87373-19-angelogioacchino.delregno@collabora.com> References: <20221223094259.87373-19-angelogioacchino.delregno@collabora.com> MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221229_082201_609371_F0E4B300 X-CRM114-Status: UNSURE ( 9.96 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org >In preparation for commonizing topckgen probe on various MediaTek SoCs >clock drivers, add the ability to register the MFG MUX notifier in >mtk_clk_simple_probe() by passing a custom notifier register function >pointer, as this function will be slightly different across different >SoCs. > >Signed-off-by: AngeloGioacchino Del Regno >--- > drivers/clk/mediatek/clk-mtk.c | 8 ++++++++ > drivers/clk/mediatek/clk-mtk.h | 3 +++ > 2 files changed, 11 insertions(+) > >diff --git a/drivers/clk/mediatek/clk-mtk.c b/drivers/clk/mediatek/clk-mtk.c >index b0a6225cd7b2..df6281492fb6 100644 >--- a/drivers/clk/mediatek/clk-mtk.c >+++ b/drivers/clk/mediatek/clk-mtk.c >@@ -533,6 +533,14 @@ int mtk_clk_simple_probe(struct platform_device *pdev) > goto unregister_composites; > } > >+ if (mcd->clk_notifier_func) { >+ struct clk *mfg_mux = clk_data->hws[mcd->mfg_clk_idx]->clk; >+ >+ r = mcd->clk_notifier_func(&pdev->dev, mfg_mux); >+ if (r) >+ goto unregister_clks; >+ } Should we have a IS_ERR_OR_NULL() check for clk_data->hws[mcd->mfg_clk_idx]? thanks, Miles >+ > r = of_clk_add_hw_provider(node, of_clk_hw_onecell_get, clk_data); > if (r) _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel