All of lore.kernel.org
 help / color / mirror / Atom feed
From: Christoph Hellwig <hch@lst.de>
To: Andrew Morton <akpm@linux-foundation.org>,
	"Theodore Ts'o" <tytso@mit.edu>, Jan Kara <jack@suse.com>,
	Konstantin Komarov <almaz.alexandrovich@paragon-software.com>,
	Mark Fasheh <mark@fasheh.com>, Joel Becker <jlbec@evilplan.org>,
	Joseph Qi <joseph.qi@linux.alibaba.com>,
	"Matthew Wilcox (Oracle)" <willy@infradead.org>
Cc: linux-ext4@vger.kernel.org, linux-fsdevel@vger.kernel.org,
	ntfs3@lists.linux.dev, ocfs2-devel@oss.oracle.com,
	linux-mm@kvack.org
Subject: [PATCH 1/6] fs: remove an outdated comment on mpage_writepages
Date: Thu, 29 Dec 2022 06:10:26 -1000	[thread overview]
Message-ID: <20221229161031.391878-2-hch@lst.de> (raw)
In-Reply-To: <20221229161031.391878-1-hch@lst.de>

mpage_writepages doesn't do any of the page locking itself, so remove
and outdated comment on the locking pattern there.

Signed-off-by: Christoph Hellwig <hch@lst.de>
---
 fs/mpage.c | 8 --------
 1 file changed, 8 deletions(-)

diff --git a/fs/mpage.c b/fs/mpage.c
index 0f8ae954a57903..910cfe8a60d2e4 100644
--- a/fs/mpage.c
+++ b/fs/mpage.c
@@ -641,14 +641,6 @@ static int __mpage_writepage(struct page *page, struct writeback_control *wbc,
  *
  * This is a library function, which implements the writepages()
  * address_space_operation.
- *
- * If a page is already under I/O, generic_writepages() skips it, even
- * if it's dirty.  This is desirable behaviour for memory-cleaning writeback,
- * but it is INCORRECT for data-integrity system calls such as fsync().  fsync()
- * and msync() need to guarantee that all the data which was dirty at the time
- * the call was made get new I/O started against them.  If wbc->sync_mode is
- * WB_SYNC_ALL then we were called for data integrity and we must wait for
- * existing IO to complete.
  */
 int
 mpage_writepages(struct address_space *mapping,
-- 
2.35.1


WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig via Ocfs2-devel <ocfs2-devel@oss.oracle.com>
To: Andrew Morton <akpm@linux-foundation.org>,
	"Theodore Ts'o" <tytso@mit.edu>, Jan Kara <jack@suse.com>,
	Konstantin Komarov <almaz.alexandrovich@paragon-software.com>,
	Mark Fasheh <mark@fasheh.com>, Joel Becker <jlbec@evilplan.org>,
	Joseph Qi <joseph.qi@linux.alibaba.com>,
	"Matthew Wilcox (Oracle)" <willy@infradead.org>
Cc: linux-fsdevel@vger.kernel.org, linux-mm@kvack.org,
	linux-ext4@vger.kernel.org, ocfs2-devel@oss.oracle.com,
	ntfs3@lists.linux.dev
Subject: [Ocfs2-devel] [PATCH 1/6] fs: remove an outdated comment on mpage_writepages
Date: Thu, 29 Dec 2022 06:10:26 -1000	[thread overview]
Message-ID: <20221229161031.391878-2-hch@lst.de> (raw)
In-Reply-To: <20221229161031.391878-1-hch@lst.de>

mpage_writepages doesn't do any of the page locking itself, so remove
and outdated comment on the locking pattern there.

Signed-off-by: Christoph Hellwig <hch@lst.de>
---
 fs/mpage.c | 8 --------
 1 file changed, 8 deletions(-)

diff --git a/fs/mpage.c b/fs/mpage.c
index 0f8ae954a57903..910cfe8a60d2e4 100644
--- a/fs/mpage.c
+++ b/fs/mpage.c
@@ -641,14 +641,6 @@ static int __mpage_writepage(struct page *page, struct writeback_control *wbc,
  *
  * This is a library function, which implements the writepages()
  * address_space_operation.
- *
- * If a page is already under I/O, generic_writepages() skips it, even
- * if it's dirty.  This is desirable behaviour for memory-cleaning writeback,
- * but it is INCORRECT for data-integrity system calls such as fsync().  fsync()
- * and msync() need to guarantee that all the data which was dirty at the time
- * the call was made get new I/O started against them.  If wbc->sync_mode is
- * WB_SYNC_ALL then we were called for data integrity and we must wait for
- * existing IO to complete.
  */
 int
 mpage_writepages(struct address_space *mapping,
-- 
2.35.1


_______________________________________________
Ocfs2-devel mailing list
Ocfs2-devel@oss.oracle.com
https://oss.oracle.com/mailman/listinfo/ocfs2-devel

  reply	other threads:[~2022-12-29 16:10 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-29 16:10 remove generic_writepages Christoph Hellwig
2022-12-29 16:10 ` [Ocfs2-devel] " Christoph Hellwig via Ocfs2-devel
2022-12-29 16:10 ` Christoph Hellwig [this message]
2022-12-29 16:10   ` [Ocfs2-devel] [PATCH 1/6] fs: remove an outdated comment on mpage_writepages Christoph Hellwig via Ocfs2-devel
2023-01-02 12:13   ` Jan Kara
2023-01-02 12:13     ` [Ocfs2-devel] " Jan Kara via Ocfs2-devel
2022-12-29 16:10 ` [PATCH 2/6] ntfs3: stop using generic_writepages Christoph Hellwig
2022-12-29 16:10   ` [Ocfs2-devel] " Christoph Hellwig via Ocfs2-devel
2022-12-29 16:10 ` [PATCH 3/6] ntfs3: remove ->writepage Christoph Hellwig
2022-12-29 16:10   ` [Ocfs2-devel] " Christoph Hellwig via Ocfs2-devel
2022-12-29 16:10 ` [PATCH 4/6] jbd2,ocfs2: move jbd2_journal_submit_inode_data_buffers to ocfs2 Christoph Hellwig
2022-12-29 16:10   ` [Ocfs2-devel] [PATCH 4/6] jbd2, ocfs2: " Christoph Hellwig via Ocfs2-devel
2022-12-29 16:10 ` [PATCH 5/6] ocfs2: use filemap_fdatawrite_wbc instead of generic_writepages Christoph Hellwig
2022-12-29 16:10   ` [Ocfs2-devel] " Christoph Hellwig via Ocfs2-devel
2023-01-02 12:15   ` Jan Kara
2023-01-02 12:15     ` [Ocfs2-devel] " Jan Kara via Ocfs2-devel
2022-12-29 16:10 ` [PATCH 6/6] mm: remove generic_writepages Christoph Hellwig
2022-12-29 16:10   ` [Ocfs2-devel] " Christoph Hellwig via Ocfs2-devel
2023-01-02 12:16   ` Jan Kara
2023-01-02 12:16     ` [Ocfs2-devel] " Jan Kara via Ocfs2-devel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20221229161031.391878-2-hch@lst.de \
    --to=hch@lst.de \
    --cc=akpm@linux-foundation.org \
    --cc=almaz.alexandrovich@paragon-software.com \
    --cc=jack@suse.com \
    --cc=jlbec@evilplan.org \
    --cc=joseph.qi@linux.alibaba.com \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mark@fasheh.com \
    --cc=ntfs3@lists.linux.dev \
    --cc=ocfs2-devel@oss.oracle.com \
    --cc=tytso@mit.edu \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.