From: Bjorn Andersson <andersson@kernel.org> To: Stephan Gerhold <stephan@gerhold.net> Cc: Andy Gross <agross@kernel.org>, Konrad Dybcio <konrad.dybcio@linaro.org>, Rob Herring <robh+dt@kernel.org>, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>, Mark Brown <broonie@kernel.org>, Jiasheng Jiang <jiasheng@iscas.ac.cn>, Srinivas Kandagatla <srinivas.kandagatla@linaro.org>, Banajit Goswami <bgoswami@quicinc.com>, linux-arm-msm@vger.kernel.org, alsa-devel@alsa-project.org, devicetree@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht Subject: Re: [PATCH 1/2] dt-bindings: soc: qcom: apr: Make qcom,protection-domain optional again Date: Thu, 29 Dec 2022 12:29:17 -0600 [thread overview] Message-ID: <20221229182917.j6wrerqufom3hfx7@builder.lan> (raw) In-Reply-To: <20221229151648.19839-2-stephan@gerhold.net> On Thu, Dec 29, 2022 at 04:16:47PM +0100, Stephan Gerhold wrote: > The protection domain functionality exists only in SoCs starting from > MSM8998 [1], while the APR bindings are also used on older platforms. > > Commit 41288c305836 ("ASoC: dt-bindings: qcom,apr: Split services to > shared schema") made the "qcom,protection-domain" required but it > should remain optional to avoid dtbs_check warnings on older platforms, > e.g.: > > arch/arm64/boot/dts/qcom/apq8096-db820c.dtb: > apr: service@3: 'qcom,protection-domain' is a required property > From schema: Documentation/devicetree/bindings/soc/qcom/qcom,apr.yaml > > [1]: https://lore.kernel.org/all/20200312120842.21991-1-sibis@codeaurora.org/ > > Fixes: 41288c305836 ("ASoC: dt-bindings: qcom,apr: Split services to shared schema") > Signed-off-by: Stephan Gerhold <stephan@gerhold.net> Reviewed-by: Bjorn Andersson <andersson@kernel.org> Regards, Bjorn > --- > .../devicetree/bindings/soc/qcom/qcom,apr-services.yaml | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom,apr-services.yaml b/Documentation/devicetree/bindings/soc/qcom/qcom,apr-services.yaml > index 290555426c39..bdf482db32aa 100644 > --- a/Documentation/devicetree/bindings/soc/qcom/qcom,apr-services.yaml > +++ b/Documentation/devicetree/bindings/soc/qcom/qcom,apr-services.yaml > @@ -39,8 +39,8 @@ properties: > qcom,protection-domain: > $ref: /schemas/types.yaml#/definitions/string-array > description: | > - Protection domain service name and path for APR service > - possible values are:: > + Protection domain service name and path for APR service (if supported). > + Possible values are:: > "avs/audio", "msm/adsp/audio_pd". > "kernel/elf_loader", "msm/modem/wlan_pd". > "tms/servreg", "msm/adsp/audio_pd". > @@ -49,6 +49,5 @@ properties: > > required: > - reg > - - qcom,protection-domain > > additionalProperties: true > -- > 2.39.0 >
WARNING: multiple messages have this Message-ID (diff)
From: Bjorn Andersson <andersson@kernel.org> To: Stephan Gerhold <stephan@gerhold.net> Cc: devicetree@vger.kernel.org, alsa-devel@alsa-project.org, Banajit Goswami <bgoswami@quicinc.com>, linux-arm-msm@vger.kernel.org, Jiasheng Jiang <jiasheng@iscas.ac.cn>, Andy Gross <agross@kernel.org>, Rob Herring <robh+dt@kernel.org>, Konrad Dybcio <konrad.dybcio@linaro.org>, Mark Brown <broonie@kernel.org>, Srinivas Kandagatla <srinivas.kandagatla@linaro.org>, ~postmarketos/upstreaming@lists.sr.ht, Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org> Subject: Re: [PATCH 1/2] dt-bindings: soc: qcom: apr: Make qcom,protection-domain optional again Date: Thu, 29 Dec 2022 12:29:17 -0600 [thread overview] Message-ID: <20221229182917.j6wrerqufom3hfx7@builder.lan> (raw) In-Reply-To: <20221229151648.19839-2-stephan@gerhold.net> On Thu, Dec 29, 2022 at 04:16:47PM +0100, Stephan Gerhold wrote: > The protection domain functionality exists only in SoCs starting from > MSM8998 [1], while the APR bindings are also used on older platforms. > > Commit 41288c305836 ("ASoC: dt-bindings: qcom,apr: Split services to > shared schema") made the "qcom,protection-domain" required but it > should remain optional to avoid dtbs_check warnings on older platforms, > e.g.: > > arch/arm64/boot/dts/qcom/apq8096-db820c.dtb: > apr: service@3: 'qcom,protection-domain' is a required property > From schema: Documentation/devicetree/bindings/soc/qcom/qcom,apr.yaml > > [1]: https://lore.kernel.org/all/20200312120842.21991-1-sibis@codeaurora.org/ > > Fixes: 41288c305836 ("ASoC: dt-bindings: qcom,apr: Split services to shared schema") > Signed-off-by: Stephan Gerhold <stephan@gerhold.net> Reviewed-by: Bjorn Andersson <andersson@kernel.org> Regards, Bjorn > --- > .../devicetree/bindings/soc/qcom/qcom,apr-services.yaml | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom,apr-services.yaml b/Documentation/devicetree/bindings/soc/qcom/qcom,apr-services.yaml > index 290555426c39..bdf482db32aa 100644 > --- a/Documentation/devicetree/bindings/soc/qcom/qcom,apr-services.yaml > +++ b/Documentation/devicetree/bindings/soc/qcom/qcom,apr-services.yaml > @@ -39,8 +39,8 @@ properties: > qcom,protection-domain: > $ref: /schemas/types.yaml#/definitions/string-array > description: | > - Protection domain service name and path for APR service > - possible values are:: > + Protection domain service name and path for APR service (if supported). > + Possible values are:: > "avs/audio", "msm/adsp/audio_pd". > "kernel/elf_loader", "msm/modem/wlan_pd". > "tms/servreg", "msm/adsp/audio_pd". > @@ -49,6 +49,5 @@ properties: > > required: > - reg > - - qcom,protection-domain > > additionalProperties: true > -- > 2.39.0 >
next prev parent reply other threads:[~2022-12-29 18:30 UTC|newest] Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top 2022-12-29 15:16 [PATCH 0/2] Fix APR audio regression on 6.2-rc1 Stephan Gerhold 2022-12-29 15:16 ` Stephan Gerhold 2022-12-29 15:16 ` [PATCH 1/2] dt-bindings: soc: qcom: apr: Make qcom, protection-domain optional again Stephan Gerhold 2022-12-29 15:16 ` [PATCH 1/2] dt-bindings: soc: qcom: apr: Make qcom,protection-domain " Stephan Gerhold 2022-12-29 18:29 ` Bjorn Andersson [this message] 2022-12-29 18:29 ` Bjorn Andersson 2022-12-30 8:08 ` Krzysztof Kozlowski 2022-12-30 8:08 ` Krzysztof Kozlowski 2022-12-29 15:16 ` [PATCH 2/2] " Stephan Gerhold 2022-12-29 15:16 ` [PATCH 2/2] soc: qcom: apr: Make qcom, protection-domain " Stephan Gerhold 2022-12-29 17:53 ` [PATCH 2/2] soc: qcom: apr: Make qcom,protection-domain " Bjorn Andersson 2022-12-29 17:53 ` [PATCH 2/2] soc: qcom: apr: Make qcom, protection-domain " Bjorn Andersson 2023-01-06 20:24 ` [PATCH 0/2] Fix APR audio regression on 6.2-rc1 Bjorn Andersson 2023-01-06 20:24 ` Bjorn Andersson
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20221229182917.j6wrerqufom3hfx7@builder.lan \ --to=andersson@kernel.org \ --cc=agross@kernel.org \ --cc=alsa-devel@alsa-project.org \ --cc=bgoswami@quicinc.com \ --cc=broonie@kernel.org \ --cc=devicetree@vger.kernel.org \ --cc=jiasheng@iscas.ac.cn \ --cc=konrad.dybcio@linaro.org \ --cc=krzysztof.kozlowski+dt@linaro.org \ --cc=linux-arm-msm@vger.kernel.org \ --cc=robh+dt@kernel.org \ --cc=srinivas.kandagatla@linaro.org \ --cc=stephan@gerhold.net \ --cc=~postmarketos/upstreaming@lists.sr.ht \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: linkBe sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.