All of
 help / color / mirror / Atom feed
From: Hongyu Xie <>
	Hongyu Xie <>, k2ci <>
Subject: [RESEND PATCH v3 -next] fs: coredump: using preprocessor directives for dump_emit_page
Date: Fri, 30 Dec 2022 10:13:51 +0800	[thread overview]
Message-ID: <> (raw)

When CONFIG_COREDUMP is set and CONFIG_ELF_CORE is not set, you get warning
fs/coredump.c:841:12: error: ‘dump_emit_page’ defined but not used
841 | static int dump_emit_page(struct coredump_params *cprm, struct
page *page)

dump_emit_page only called in dump_user_range, since dump_user_range
using #ifdef preprocessor directives, use #ifdef for dump_emit_page too.

Fixes: 06bbaa6dc53c ("[coredump] don't use __kernel_write() on kmap_local_page()")
Reported-by: k2ci <>
Signed-off-by: Hongyu Xie <>
 fs/coredump.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/fs/coredump.c b/fs/coredump.c
index de78bde2991b..95390a73b912 100644
--- a/fs/coredump.c
+++ b/fs/coredump.c
@@ -838,6 +838,7 @@ static int __dump_skip(struct coredump_params *cprm, size_t nr)
 static int dump_emit_page(struct coredump_params *cprm, struct page *page)
 	struct bio_vec bvec = {
@@ -870,6 +871,7 @@ static int dump_emit_page(struct coredump_params *cprm, struct page *page)
 	return 1;
 int dump_emit(struct coredump_params *cprm, const void *addr, int nr)

                 reply	other threads:[~2022-12-30  2:14 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.