* [PATCH v4 -next] fs: coredump: using preprocessor directives for dump_emit_page
@ 2022-12-30 2:24 Hongyu Xie
0 siblings, 0 replies; only message in thread
From: Hongyu Xie @ 2022-12-30 2:24 UTC (permalink / raw)
To: viro; +Cc: linux-kernel, linux-fsdevel, Hongyu Xie, k2ci
When CONFIG_COREDUMP is set and CONFIG_ELF_CORE is not, you'll get warnings
like:
fs/coredump.c:841:12: error: ‘dump_emit_page’ defined but not used
[-Werror=unused-function]
841 | static int dump_emit_page(struct coredump_params *cprm, struct
page *page)
dump_emit_page only called in dump_user_range, since dump_user_range
using #ifdef preprocessor directives, use #ifdef for dump_emit_page too.
Fixes: 06bbaa6dc53c ("[coredump] don't use __kernel_write() on kmap_local_page()")
Reported-by: k2ci <kernel-bot@kylinos.cn>
Signed-off-by: Hongyu Xie <xiehongyu1@kylinos.cn>
---
v4: modify commit msg
v3: add reported by
v2: change sending mail address
fs/coredump.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/fs/coredump.c b/fs/coredump.c
index de78bde2991b..95390a73b912 100644
--- a/fs/coredump.c
+++ b/fs/coredump.c
@@ -838,6 +838,7 @@ static int __dump_skip(struct coredump_params *cprm, size_t nr)
}
}
+#ifdef CONFIG_ELF_CORE
static int dump_emit_page(struct coredump_params *cprm, struct page *page)
{
struct bio_vec bvec = {
@@ -870,6 +871,7 @@ static int dump_emit_page(struct coredump_params *cprm, struct page *page)
return 1;
}
+#endif
int dump_emit(struct coredump_params *cprm, const void *addr, int nr)
{
--
2.34.1
^ permalink raw reply related [flat|nested] only message in thread
only message in thread, other threads:[~2022-12-30 2:24 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-12-30 2:24 [PATCH v4 -next] fs: coredump: using preprocessor directives for dump_emit_page Hongyu Xie
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.