From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B9369C4332F for ; Fri, 30 Dec 2022 06:04:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234461AbiL3GEi (ORCPT ); Fri, 30 Dec 2022 01:04:38 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35076 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229557AbiL3GEf (ORCPT ); Fri, 30 Dec 2022 01:04:35 -0500 Received: from mailgw02.mediatek.com (unknown [210.61.82.184]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 879D92705; Thu, 29 Dec 2022 22:04:33 -0800 (PST) X-UUID: b010f305589044018866764ff239394a-20221230 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Type:MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:CC:To:From; bh=HZ1UEuoswFV91eUeLIRJsGfxTtDFlYQbel62pi18o2U=; b=OBWfK1V22CSmR5yTHA99TwuXBwEX0VQUzqsi4Pj33nUywBueYO3lOMuInfXj5jE9BWhE5H8QP9KRMWnDC1I4ZkzlbEeAg+uoan/2dhHot6TnxhXms2W2z58fS4CvzRhJDFFx2L2aLW47pQmnlX4tjbteYXeXaqo1m3n/lifhJiA=; X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.16,REQID:d932d63d-87bf-4f90-9edf-125800eae4c7,IP:0,U RL:0,TC:0,Content:0,EDM:0,RT:0,SF:0,FILE:0,BULK:0,RULE:Release_Ham,ACTION: release,TS:0 X-CID-META: VersionHash:09771b1,CLOUDID:943f60f4-ff42-4fb0-b929-626456a83c14,B ulkID:nil,BulkQuantity:0,Recheck:0,SF:102,TC:nil,Content:0,EDM:-3,IP:nil,U RL:0,File:nil,Bulk:nil,QS:nil,BEC:nil,COL:0,OSI:0,OSA:0 X-CID-BVR: 1,FCT|NGT X-UUID: b010f305589044018866764ff239394a-20221230 Received: from mtkmbs11n2.mediatek.inc [(172.21.101.187)] by mailgw02.mediatek.com (envelope-from ) (Generic MTA with TLSv1.2 ECDHE-RSA-AES256-GCM-SHA384 256/256) with ESMTP id 349687402; Fri, 30 Dec 2022 14:04:27 +0800 Received: from mtkmbs11n2.mediatek.inc (172.21.101.187) by mtkmbs10n1.mediatek.inc (172.21.101.34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.792.15; Fri, 30 Dec 2022 14:04:27 +0800 Received: from mtksdccf07.mediatek.inc (172.21.84.99) by mtkmbs11n2.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.2.792.15 via Frontend Transport; Fri, 30 Dec 2022 14:04:27 +0800 From: Miles Chen To: CC: , , , , , , , , , , , , , , , , , , , , , , , , , , , Subject: Re: [PATCH v2 22/23] clk: mediatek: clk-mt7986-topckgen: Properly keep some clocks enabled Date: Fri, 30 Dec 2022 14:04:26 +0800 Message-ID: <20221230060426.16415-1-miles.chen@mediatek.com> X-Mailer: git-send-email 2.18.0 In-Reply-To: <20221223094259.87373-23-angelogioacchino.delregno@collabora.com> References: <20221223094259.87373-23-angelogioacchino.delregno@collabora.com> MIME-Version: 1.0 Content-Type: text/plain X-MTK: N Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > Instead of calling clk_prepare_enable() on a bunch of clocks at probe > time, set the CLK_IS_CRITICAL flag to the same as these are required > to be always on, and this is the right way of achieving that. > > Signed-off-by: AngeloGioacchino Del Regno Reviewed-by: Miles Chen From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D83BDC4332F for ; Fri, 30 Dec 2022 06:06:34 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:CC:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=7qANWy+oIPx02Au4J/3qH02g+o463j7QnaPCNTqDTqQ=; b=VuPlo3R6h33KaT 307fNA3luSP8Mvpsw9dYybWzXyOZNz4NSFYJT39c+wjODnObaQXQHYESRhbRKtJzD/EC0E6HOdMge wVdXtHaxrLClgdHU2K4czrLyj7Abv7q70fpT8ZOLKBIRB935WI9D8YzWsg/T73CmbHqDDr/qlvLwO jy1iRLeQ9NFIO0FVtM0kjyMQydinQK7JdDX0TdRoKBCnH5/k116zAo5cOxDTRoI4S2fgGXx3r/1UM DB5Xv3dh8WTTJ+UBaWJqGJ/taK3BevSw58yunTS/Y+7Q/FQ6iqTF9evg4QcnwFjNe0PjYV9VJEDVF eKSmlFnZb92RK3MC/wRw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pB8W9-006GFO-4T; Fri, 30 Dec 2022 06:05:21 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pB8W3-006GB0-O4; Fri, 30 Dec 2022 06:05:18 +0000 X-UUID: 9ca461d401ef47cda1da72ecfa9db42b-20221229 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Type:MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:CC:To:From; bh=HZ1UEuoswFV91eUeLIRJsGfxTtDFlYQbel62pi18o2U=; b=OBWfK1V22CSmR5yTHA99TwuXBwEX0VQUzqsi4Pj33nUywBueYO3lOMuInfXj5jE9BWhE5H8QP9KRMWnDC1I4ZkzlbEeAg+uoan/2dhHot6TnxhXms2W2z58fS4CvzRhJDFFx2L2aLW47pQmnlX4tjbteYXeXaqo1m3n/lifhJiA=; X-CID-P-RULE: Release_Ham X-CID-O-INFO: VERSION:1.1.16,REQID:5ab6f81a-d57d-4035-9eb6-0b52824a8bec,IP:0,U RL:0,TC:0,Content:0,EDM:0,RT:0,SF:0,FILE:0,BULK:0,RULE:Release_Ham,ACTION: release,TS:0 X-CID-META: VersionHash:09771b1,CLOUDID:634660f4-ff42-4fb0-b929-626456a83c14,B ulkID:nil,BulkQuantity:0,Recheck:0,SF:102,TC:nil,Content:0,EDM:-3,IP:nil,U RL:0,File:nil,Bulk:nil,QS:nil,BEC:nil,COL:0,OSI:0,OSA:0 X-CID-BVR: 1,FCT|NGT X-UUID: 9ca461d401ef47cda1da72ecfa9db42b-20221229 Received: from mtkmbs11n2.mediatek.inc [(172.21.101.187)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-GCM-SHA384 256/256) with ESMTP id 1043405116; Thu, 29 Dec 2022 23:05:02 -0700 Received: from mtkmbs11n2.mediatek.inc (172.21.101.187) by mtkmbs10n1.mediatek.inc (172.21.101.34) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.792.15; Fri, 30 Dec 2022 14:04:27 +0800 Received: from mtksdccf07.mediatek.inc (172.21.84.99) by mtkmbs11n2.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.2.792.15 via Frontend Transport; Fri, 30 Dec 2022 14:04:27 +0800 From: Miles Chen To: CC: , , , , , , , , , , , , , , , , , , , , , , , , , , , Subject: Re: [PATCH v2 22/23] clk: mediatek: clk-mt7986-topckgen: Properly keep some clocks enabled Date: Fri, 30 Dec 2022 14:04:26 +0800 Message-ID: <20221230060426.16415-1-miles.chen@mediatek.com> X-Mailer: git-send-email 2.18.0 In-Reply-To: <20221223094259.87373-23-angelogioacchino.delregno@collabora.com> References: <20221223094259.87373-23-angelogioacchino.delregno@collabora.com> MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221229_220516_212619_DC4294DC X-CRM114-Status: UNSURE ( 7.75 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org > Instead of calling clk_prepare_enable() on a bunch of clocks at probe > time, set the CLK_IS_CRITICAL flag to the same as these are required > to be always on, and this is the right way of achieving that. > > Signed-off-by: AngeloGioacchino Del Regno Reviewed-by: Miles Chen _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel