From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1E94CC4167B for ; Fri, 30 Dec 2022 12:44:17 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 7497B854EC; Fri, 30 Dec 2022 13:44:14 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=kernel.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (2048-bit key; unprotected) header.d=kernel.org header.i=@kernel.org header.b="hga8jh4j"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id B53F68510E; Fri, 30 Dec 2022 13:44:12 +0100 (CET) Received: from dfw.source.kernel.org (dfw.source.kernel.org [IPv6:2604:1380:4641:c500::1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id D763685518 for ; Fri, 30 Dec 2022 13:44:09 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=kernel.org Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=pali@kernel.org Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id D1DDD60F72; Fri, 30 Dec 2022 12:44:07 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 245D9C433D2; Fri, 30 Dec 2022 12:44:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1672404247; bh=B5hos7FCQZ6uhSeyOXIAOyvi5VWJ0bAVQBBIW7oQ5EA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=hga8jh4j+cm6omCJVzjHfPAlEbseIbPM2nvVfmjjeSmxyw0fZ2Ud80iu1heay3lB3 gX0p4Vn69vEdIRNdqnta0lAllnGUDATv6TzPT4HISHKd/s3b8gL8Wts1WlsX1PWehg rqtHdBT6s8CKVuLPAp/RQBO0vNtdjrhofJpI4kemo56aDuZAiXfQc7JfpkseOZ9XDg 8sXV+fcLJLC4dheDdoBed8PHdy2lZvJDELCYWzjhvRkcidNB+s+ljbn212c7YufdBg 0fxGt6Lw8yrn41nlNWJ/1hAb5Z4ZWDGB+YtRum5iItUKVh0m16T7yYs+YkRJyRrPkZ Kv9lhK0PMMoig== Received: by pali.im (Postfix) id 33C639E4; Fri, 30 Dec 2022 13:44:04 +0100 (CET) Date: Fri, 30 Dec 2022 13:44:04 +0100 From: Pali =?utf-8?B?Um9ow6Fy?= To: Tom Rini Cc: Heiko Schocher , u-boot@lists.denx.de Subject: Re: [PATCH u-boot] powerpc/mpc85xx: socrates: Re-enable building u-boot-socrates.bin Message-ID: <20221230124404.s7wdiqvjia5x3xe3@pali> References: <20221228181839.22003-1-pali@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20221228181839.22003-1-pali@kernel.org> User-Agent: NeoMutt/20180716 X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean Tom, would you take this patch to master? On Wednesday 28 December 2022 19:18:39 Pali Rohár wrote: > U-Boot build system builds final U-Boot binary for socrates board in custom > file u-boot-socrates.bin (instead of standard u-boot.bin). Output target > file u-boot-socrates.bin is generated by binman as defined in board binman > config file arch/powerpc/dts/socrates-u-boot.dtsi. > > But binman was disabled in commit 5af42eafd7e1 ("Makefile: Reduce usage of > custom mpc85xx u-boot.bin target") for all mpc85xx boards which do not use > standard powerpc binman config file arch/powerpc/dts/u-boot.dtsi and boards > which do not require binman at all. > > The only such mpc85xx board is socrates. So since that commit, U-Boot does > not final binary for socrates board anymore. > > Fix this issue by re-enabling binman for socrates board. And build process > starts again producing u-boot-socrates.bin binary. > > Note that build process for this socrates board always produce u-boot.bin > binary which is broken and not usable for socrates board. Long term > solution should be to disable building broken binary u-boot.bin and then > renaming u-boot-socrates.bin to u-boot.bin, or switching to use common > powerpc binman config file arch/powerpc/dts/socrates-u-boot.dtsi (if it is > possible). > > Fixes: 5af42eafd7e1 ("Makefile: Reduce usage of custom mpc85xx u-boot.bin target") > Signed-off-by: Pali Rohár > --- > Heiko Schocher: Could you test if u-boot is still working on this board? > > Tom Rini: Cannot be this issue handled by CI? For example that CI check > build process produce required output binaries? > --- > arch/powerpc/cpu/mpc85xx/Kconfig | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/powerpc/cpu/mpc85xx/Kconfig b/arch/powerpc/cpu/mpc85xx/Kconfig > index 24d3f1f20c25..4c765efab7a5 100644 > --- a/arch/powerpc/cpu/mpc85xx/Kconfig > +++ b/arch/powerpc/cpu/mpc85xx/Kconfig > @@ -72,6 +72,7 @@ choice > config TARGET_SOCRATES > bool "Support socrates" > select ARCH_MPC8544 > + select BINMAN > > config TARGET_P3041DS > bool "Support P3041DS" > -- > 2.20.1 >