From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 0C96FC4167B for ; Fri, 30 Dec 2022 15:20:25 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 397B7852B6; Fri, 30 Dec 2022 16:20:23 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Authentication-Results: phobos.denx.de; dkim=pass (1024-bit key; unprotected) header.d=konsulko.com header.i=@konsulko.com header.b="d7fPMtMv"; dkim-atps=neutral Received: by phobos.denx.de (Postfix, from userid 109) id 52B4085533; Fri, 30 Dec 2022 16:20:21 +0100 (CET) Received: from mail-vs1-xe29.google.com (mail-vs1-xe29.google.com [IPv6:2607:f8b0:4864:20::e29]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 81C31852B6 for ; Fri, 30 Dec 2022 16:20:18 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=pass (p=none dis=none) header.from=konsulko.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=trini@konsulko.com Received: by mail-vs1-xe29.google.com with SMTP id o63so16729954vsc.10 for ; Fri, 30 Dec 2022 07:20:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=konsulko.com; s=google; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=wxyn7FEEgKfL9K8vr/jJ7c2F831x47GNj1q4OGSzpjQ=; b=d7fPMtMvVybJrl9lp8JL+YODE4ZH4IDdxFnQec65kqjys/vJnivYG3Tv5446DcrMID fcyNiHh255otJSctjPgd61oRMLuU1/KcxoaFfTrC6eq1dF/0PGbr5oB7B800eXVzKybH Cadu4oy766y3sM4wLgfB/NlL2gXUzdc53eFmM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=wxyn7FEEgKfL9K8vr/jJ7c2F831x47GNj1q4OGSzpjQ=; b=QOf0yBbRbMGRPvcNEXfMrOwJYvS9+5yys0bebqP+MYRgq7tZ61l4vdITIEqfTsz6se NvQFpXP4SYj9IqPE9myeu5fpQiSjx3eA3J4At5Kh77ZPhcx2myeXJLpJYe9d0f/n/l+T pv8vGaMja5YaCMHXK2wwVhUeZ0CeC6cF7d/cPe2IJ/teSmtDvMdyz94EIQ/U34IUTAH6 6aHIQ0Tp7lg0ejYBn8C5GK3fpUCp38MrqPsoobKIwVpuNYEVbjBTTblrJluqNoPVJQeF JV/AkySYw3dzJHmf8/iCPrxKI4yUVzNO25Y1xe1C2Qm8yPILsjtjlQYqfkurnJ36+Gsx Z1dQ== X-Gm-Message-State: AFqh2kq96FBFTYAaBFDj6WIfWnzL3uM6ImGQwMye90DSycw+4tZpPq24 ab8nacRxzjPzMZdsOBfiFPtv6w== X-Google-Smtp-Source: AMrXdXuAaDM95W4KZhpfSisWiSN9pukI9zHZLFEddWRs+IY76/n392QLm3oQTj4LbnuYGzdyIowuMQ== X-Received: by 2002:a67:f995:0:b0:3c5:eb62:d30f with SMTP id b21-20020a67f995000000b003c5eb62d30fmr9355777vsq.18.1672413617148; Fri, 30 Dec 2022 07:20:17 -0800 (PST) Received: from bill-the-cat (2603-6081-7b00-6400-a5a5-eb4c-bea2-121a.res6.spectrum.com. [2603:6081:7b00:6400:a5a5:eb4c:bea2:121a]) by smtp.gmail.com with ESMTPSA id bm36-20020a05620a19a400b006fa4cac54a5sm15236793qkb.72.2022.12.30.07.20.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 30 Dec 2022 07:20:16 -0800 (PST) Date: Fri, 30 Dec 2022 10:20:15 -0500 From: Tom Rini To: Pali =?iso-8859-1?Q?Roh=E1r?= Cc: Heiko Schocher , u-boot@lists.denx.de Subject: Re: [PATCH u-boot] powerpc/mpc85xx: socrates: Re-enable building u-boot-socrates.bin Message-ID: <20221230152015.GY3787616@bill-the-cat> References: <20221228181839.22003-1-pali@kernel.org> <20221230124404.s7wdiqvjia5x3xe3@pali> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="V4wyGfM9ojLfNNg0" Content-Disposition: inline In-Reply-To: <20221230124404.s7wdiqvjia5x3xe3@pali> X-Clacks-Overhead: GNU Terry Pratchett X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.39 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.6 at phobos.denx.de X-Virus-Status: Clean --V4wyGfM9ojLfNNg0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Fri, Dec 30, 2022 at 01:44:04PM +0100, Pali Roh=E1r wrote: > Tom, would you take this patch to master? Yes, I'm just assuming Heiko will have a chance to test this before the release on the 9th, thanks. >=20 > On Wednesday 28 December 2022 19:18:39 Pali Roh=E1r wrote: > > U-Boot build system builds final U-Boot binary for socrates board in cu= stom > > file u-boot-socrates.bin (instead of standard u-boot.bin). Output target > > file u-boot-socrates.bin is generated by binman as defined in board bin= man > > config file arch/powerpc/dts/socrates-u-boot.dtsi. > >=20 > > But binman was disabled in commit 5af42eafd7e1 ("Makefile: Reduce usage= of > > custom mpc85xx u-boot.bin target") for all mpc85xx boards which do not = use > > standard powerpc binman config file arch/powerpc/dts/u-boot.dtsi and bo= ards > > which do not require binman at all. > >=20 > > The only such mpc85xx board is socrates. So since that commit, U-Boot d= oes > > not final binary for socrates board anymore. > >=20 > > Fix this issue by re-enabling binman for socrates board. And build proc= ess > > starts again producing u-boot-socrates.bin binary. > >=20 > > Note that build process for this socrates board always produce u-boot.b= in > > binary which is broken and not usable for socrates board. Long term > > solution should be to disable building broken binary u-boot.bin and then > > renaming u-boot-socrates.bin to u-boot.bin, or switching to use common > > powerpc binman config file arch/powerpc/dts/socrates-u-boot.dtsi (if it= is > > possible). > >=20 > > Fixes: 5af42eafd7e1 ("Makefile: Reduce usage of custom mpc85xx u-boot.b= in target") > > Signed-off-by: Pali Roh=E1r > > --- > > Heiko Schocher: Could you test if u-boot is still working on this board? > >=20 > > Tom Rini: Cannot be this issue handled by CI? For example that CI check > > build process produce required output binaries? > > --- > > arch/powerpc/cpu/mpc85xx/Kconfig | 1 + > > 1 file changed, 1 insertion(+) > >=20 > > diff --git a/arch/powerpc/cpu/mpc85xx/Kconfig b/arch/powerpc/cpu/mpc85x= x/Kconfig > > index 24d3f1f20c25..4c765efab7a5 100644 > > --- a/arch/powerpc/cpu/mpc85xx/Kconfig > > +++ b/arch/powerpc/cpu/mpc85xx/Kconfig > > @@ -72,6 +72,7 @@ choice > > config TARGET_SOCRATES > > bool "Support socrates" > > select ARCH_MPC8544 > > + select BINMAN > > =20 > > config TARGET_P3041DS > > bool "Support P3041DS" > > --=20 > > 2.20.1 > >=20 --=20 Tom --V4wyGfM9ojLfNNg0 Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQGzBAABCgAdFiEEGjx/cOCPqxcHgJu/FHw5/5Y0tywFAmOvAasACgkQFHw5/5Y0 tywMWwv+K6XdIG2/6Mk83XCwdPZpYnEih77a5hq6UCGGyjGCu9rjaxmZxKq3gHkT PdNpC37kP5dsKvkRK4kqk6bIHb+20iWopouubz5JCoMgsuVuVR42I5dIBR77OcRK rkxT+Tk8vdv3PPoyOq+evwemqEJ5cB0hsIu3TyNBB4Z4YgowGMuhu930T6LLb1i9 P8d4mpKCnzMW/bHkPLhz2T7cWe1PF8mTQ5sSvnaGeeomMuncNTTUc/58EAwjIjda t7LyapWEagwCAGJ6swHCO67WTYvxYH0WFTYev2wbpoul/T7QYxhTqUl0VUWVfvF1 d4nCO4oBuZMjW250A3m/rGvq+aJbdPvHqLZXn+PSksOGHge9QVXVPOTQ8kHgUPsk C4gFUYDVe5xaw+fE4XkkLkAd8rVQS8/NnvWS/ewIUUoSkyj6Fnrm9iTaeMrRl1eo kAVw5c+hr2E4rB3TUrZyFbi/qRGG7xKs1HvQjhPP9iqmFS/it/S8NTekbIjATbmU U9pPIoU3 =ZQpN -----END PGP SIGNATURE----- --V4wyGfM9ojLfNNg0--