All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ricardo Martincoski <ricardo.martincoski@gmail.com>
To: buildroot@buildroot.org
Cc: Matt Weber <matthew.weber@collins.com>,
	Ricardo Martincoski <ricardo.martincoski@gmail.com>
Subject: [Buildroot] [PATCH 20/29] package/policycoreutils: drop bogus INSTALL_TARGET_LINUX_PAM_CONFS
Date: Sun,  1 Jan 2023 20:36:44 -0300	[thread overview]
Message-ID: <20230101233653.487175-21-ricardo.martincoski@gmail.com> (raw)
In-Reply-To: <20230101233653.487175-1-ricardo.martincoski@gmail.com>

Commit "cb328f77f8 policycoreutils: new package" added a define that is
never called: POLICYCOREUTILS_INSTALL_TARGET_LINUX_PAM_CONFS.

The build system from the package already install these files to target.
So just drop the bogus define.

Cc: Clayton Shotwell <clayton.shotwell@collins.com>
Cc: Matt Weber <matthew.weber@collins.com>
Signed-off-by: Ricardo Martincoski <ricardo.martincoski@gmail.com>
---
Using this defconfig:
 BR2_x86_i686=y
 BR2_TOOLCHAIN_EXTERNAL=y
 BR2_PACKAGE_LINUX_PAM=y
 BR2_PACKAGE_POLICYCOREUTILS=y
and performing a build before and after this patch, the content in
target/etc/pam.d/ is exactly the same.

$ md5sum output.*/target/etc/pam.d/* |sort
8448253cd52778260856591208cbf09a  output.after/target/etc/pam.d/run_init
8448253cd52778260856591208cbf09a  output.before/target/etc/pam.d/run_init
912cb497b06401def2991346787cfff3  output.after/target/etc/pam.d/other
912cb497b06401def2991346787cfff3  output.before/target/etc/pam.d/other
eac337ec241afe0ef2f4e5039be26cea  output.after/target/etc/pam.d/login
eac337ec241afe0ef2f4e5039be26cea  output.before/target/etc/pam.d/login
f4a2547443ac34fb30b7d06719328570  output.after/target/etc/pam.d/newrole
f4a2547443ac34fb30b7d06719328570  output.before/target/etc/pam.d/newrole
---
 package/policycoreutils/policycoreutils.mk | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/package/policycoreutils/policycoreutils.mk b/package/policycoreutils/policycoreutils.mk
index 60575ac644..8505dbca3f 100644
--- a/package/policycoreutils/policycoreutils.mk
+++ b/package/policycoreutils/policycoreutils.mk
@@ -16,10 +16,6 @@ POLICYCOREUTILS_MAKE_OPTS = LDLIBS=$(TARGET_NLS_LIBS)
 ifeq ($(BR2_PACKAGE_LINUX_PAM),y)
 POLICYCOREUTILS_DEPENDENCIES += linux-pam
 POLICYCOREUTILS_MAKE_OPTS += NAMESPACE_PRIV=y
-define POLICYCOREUTILS_INSTALL_TARGET_LINUX_PAM_CONFS
-	$(INSTALL) -D -m 0644 $(@D)/newrole/newrole-lspp.pamd $(TARGET_DIR)/etc/pam.d/newrole
-	$(INSTALL) -D -m 0644 $(@D)/run_init/run_init.pamd $(TARGET_DIR)/etc/pam.d/run_init
-endef
 endif
 
 ifeq ($(BR2_PACKAGE_AUDIT),y)
-- 
2.34.1

_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  parent reply	other threads:[~2023-01-01 23:43 UTC|newest]

Thread overview: 77+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-01 23:36 [Buildroot] [PATCH 00/29] check-package: warn about symbols not recognized by a package infra Ricardo Martincoski
2023-01-01 23:36 ` [Buildroot] [PATCH 01/29] package/pkg-generic: add check for deprecated _INSTALL_HOST_OPTS Ricardo Martincoski
2023-08-10 22:09   ` Thomas Petazzoni via buildroot
2023-01-01 23:36 ` [Buildroot] [PATCH 02/29] package/libmng: fix optional dependency to lcms2 Ricardo Martincoski
2023-01-04 16:45   ` Peter Korsgaard
2023-01-11  9:06   ` Peter Korsgaard
2023-01-01 23:36 ` [Buildroot] [PATCH 03/29] package/qcom-db410c-firmware: fix typo for <pkg>_LICENSE Ricardo Martincoski
2023-01-04 16:44   ` Peter Korsgaard
2023-01-11  9:06   ` Peter Korsgaard
2023-01-01 23:36 ` [Buildroot] [PATCH 04/29] package/tinyxml: fix typo for TINYXML_CPE_ID_VENDOR Ricardo Martincoski
2023-01-04 16:44   ` Peter Korsgaard
2023-01-11  9:06   ` Peter Korsgaard
2023-01-01 23:36 ` [Buildroot] [PATCH 05/29] package/gobject-introspection: really use host python for host variant Ricardo Martincoski
2023-01-05 22:28   ` Peter Korsgaard
2023-01-11  9:51   ` Peter Korsgaard
2023-01-01 23:36 ` [Buildroot] [PATCH 06/29] package/i2pd: really install configuration files Ricardo Martincoski
2023-01-04 16:46   ` Peter Korsgaard
2023-01-11  9:14   ` Peter Korsgaard
2023-01-01 23:36 ` [Buildroot] [PATCH 07/29] package/ima-evm-utils: really install to staging Ricardo Martincoski
2023-01-02 18:40   ` Petr Vorel
2023-01-04 16:46   ` Peter Korsgaard
2023-01-11  9:14   ` Peter Korsgaard
2023-01-01 23:36 ` [Buildroot] [PATCH 08/29] package/qt5/qt5virtualkeyboard: really configure language layouts Ricardo Martincoski
2023-01-04 16:48   ` Peter Korsgaard
2023-01-11  9:14   ` Peter Korsgaard
2023-01-01 23:36 ` [Buildroot] [PATCH 09/29] package/tekui: really disable parallel build Ricardo Martincoski
2023-01-04 16:51   ` Peter Korsgaard
2023-01-11  9:14   ` Peter Korsgaard
2023-01-01 23:36 ` [Buildroot] [PATCH 10/29] Revert "pptp-linux: fix build with high BR2_JLEVEL settings" Ricardo Martincoski
2023-01-04 16:52   ` Peter Korsgaard
2023-01-11  9:14   ` Peter Korsgaard
2023-01-01 23:36 ` [Buildroot] [PATCH 11/29] Revert "package/zip: install to staging" Ricardo Martincoski
2023-01-04 16:53   ` Peter Korsgaard
2023-01-11  9:14   ` Peter Korsgaard
2023-01-01 23:36 ` [Buildroot] [PATCH 12/29] boot/ti-k3-r5-loader: drop bogus TI_K3_R5_LOADER_BOARD Ricardo Martincoski
2023-01-04 16:53   ` Peter Korsgaard
2023-01-01 23:36 ` [Buildroot] [PATCH 13/29] package/checkpolicy: drop bogus CHECKPOLICY_STAGING_CMDS Ricardo Martincoski
2023-01-05  8:31   ` Peter Korsgaard
2023-01-11  9:31   ` Peter Korsgaard
2023-01-01 23:36 ` [Buildroot] [PATCH 14/29] package/exfat: drop dangling EXFAT_CFLAGS Ricardo Martincoski
2023-01-04 21:53   ` Peter Korsgaard
2023-01-11  9:17   ` Peter Korsgaard
2023-01-01 23:36 ` [Buildroot] [PATCH 15/29] package/falcosecurity-libs: drop bogus FALCOSECURITY_LIBS_SUPPORTS_IN_SOURCE_BUILD Ricardo Martincoski
2023-01-04 21:55   ` Peter Korsgaard
2023-01-11  9:17   ` Peter Korsgaard
2023-01-01 23:36 ` [Buildroot] [PATCH 16/29] package/glib-networking: drop dangling GLIB_NETWORKING_INSTALL_TARGET_OPTS Ricardo Martincoski
2023-01-04 21:55   ` Peter Korsgaard
2023-01-11  9:18   ` Peter Korsgaard
2023-01-01 23:36 ` [Buildroot] [PATCH 17/29] package/gobject-introspection: drop bugus GOBJECT_INTROSPECTION_AUTORECONF Ricardo Martincoski
2023-01-04 21:56   ` Peter Korsgaard
2023-01-11  9:18   ` Peter Korsgaard
2023-01-01 23:36 ` [Buildroot] [PATCH 18/29] package/libtalloc: drop bogus LIBTALLOC_{C, LD}FLAGS Ricardo Martincoski
2023-01-04 22:04   ` Peter Korsgaard
2023-01-11  9:19   ` Peter Korsgaard
2023-01-01 23:36 ` [Buildroot] [PATCH 19/29] package/lrzsz: drop bogus LRZSZ_BUILD_HOOKS Ricardo Martincoski
2023-01-04 22:06   ` Peter Korsgaard
2023-01-11  9:22   ` Peter Korsgaard
2023-01-01 23:36 ` Ricardo Martincoski [this message]
2023-01-04 22:07   ` [Buildroot] [PATCH 20/29] package/policycoreutils: drop bogus INSTALL_TARGET_LINUX_PAM_CONFS Peter Korsgaard
2023-01-11  9:22   ` Peter Korsgaard
2023-01-01 23:36 ` [Buildroot] [PATCH 21/29] package/qoriq-rcw: drop bogus QORIQ_RCW_FILE_BIN Ricardo Martincoski
2023-01-04 22:08   ` Peter Korsgaard
2023-01-11  9:23   ` Peter Korsgaard
2023-01-01 23:36 ` [Buildroot] [PATCH 22/29] package/rhash: drop dangling RHASH_ADDLDFLAGS Ricardo Martincoski
2023-01-04 22:09   ` Peter Korsgaard
2023-01-11  9:24   ` Peter Korsgaard
2023-01-01 23:36 ` [Buildroot] [PATCH 23/29] package/swupdate: drop dangling SWUPDATE_BUILD_CONFIG Ricardo Martincoski
2023-01-04 22:09   ` Peter Korsgaard
2023-01-11  9:24   ` Peter Korsgaard
2023-01-01 23:36 ` [Buildroot] [PATCH 24/29] package/wpa_supplicant: drop dangling WPA_SUPPLICANT_{LDFLAGS, MAKE_ENV} Ricardo Martincoski
2023-01-04 22:10   ` Peter Korsgaard
2023-01-11  9:25   ` Peter Korsgaard
2023-01-01 23:36 ` [Buildroot] [PATCH 25/29] utils/check-package: fix check for <pkg>_REDISTRIBUTE Ricardo Martincoski
2023-01-01 23:36 ` [Buildroot] [PATCH 26/29] utils/check-package: check linux-tools Ricardo Martincoski
2023-01-01 23:36 ` [Buildroot] [PATCH 27/29] utils/check-package: warn about symbols not recognized by a package infra Ricardo Martincoski
2023-01-01 23:36 ` [Buildroot] [PATCH 28/29] utils/check-package: warn about disabled install Ricardo Martincoski
2023-01-01 23:36 ` [Buildroot] [PATCH 29/29] docs/manual: standardize references to the generic infra Ricardo Martincoski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230101233653.487175-21-ricardo.martincoski@gmail.com \
    --to=ricardo.martincoski@gmail.com \
    --cc=buildroot@buildroot.org \
    --cc=matthew.weber@collins.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.