From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 714E4C3DA7D for ; Tue, 3 Jan 2023 21:13:56 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233959AbjACVNz (ORCPT ); Tue, 3 Jan 2023 16:13:55 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:49432 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233841AbjACVNv (ORCPT ); Tue, 3 Jan 2023 16:13:51 -0500 Received: from mail-oi1-x22c.google.com (mail-oi1-x22c.google.com [IPv6:2607:f8b0:4864:20::22c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6F00614026; Tue, 3 Jan 2023 13:13:50 -0800 (PST) Received: by mail-oi1-x22c.google.com with SMTP id s187so28090061oie.10; Tue, 03 Jan 2023 13:13:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=XE75YtvOdvDomo8uXrOVQKva/Jfq1iADNtB4zYNap7c=; b=Lpowg12mxYqoiJ4BdljvIs/bARRrYXIOFjq+fs8Y/8lZbX4Vrm/ihZGZyXrwtTDRGt 4qarAynnfhSVeEb0jVrmjqG4XpQ+h/HGOyy9J9mlsjT01v+Kg3a6lWnk6Iu2cPUxh9mU N+aFsvWoqJ3eezpDT9RQTS391H9EupZbcTGDqamdY2frrRyeDbl+KnGCTFpc25tBDD6+ dHnvlZYrv2+PTwYEVThC5180SsdwTPnuvgm/LYnlsIgpscPdfIUNimPQsM3RFZ0CHZzl Nk2bo61/wgKPFM/6Bzlbhkb7AZUZACncwGR4hObH5YmghEVk5a+vMWgKOwG9L9TyP6ox OOwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=XE75YtvOdvDomo8uXrOVQKva/Jfq1iADNtB4zYNap7c=; b=kLKt/KdtYD6UyINq8TFh6gdzPpEZbjZ46avY6ptTf2SC3yWPRG2HD+dOFYAtbvmt12 qCBHxkANQ3gZ/s5uvkWdegRsxaZjFtrzctl/2nD1docE39KKyPfcV1WK/N03pE8fJB2m QoAmws6Rn3T4cUE0ljuNo23zI46lng1GLbJFK9kqIhFefqVA2BGrFSC8E5HCUBhw2gi0 n7NFdiq910ncKA3JQmWixBfEjtmj9Lo+tWBILhuOlCESy++qvjeE+DrR9piYU5EUW9o6 RMc7dR+386qFUwfihnAWzbsCDXkIKBLRGGyYanBS1QRSMM1GojnFzWqUnZwDfC9AkZnz 55Xg== X-Gm-Message-State: AFqh2kokPrG1MgHslJIbuqCMLwilgMufQdBpmv2TLODlVFUSjgINCjZw xCjY7qvW0gYyXinS5Xx7Mak= X-Google-Smtp-Source: AMrXdXvnKs27s2VbrRKfzPeMKbw05RGDjEKZXjegoX/C5hhIayzISy2/C4p1r+mZBK8lmDMr+nJaYQ== X-Received: by 2002:a05:6808:7c9:b0:35e:7748:5899 with SMTP id f9-20020a05680807c900b0035e77485899mr19383004oij.50.1672780429799; Tue, 03 Jan 2023 13:13:49 -0800 (PST) Received: from server.roeck-us.net ([2600:1700:e321:62f0:329c:23ff:fee3:9d7c]) by smtp.gmail.com with ESMTPSA id s22-20020a0568080b1600b0035b439a4b81sm13513958oij.31.2023.01.03.13.13.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Jan 2023 13:13:49 -0800 (PST) Sender: Guenter Roeck Date: Tue, 3 Jan 2023 13:13:48 -0800 From: Guenter Roeck To: Christophe JAILLET Cc: Wim Van Sebroeck , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-watchdog@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org Subject: Re: [PATCH] watchdog: meson_gxbb: Use devm_clk_get_enabled() helper Message-ID: <20230103211348.GB212337@roeck-us.net> References: <6c5948373d309408095c1a098b7b4c491c5265f7.1672490071.git.christophe.jaillet@wanadoo.fr> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6c5948373d309408095c1a098b7b4c491c5265f7.1672490071.git.christophe.jaillet@wanadoo.fr> Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Dec 31, 2022 at 01:34:44PM +0100, Christophe JAILLET wrote: > The devm_clk_get_enabled() helper: > - calls devm_clk_get() > - calls clk_prepare_enable() and registers what is needed in order to > call clk_disable_unprepare() when needed, as a managed resource. > > This simplifies the code and avoids the need of a dedicated function used > with devm_add_action_or_reset(). > > Signed-off-by: Christophe JAILLET Reviewed-by: Guenter Roeck > --- > drivers/watchdog/meson_gxbb_wdt.c | 16 +--------------- > 1 file changed, 1 insertion(+), 15 deletions(-) > > diff --git a/drivers/watchdog/meson_gxbb_wdt.c b/drivers/watchdog/meson_gxbb_wdt.c > index 981a2f7c3bec..35d80cb39856 100644 > --- a/drivers/watchdog/meson_gxbb_wdt.c > +++ b/drivers/watchdog/meson_gxbb_wdt.c > @@ -146,16 +146,10 @@ static const struct of_device_id meson_gxbb_wdt_dt_ids[] = { > }; > MODULE_DEVICE_TABLE(of, meson_gxbb_wdt_dt_ids); > > -static void meson_clk_disable_unprepare(void *data) > -{ > - clk_disable_unprepare(data); > -} > - > static int meson_gxbb_wdt_probe(struct platform_device *pdev) > { > struct device *dev = &pdev->dev; > struct meson_gxbb_wdt *data; > - int ret; > u32 ctrl_reg; > > data = devm_kzalloc(dev, sizeof(*data), GFP_KERNEL); > @@ -166,18 +160,10 @@ static int meson_gxbb_wdt_probe(struct platform_device *pdev) > if (IS_ERR(data->reg_base)) > return PTR_ERR(data->reg_base); > > - data->clk = devm_clk_get(dev, NULL); > + data->clk = devm_clk_get_enabled(dev, NULL); > if (IS_ERR(data->clk)) > return PTR_ERR(data->clk); > > - ret = clk_prepare_enable(data->clk); > - if (ret) > - return ret; > - ret = devm_add_action_or_reset(dev, meson_clk_disable_unprepare, > - data->clk); > - if (ret) > - return ret; > - > platform_set_drvdata(pdev, data); > > data->wdt_dev.parent = dev; > -- > 2.34.1 > From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 7D7D2C4708E for ; Tue, 3 Jan 2023 21:16:05 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=2KuoJQpHslzhrdlY7hDPIg4QpMXybTnOqaWmhFD22Ac=; b=l/dcUvO9J679rS pms8ngX0yrUWCqYBSzKAYQVbNrzNlIK3MWMkDKkPsaqrrfErelvAVQGj8XwmwH06nk8UdVOnEW6vi nPnh8YXK2L4rKwP3/48dYwfWCSuWWNylmUvl9EeFWJw35nT0c8KRRo4EDI1rl/2fXcA0V+Ovb3jnG 78i0Xd5ClmZPUaO23oeEqgyQYFl5MOdTntpa3O8jaAYYzmjlT/0mKYm9NkRIAVIRkpPp1TpBBsBMR F2fW17P4SkxkE9KfSC52/BCDSGjhlfv6k6bSq7R4VIxFW9e9pGES4ZqiQ3rnMNyLjR9fZpabeR7zo h1xAIPsfalvV2L0yYe1Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pCodW-0052Yf-Us; Tue, 03 Jan 2023 21:15:54 +0000 Received: from mail-oi1-x231.google.com ([2607:f8b0:4864:20::231]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pCobY-0051nP-5F; Tue, 03 Jan 2023 21:13:53 +0000 Received: by mail-oi1-x231.google.com with SMTP id j130so22484307oif.4; Tue, 03 Jan 2023 13:13:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=XE75YtvOdvDomo8uXrOVQKva/Jfq1iADNtB4zYNap7c=; b=Lpowg12mxYqoiJ4BdljvIs/bARRrYXIOFjq+fs8Y/8lZbX4Vrm/ihZGZyXrwtTDRGt 4qarAynnfhSVeEb0jVrmjqG4XpQ+h/HGOyy9J9mlsjT01v+Kg3a6lWnk6Iu2cPUxh9mU N+aFsvWoqJ3eezpDT9RQTS391H9EupZbcTGDqamdY2frrRyeDbl+KnGCTFpc25tBDD6+ dHnvlZYrv2+PTwYEVThC5180SsdwTPnuvgm/LYnlsIgpscPdfIUNimPQsM3RFZ0CHZzl Nk2bo61/wgKPFM/6Bzlbhkb7AZUZACncwGR4hObH5YmghEVk5a+vMWgKOwG9L9TyP6ox OOwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=XE75YtvOdvDomo8uXrOVQKva/Jfq1iADNtB4zYNap7c=; b=Z4OnAV5/WfuBp7oktRZZdNHunAR59A5YZiG+tvyV4Qi7T6qRHis+LTjBvN1/QNmw11 nKgO0KRF/vKqzfJWUkRWJ7B0Dp2cZEy0yty0BIKh+ZYwhCmkze7SeCq2LpRScSRtAvd7 aFmhTNtDROhjMB23zFoBjVKh931E6+q0Eza0+2pjzlL+DANB2QwBWYbY1lFdeTDVvgsr sdlc8biLmgY0LnXFoIWu+6PmbN8bKapW+Q3ICvQTxMHeCRtVmb7XzM0FxayIBv4m4nlA jKcacf86FL2cFKnnhR2XqYcTrc2nuNB86vCYBIOZbqTIn/BFwIKCmfEo76LYYS3wP0+K a5LQ== X-Gm-Message-State: AFqh2koQVMa4TeBxonHha1Iawrl/u/yfg9KRlEZb2OodO0LkbEzHuPfG 2Wk4zGEhrJpD3PM8PDVDRpo= X-Google-Smtp-Source: AMrXdXvnKs27s2VbrRKfzPeMKbw05RGDjEKZXjegoX/C5hhIayzISy2/C4p1r+mZBK8lmDMr+nJaYQ== X-Received: by 2002:a05:6808:7c9:b0:35e:7748:5899 with SMTP id f9-20020a05680807c900b0035e77485899mr19383004oij.50.1672780429799; Tue, 03 Jan 2023 13:13:49 -0800 (PST) Received: from server.roeck-us.net ([2600:1700:e321:62f0:329c:23ff:fee3:9d7c]) by smtp.gmail.com with ESMTPSA id s22-20020a0568080b1600b0035b439a4b81sm13513958oij.31.2023.01.03.13.13.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Jan 2023 13:13:49 -0800 (PST) Date: Tue, 3 Jan 2023 13:13:48 -0800 From: Guenter Roeck To: Christophe JAILLET Cc: Wim Van Sebroeck , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-watchdog@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org Subject: Re: [PATCH] watchdog: meson_gxbb: Use devm_clk_get_enabled() helper Message-ID: <20230103211348.GB212337@roeck-us.net> References: <6c5948373d309408095c1a098b7b4c491c5265f7.1672490071.git.christophe.jaillet@wanadoo.fr> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <6c5948373d309408095c1a098b7b4c491c5265f7.1672490071.git.christophe.jaillet@wanadoo.fr> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230103_131352_275549_97E226A3 X-CRM114-Status: GOOD ( 18.93 ) X-BeenThere: linux-amlogic@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-amlogic" Errors-To: linux-amlogic-bounces+linux-amlogic=archiver.kernel.org@lists.infradead.org On Sat, Dec 31, 2022 at 01:34:44PM +0100, Christophe JAILLET wrote: > The devm_clk_get_enabled() helper: > - calls devm_clk_get() > - calls clk_prepare_enable() and registers what is needed in order to > call clk_disable_unprepare() when needed, as a managed resource. > > This simplifies the code and avoids the need of a dedicated function used > with devm_add_action_or_reset(). > > Signed-off-by: Christophe JAILLET Reviewed-by: Guenter Roeck > --- > drivers/watchdog/meson_gxbb_wdt.c | 16 +--------------- > 1 file changed, 1 insertion(+), 15 deletions(-) > > diff --git a/drivers/watchdog/meson_gxbb_wdt.c b/drivers/watchdog/meson_gxbb_wdt.c > index 981a2f7c3bec..35d80cb39856 100644 > --- a/drivers/watchdog/meson_gxbb_wdt.c > +++ b/drivers/watchdog/meson_gxbb_wdt.c > @@ -146,16 +146,10 @@ static const struct of_device_id meson_gxbb_wdt_dt_ids[] = { > }; > MODULE_DEVICE_TABLE(of, meson_gxbb_wdt_dt_ids); > > -static void meson_clk_disable_unprepare(void *data) > -{ > - clk_disable_unprepare(data); > -} > - > static int meson_gxbb_wdt_probe(struct platform_device *pdev) > { > struct device *dev = &pdev->dev; > struct meson_gxbb_wdt *data; > - int ret; > u32 ctrl_reg; > > data = devm_kzalloc(dev, sizeof(*data), GFP_KERNEL); > @@ -166,18 +160,10 @@ static int meson_gxbb_wdt_probe(struct platform_device *pdev) > if (IS_ERR(data->reg_base)) > return PTR_ERR(data->reg_base); > > - data->clk = devm_clk_get(dev, NULL); > + data->clk = devm_clk_get_enabled(dev, NULL); > if (IS_ERR(data->clk)) > return PTR_ERR(data->clk); > > - ret = clk_prepare_enable(data->clk); > - if (ret) > - return ret; > - ret = devm_add_action_or_reset(dev, meson_clk_disable_unprepare, > - data->clk); > - if (ret) > - return ret; > - > platform_set_drvdata(pdev, data); > > data->wdt_dev.parent = dev; > -- > 2.34.1 > _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3E80DC4708E for ; Tue, 3 Jan 2023 21:16:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=g9ZL20SatdVillC0UZHmip9rX+wRwTtdFWN0eyaABn0=; b=raiz6zRRkVjsZV xFSXpdFJS3heLJbt9EiRObb5fdTFHsHr8CypeAnU4xRQQdK0Sow8X3ZS6OQ0mg9SAbHRu9bDBtOau BFEwhYGXKoqXaHNK7a5ABZ1b3evDOIYxCgZVQqUQAZ30YBZ05ykqb/C+sfzHMpYPiUc+YND91oAvQ UEad/yQFrnpT+b932eNXTaQuFrzaeYVx0G549bRIm58y8y01BPlKQTWp3qraT9kPyCUfUJoiVkc8T aIwAUOYU8rjpgYZ6+31C4NnsziI5UrfKmaUl6xxZX3e+Nq39ZnjqLpvx+86LprNlwkys/NEa3QDNa 5EoMdi6ViZASStK7k62Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pCodL-0052To-AT; Tue, 03 Jan 2023 21:15:43 +0000 Received: from mail-oi1-x231.google.com ([2607:f8b0:4864:20::231]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pCobY-0051nP-5F; Tue, 03 Jan 2023 21:13:53 +0000 Received: by mail-oi1-x231.google.com with SMTP id j130so22484307oif.4; Tue, 03 Jan 2023 13:13:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:from:to:cc:subject:date:message-id :reply-to; bh=XE75YtvOdvDomo8uXrOVQKva/Jfq1iADNtB4zYNap7c=; b=Lpowg12mxYqoiJ4BdljvIs/bARRrYXIOFjq+fs8Y/8lZbX4Vrm/ihZGZyXrwtTDRGt 4qarAynnfhSVeEb0jVrmjqG4XpQ+h/HGOyy9J9mlsjT01v+Kg3a6lWnk6Iu2cPUxh9mU N+aFsvWoqJ3eezpDT9RQTS391H9EupZbcTGDqamdY2frrRyeDbl+KnGCTFpc25tBDD6+ dHnvlZYrv2+PTwYEVThC5180SsdwTPnuvgm/LYnlsIgpscPdfIUNimPQsM3RFZ0CHZzl Nk2bo61/wgKPFM/6Bzlbhkb7AZUZACncwGR4hObH5YmghEVk5a+vMWgKOwG9L9TyP6ox OOwQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:sender:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=XE75YtvOdvDomo8uXrOVQKva/Jfq1iADNtB4zYNap7c=; b=Z4OnAV5/WfuBp7oktRZZdNHunAR59A5YZiG+tvyV4Qi7T6qRHis+LTjBvN1/QNmw11 nKgO0KRF/vKqzfJWUkRWJ7B0Dp2cZEy0yty0BIKh+ZYwhCmkze7SeCq2LpRScSRtAvd7 aFmhTNtDROhjMB23zFoBjVKh931E6+q0Eza0+2pjzlL+DANB2QwBWYbY1lFdeTDVvgsr sdlc8biLmgY0LnXFoIWu+6PmbN8bKapW+Q3ICvQTxMHeCRtVmb7XzM0FxayIBv4m4nlA jKcacf86FL2cFKnnhR2XqYcTrc2nuNB86vCYBIOZbqTIn/BFwIKCmfEo76LYYS3wP0+K a5LQ== X-Gm-Message-State: AFqh2koQVMa4TeBxonHha1Iawrl/u/yfg9KRlEZb2OodO0LkbEzHuPfG 2Wk4zGEhrJpD3PM8PDVDRpo= X-Google-Smtp-Source: AMrXdXvnKs27s2VbrRKfzPeMKbw05RGDjEKZXjegoX/C5hhIayzISy2/C4p1r+mZBK8lmDMr+nJaYQ== X-Received: by 2002:a05:6808:7c9:b0:35e:7748:5899 with SMTP id f9-20020a05680807c900b0035e77485899mr19383004oij.50.1672780429799; Tue, 03 Jan 2023 13:13:49 -0800 (PST) Received: from server.roeck-us.net ([2600:1700:e321:62f0:329c:23ff:fee3:9d7c]) by smtp.gmail.com with ESMTPSA id s22-20020a0568080b1600b0035b439a4b81sm13513958oij.31.2023.01.03.13.13.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Jan 2023 13:13:49 -0800 (PST) Date: Tue, 3 Jan 2023 13:13:48 -0800 From: Guenter Roeck To: Christophe JAILLET Cc: Wim Van Sebroeck , Neil Armstrong , Kevin Hilman , Jerome Brunet , Martin Blumenstingl , linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-watchdog@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-amlogic@lists.infradead.org Subject: Re: [PATCH] watchdog: meson_gxbb: Use devm_clk_get_enabled() helper Message-ID: <20230103211348.GB212337@roeck-us.net> References: <6c5948373d309408095c1a098b7b4c491c5265f7.1672490071.git.christophe.jaillet@wanadoo.fr> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <6c5948373d309408095c1a098b7b4c491c5265f7.1672490071.git.christophe.jaillet@wanadoo.fr> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230103_131352_275549_97E226A3 X-CRM114-Status: GOOD ( 18.93 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Sat, Dec 31, 2022 at 01:34:44PM +0100, Christophe JAILLET wrote: > The devm_clk_get_enabled() helper: > - calls devm_clk_get() > - calls clk_prepare_enable() and registers what is needed in order to > call clk_disable_unprepare() when needed, as a managed resource. > > This simplifies the code and avoids the need of a dedicated function used > with devm_add_action_or_reset(). > > Signed-off-by: Christophe JAILLET Reviewed-by: Guenter Roeck > --- > drivers/watchdog/meson_gxbb_wdt.c | 16 +--------------- > 1 file changed, 1 insertion(+), 15 deletions(-) > > diff --git a/drivers/watchdog/meson_gxbb_wdt.c b/drivers/watchdog/meson_gxbb_wdt.c > index 981a2f7c3bec..35d80cb39856 100644 > --- a/drivers/watchdog/meson_gxbb_wdt.c > +++ b/drivers/watchdog/meson_gxbb_wdt.c > @@ -146,16 +146,10 @@ static const struct of_device_id meson_gxbb_wdt_dt_ids[] = { > }; > MODULE_DEVICE_TABLE(of, meson_gxbb_wdt_dt_ids); > > -static void meson_clk_disable_unprepare(void *data) > -{ > - clk_disable_unprepare(data); > -} > - > static int meson_gxbb_wdt_probe(struct platform_device *pdev) > { > struct device *dev = &pdev->dev; > struct meson_gxbb_wdt *data; > - int ret; > u32 ctrl_reg; > > data = devm_kzalloc(dev, sizeof(*data), GFP_KERNEL); > @@ -166,18 +160,10 @@ static int meson_gxbb_wdt_probe(struct platform_device *pdev) > if (IS_ERR(data->reg_base)) > return PTR_ERR(data->reg_base); > > - data->clk = devm_clk_get(dev, NULL); > + data->clk = devm_clk_get_enabled(dev, NULL); > if (IS_ERR(data->clk)) > return PTR_ERR(data->clk); > > - ret = clk_prepare_enable(data->clk); > - if (ret) > - return ret; > - ret = devm_add_action_or_reset(dev, meson_clk_disable_unprepare, > - data->clk); > - if (ret) > - return ret; > - > platform_set_drvdata(pdev, data); > > data->wdt_dev.parent = dev; > -- > 2.34.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel