All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
To: linux-serial@vger.kernel.org,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Jiri Slaby <jirislaby@kernel.org>,
	linux-kernel@vger.kernel.org
Cc: "Johan Hovold" <johan@kernel.org>,
	"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
Subject: [PATCH 02/10] tty: Cleamup tty_port_set_suspended() bool parameter
Date: Wed,  4 Jan 2023 17:15:23 +0200	[thread overview]
Message-ID: <20230104151531.73994-3-ilpo.jarvinen@linux.intel.com> (raw)
In-Reply-To: <20230104151531.73994-1-ilpo.jarvinen@linux.intel.com>

Make callers pass true/false consistently for bool val.

Signed-off-by: Ilpo Järvinen <ilpo.jarvinen@linux.intel.com>
---
 drivers/tty/serial/serial_core.c | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/tty/serial/serial_core.c b/drivers/tty/serial/serial_core.c
index e049c760b738..f9564b1e3dfb 100644
--- a/drivers/tty/serial/serial_core.c
+++ b/drivers/tty/serial/serial_core.c
@@ -312,7 +312,7 @@ static void uart_shutdown(struct tty_struct *tty, struct uart_state *state)
 	 * a DCD drop (hangup) at just the right time.  Clear suspended bit so
 	 * we don't try to resume a port that has been shutdown.
 	 */
-	tty_port_set_suspended(port, 0);
+	tty_port_set_suspended(port, false);
 
 	/*
 	 * Do not free() the transmit buffer page under the port lock since
@@ -1725,7 +1725,7 @@ static void uart_tty_port_shutdown(struct tty_port *port)
 	 * a DCD drop (hangup) at just the right time.  Clear suspended bit so
 	 * we don't try to resume a port that has been shutdown.
 	 */
-	tty_port_set_suspended(port, 0);
+	tty_port_set_suspended(port, false);
 
 	/*
 	 * Free the transmit buffer.
@@ -2346,7 +2346,7 @@ int uart_suspend_port(struct uart_driver *drv, struct uart_port *uport)
 		int tries;
 		unsigned int mctrl;
 
-		tty_port_set_suspended(port, 1);
+		tty_port_set_suspended(port, true);
 		tty_port_set_initialized(port, false);
 
 		spin_lock_irq(&uport->lock);
@@ -2469,7 +2469,7 @@ int uart_resume_port(struct uart_driver *drv, struct uart_port *uport)
 			}
 		}
 
-		tty_port_set_suspended(port, 0);
+		tty_port_set_suspended(port, false);
 	}
 
 	mutex_unlock(&port->mutex);
-- 
2.30.2


  parent reply	other threads:[~2023-01-04 15:16 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-01-04 15:15 [PATCH 00/10] tty/serial: bool conversions and cleanups Ilpo Järvinen
2023-01-04 15:15 ` [PATCH 01/10] tty: Cleanup tty_port_set_initialized() bool parameter Ilpo Järvinen
2023-01-04 15:15   ` Ilpo Järvinen
2023-01-05  6:03   ` Jiri Slaby
2023-01-05  6:03     ` Jiri Slaby
2023-01-05  7:23   ` Samuel Iglesias Gonsálvez
2023-01-05  7:23     ` Samuel Iglesias Gonsálvez
2023-01-04 15:15 ` Ilpo Järvinen [this message]
2023-01-05  6:03   ` [PATCH 02/10] tty: Cleamup tty_port_set_suspended() " Jiri Slaby
2023-01-04 15:15 ` [PATCH 03/10] tty: Cleanup tty_port_set_active() " Ilpo Järvinen
2023-01-05  6:03   ` Jiri Slaby
2023-01-04 15:15 ` [PATCH 04/10] tty: moxa: Make local var storing tty_port_initialized() bool Ilpo Järvinen
2023-01-05  6:04   ` Jiri Slaby
2023-01-04 15:15 ` [PATCH 05/10] serial: Convert uart_{,port_}startup() init_hw param to bool Ilpo Järvinen
2023-01-05  6:05   ` Jiri Slaby
2023-01-05  8:48     ` Ilpo Järvinen
2023-01-05  9:12     ` Johan Hovold
2023-01-04 15:15 ` [PATCH 06/10] tty: Convert ->carrier_raised() and callchains " Ilpo Järvinen
2023-01-04 15:15   ` Ilpo Järvinen
2023-01-05  6:13   ` Jiri Slaby
2023-01-05  6:13     ` Jiri Slaby
2023-01-04 15:15 ` [PATCH 07/10] tty: Convert ->dtr_rts() to take bool argument Ilpo Järvinen
2023-01-04 15:15   ` Ilpo Järvinen
2023-01-05  6:19   ` Jiri Slaby
2023-01-05  6:19     ` Jiri Slaby
2023-01-05  8:51     ` Ilpo Järvinen
2023-01-05  8:51       ` Ilpo Järvinen
2023-01-05  8:51       ` Ilpo Järvinen
2023-01-04 15:15 ` [PATCH 08/10] tty/serial: Make ->dcd_change()+uart_handle_dcd_change() status bool Ilpo Järvinen
2023-01-05  6:21   ` Jiri Slaby
2023-01-05  9:11   ` Rodolfo Giometti
2023-01-04 15:15 ` [PATCH 09/10] serial: Make uart_handle_cts_change() status param bool Ilpo Järvinen
2023-01-04 15:15   ` Ilpo Järvinen
2023-01-05  6:23   ` Jiri Slaby
2023-01-05  6:23     ` Jiri Slaby
2023-01-05  8:55     ` Ilpo Järvinen
2023-01-05  8:55       ` Ilpo Järvinen
2023-01-05  9:25     ` Johan Hovold
2023-01-05  9:25       ` Johan Hovold
2023-01-04 15:15 ` [PATCH 10/10] tty: Return bool from tty_termios_hw_change() Ilpo Järvinen
2023-01-05  6:28   ` Jiri Slaby
2023-01-05  9:27   ` Johan Hovold

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230104151531.73994-3-ilpo.jarvinen@linux.intel.com \
    --to=ilpo.jarvinen@linux.intel.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=jirislaby@kernel.org \
    --cc=johan@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-serial@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.