From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 86189C4708D for ; Wed, 4 Jan 2023 17:44:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235338AbjADRow (ORCPT ); Wed, 4 Jan 2023 12:44:52 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44764 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S235135AbjADRou (ORCPT ); Wed, 4 Jan 2023 12:44:50 -0500 Received: from ams.source.kernel.org (ams.source.kernel.org [IPv6:2604:1380:4601:e00::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D7B9E1AA2A for ; Wed, 4 Jan 2023 09:44:49 -0800 (PST) Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 5F894B817B0 for ; Wed, 4 Jan 2023 17:44:48 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 039DBC433D2; Wed, 4 Jan 2023 17:44:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1672854287; bh=zLoq7rh6ScCHPZAIwnMyOMYtt4LObBNVb50PEjsCMO4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=TkjjtbVhvm7y6BrLK/JIutVKbhkb/iI1jjqXaMaqMPwJXwXmHOQIoFHs6voBFXfpD sNWCT1yyxH0Xm8mE6qnOdOBXbWehGPV8mb3r986AKkEfdG0KAafREr/KMi+6sTlbVj 2pyn4l6IdTiLnbb6GBk9af8s0beoNYM33lICoDcbvOoTogLpOEmiCHrdH05GcJyh86 Aa3raCWj778enkKGLJSSK84oKmQ5xcbg93M75kdBrmwon3lzH9Tp0VZlTtTY3jc1FX zZbCJKMpm4nytUW7QG7iGE4FhyXBmI5biS3H+LuzkqvET4ihfCnWRrfIGhskXR4lq6 HT7HuyV7ptFmA== From: Ard Biesheuvel To: linux-arm-kernel@lists.infradead.org Cc: linux-efi@vger.kernel.org, catalin.marinas@arm.com, will@kernel.org, Ard Biesheuvel Subject: [PATCH v2 2/2] arm64: efi: Account for the EFI runtime stack in stack unwinder Date: Wed, 4 Jan 2023 18:44:33 +0100 Message-Id: <20230104174433.1259428-3-ardb@kernel.org> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20230104174433.1259428-1-ardb@kernel.org> References: <20230104174433.1259428-1-ardb@kernel.org> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=2451; i=ardb@kernel.org; h=from:subject; bh=zLoq7rh6ScCHPZAIwnMyOMYtt4LObBNVb50PEjsCMO4=; b=owEB7QES/pANAwAKAcNPIjmS2Y8kAcsmYgBjtbsAKsux2GnbGItRO4bTstltLeejaKlQ2jZlbxHU duGvq9GJAbMEAAEKAB0WIQT72WJ8QGnJQhU3VynDTyI5ktmPJAUCY7W7AAAKCRDDTyI5ktmPJH/QC/ 40BVyTgbU9WcPUL8vgnzKPNg6kfH6vVDQQIh1M1j5otlrcinpjKMg92e3wPYMBq11w1+CRStzBjKSr gudVIrmYmDsohFZDDVxWixMU8WTR92mN6Rh7YwXRYL0ASsrbvFaRVeBqFPUTz8NDk0s3gueljAuZM9 EkFYAOmigpNc33dUtIhnPhti6ir4TqnD7yFPczbu+cJ6kgz6ZLXAnTUykmeJZYmG8s3OByZpDfa7Ff E9vfRnXEXI4teGqRpp3Yk1XLQdbLoFwLQ5BWdu4mGW50ZM5R+fhpHrPSzSxbHsngJHPpgfUlYzqgOe 99wIZMUNjaDHtfavtf7FQHvNbHhstqzdF2c5nkXZR1SxkCBIsJ30l9pyNQJ9KDQP6gAQ8wMl0sRpUs bSjl9v31a4mY9yCAO7HPnuF1tz6hewx3E/LxDzJi2tHe+w1X/2PJXb6aF2G8tq/5EnLW+ZRIDuMblv KzEY9PBIQY1xv0kbGQ1fodLuyNSCAkU4WlnCDmWDe5t8I= X-Developer-Key: i=ardb@kernel.org; a=openpgp; fpr=F43D03328115A198C90016883D200E9CA6329909 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: linux-efi@vger.kernel.org The EFI runtime services run from a dedicated stack now, and so the stack unwinder needs to be informed about this. Signed-off-by: Ard Biesheuvel --- arch/arm64/include/asm/stacktrace.h | 15 +++++++++++++++ arch/arm64/kernel/stacktrace.c | 12 ++++++++++++ 2 files changed, 27 insertions(+) diff --git a/arch/arm64/include/asm/stacktrace.h b/arch/arm64/include/asm/stacktrace.h index 4e5354beafb01bac..66ec8caa6ac07fa0 100644 --- a/arch/arm64/include/asm/stacktrace.h +++ b/arch/arm64/include/asm/stacktrace.h @@ -106,4 +106,19 @@ static inline struct stack_info stackinfo_get_sdei_critical(void) #define stackinfo_get_sdei_critical() stackinfo_get_unknown() #endif +#ifdef CONFIG_EFI +extern u64 *efi_rt_stack_top; + +static inline struct stack_info stackinfo_get_efi(void) +{ + unsigned long high = (u64)efi_rt_stack_top; + unsigned long low = high - THREAD_SIZE; + + return (struct stack_info) { + .low = low, + .high = high, + }; +} +#endif + #endif /* __ASM_STACKTRACE_H */ diff --git a/arch/arm64/kernel/stacktrace.c b/arch/arm64/kernel/stacktrace.c index 117e2c180f3c77d8..83154303e682c8b6 100644 --- a/arch/arm64/kernel/stacktrace.c +++ b/arch/arm64/kernel/stacktrace.c @@ -5,6 +5,7 @@ * Copyright (C) 2012 ARM Ltd. */ #include +#include #include #include #include @@ -12,6 +13,7 @@ #include #include +#include #include #include #include @@ -186,6 +188,13 @@ void show_stack(struct task_struct *tsk, unsigned long *sp, const char *loglvl) : stackinfo_get_unknown(); \ }) +#define STACKINFO_EFI \ + ({ \ + ((task == current) && current_in_efi()) \ + ? stackinfo_get_efi() \ + : stackinfo_get_unknown(); \ + }) + noinline noinstr void arch_stack_walk(stack_trace_consume_fn consume_entry, void *cookie, struct task_struct *task, struct pt_regs *regs) @@ -199,6 +208,9 @@ noinline noinstr void arch_stack_walk(stack_trace_consume_fn consume_entry, #if defined(CONFIG_VMAP_STACK) && defined(CONFIG_ARM_SDE_INTERFACE) STACKINFO_SDEI(normal), STACKINFO_SDEI(critical), +#endif +#ifdef CONFIG_EFI + STACKINFO_EFI, #endif }; struct unwind_state state = { -- 2.39.0 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id CB3F5C4332F for ; Wed, 4 Jan 2023 17:46:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=zD6ROuQmF0pgSmif3wW+4fGYn6BfYUL1PDwIcsPnkk8=; b=FIdpwTYHMzzZOT B1fn9P8ZcSCBLhhLkJWHgl2cAjSOvkybxnvQcZ5tit/s0l44epRIM0idRDumrIS3IFFC9AdPrH/JR iiWWycU1favWsF1tMEKsbllfZGksB/vCSPdGhND+9lFxomZHrFx04YUWXdwXsC6OMqjv5vAt1ILLP 1zt1Lktxt4XwpK0B4PzI7sXe3NKzp9cark+1wHUue4d0IWUi+nTwSvpy9DkqDcbfM07N3xnrUzD84 jvvQknLYqHYh1tNqzW8ulMY8UVCznT9zHq4xUlGoX05gglyN3gXS1S8u7EulkPGaOJdSTn/9oZPBg O+UJJa0oiVa5grHOw0dA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pD7pD-00AiPz-4n; Wed, 04 Jan 2023 17:45:15 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pD7oo-00Ai60-2i for linux-arm-kernel@lists.infradead.org; Wed, 04 Jan 2023 17:44:51 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id B34DA616C3; Wed, 4 Jan 2023 17:44:47 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 039DBC433D2; Wed, 4 Jan 2023 17:44:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1672854287; bh=zLoq7rh6ScCHPZAIwnMyOMYtt4LObBNVb50PEjsCMO4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=TkjjtbVhvm7y6BrLK/JIutVKbhkb/iI1jjqXaMaqMPwJXwXmHOQIoFHs6voBFXfpD sNWCT1yyxH0Xm8mE6qnOdOBXbWehGPV8mb3r986AKkEfdG0KAafREr/KMi+6sTlbVj 2pyn4l6IdTiLnbb6GBk9af8s0beoNYM33lICoDcbvOoTogLpOEmiCHrdH05GcJyh86 Aa3raCWj778enkKGLJSSK84oKmQ5xcbg93M75kdBrmwon3lzH9Tp0VZlTtTY3jc1FX zZbCJKMpm4nytUW7QG7iGE4FhyXBmI5biS3H+LuzkqvET4ihfCnWRrfIGhskXR4lq6 HT7HuyV7ptFmA== From: Ard Biesheuvel To: linux-arm-kernel@lists.infradead.org Cc: linux-efi@vger.kernel.org, catalin.marinas@arm.com, will@kernel.org, Ard Biesheuvel Subject: [PATCH v2 2/2] arm64: efi: Account for the EFI runtime stack in stack unwinder Date: Wed, 4 Jan 2023 18:44:33 +0100 Message-Id: <20230104174433.1259428-3-ardb@kernel.org> X-Mailer: git-send-email 2.39.0 In-Reply-To: <20230104174433.1259428-1-ardb@kernel.org> References: <20230104174433.1259428-1-ardb@kernel.org> MIME-Version: 1.0 X-Developer-Signature: v=1; a=openpgp-sha256; l=2451; i=ardb@kernel.org; h=from:subject; bh=zLoq7rh6ScCHPZAIwnMyOMYtt4LObBNVb50PEjsCMO4=; b=owEB7QES/pANAwAKAcNPIjmS2Y8kAcsmYgBjtbsAKsux2GnbGItRO4bTstltLeejaKlQ2jZlbxHU duGvq9GJAbMEAAEKAB0WIQT72WJ8QGnJQhU3VynDTyI5ktmPJAUCY7W7AAAKCRDDTyI5ktmPJH/QC/ 40BVyTgbU9WcPUL8vgnzKPNg6kfH6vVDQQIh1M1j5otlrcinpjKMg92e3wPYMBq11w1+CRStzBjKSr gudVIrmYmDsohFZDDVxWixMU8WTR92mN6Rh7YwXRYL0ASsrbvFaRVeBqFPUTz8NDk0s3gueljAuZM9 EkFYAOmigpNc33dUtIhnPhti6ir4TqnD7yFPczbu+cJ6kgz6ZLXAnTUykmeJZYmG8s3OByZpDfa7Ff E9vfRnXEXI4teGqRpp3Yk1XLQdbLoFwLQ5BWdu4mGW50ZM5R+fhpHrPSzSxbHsngJHPpgfUlYzqgOe 99wIZMUNjaDHtfavtf7FQHvNbHhstqzdF2c5nkXZR1SxkCBIsJ30l9pyNQJ9KDQP6gAQ8wMl0sRpUs bSjl9v31a4mY9yCAO7HPnuF1tz6hewx3E/LxDzJi2tHe+w1X/2PJXb6aF2G8tq/5EnLW+ZRIDuMblv KzEY9PBIQY1xv0kbGQ1fodLuyNSCAkU4WlnCDmWDe5t8I= X-Developer-Key: i=ardb@kernel.org; a=openpgp; fpr=F43D03328115A198C90016883D200E9CA6329909 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230104_094450_238905_C4D99E67 X-CRM114-Status: GOOD ( 13.37 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org The EFI runtime services run from a dedicated stack now, and so the stack unwinder needs to be informed about this. Signed-off-by: Ard Biesheuvel --- arch/arm64/include/asm/stacktrace.h | 15 +++++++++++++++ arch/arm64/kernel/stacktrace.c | 12 ++++++++++++ 2 files changed, 27 insertions(+) diff --git a/arch/arm64/include/asm/stacktrace.h b/arch/arm64/include/asm/stacktrace.h index 4e5354beafb01bac..66ec8caa6ac07fa0 100644 --- a/arch/arm64/include/asm/stacktrace.h +++ b/arch/arm64/include/asm/stacktrace.h @@ -106,4 +106,19 @@ static inline struct stack_info stackinfo_get_sdei_critical(void) #define stackinfo_get_sdei_critical() stackinfo_get_unknown() #endif +#ifdef CONFIG_EFI +extern u64 *efi_rt_stack_top; + +static inline struct stack_info stackinfo_get_efi(void) +{ + unsigned long high = (u64)efi_rt_stack_top; + unsigned long low = high - THREAD_SIZE; + + return (struct stack_info) { + .low = low, + .high = high, + }; +} +#endif + #endif /* __ASM_STACKTRACE_H */ diff --git a/arch/arm64/kernel/stacktrace.c b/arch/arm64/kernel/stacktrace.c index 117e2c180f3c77d8..83154303e682c8b6 100644 --- a/arch/arm64/kernel/stacktrace.c +++ b/arch/arm64/kernel/stacktrace.c @@ -5,6 +5,7 @@ * Copyright (C) 2012 ARM Ltd. */ #include +#include #include #include #include @@ -12,6 +13,7 @@ #include #include +#include #include #include #include @@ -186,6 +188,13 @@ void show_stack(struct task_struct *tsk, unsigned long *sp, const char *loglvl) : stackinfo_get_unknown(); \ }) +#define STACKINFO_EFI \ + ({ \ + ((task == current) && current_in_efi()) \ + ? stackinfo_get_efi() \ + : stackinfo_get_unknown(); \ + }) + noinline noinstr void arch_stack_walk(stack_trace_consume_fn consume_entry, void *cookie, struct task_struct *task, struct pt_regs *regs) @@ -199,6 +208,9 @@ noinline noinstr void arch_stack_walk(stack_trace_consume_fn consume_entry, #if defined(CONFIG_VMAP_STACK) && defined(CONFIG_ARM_SDE_INTERFACE) STACKINFO_SDEI(normal), STACKINFO_SDEI(critical), +#endif +#ifdef CONFIG_EFI + STACKINFO_EFI, #endif }; struct unwind_state state = { -- 2.39.0 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel