From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B7A0AC4708D for ; Fri, 6 Jan 2023 14:36:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S235127AbjAFOgZ (ORCPT ); Fri, 6 Jan 2023 09:36:25 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:41892 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230244AbjAFOgZ (ORCPT ); Fri, 6 Jan 2023 09:36:25 -0500 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 1C0E97F47A for ; Fri, 6 Jan 2023 06:36:24 -0800 (PST) Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pDnpV-0007Td-UF; Fri, 06 Jan 2023 15:36:21 +0100 Received: from mtr by ptx.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1pDnpV-0005gf-80; Fri, 06 Jan 2023 15:36:21 +0100 Date: Fri, 6 Jan 2023 15:36:21 +0100 From: Michael Tretter To: Laurent Pinchart Cc: linux-media@vger.kernel.org, devicetree@vger.kernel.org, Philipp Zabel , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Fabio Estevam , kernel@pengutronix.de, linux-imx@nxp.com, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 8/8] ARM: dts: imx7d: add node for PXP Message-ID: <20230106143621.GF24101@pengutronix.de> Mail-Followup-To: Michael Tretter , Laurent Pinchart , linux-media@vger.kernel.org, devicetree@vger.kernel.org, Philipp Zabel , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Fabio Estevam , kernel@pengutronix.de, linux-imx@nxp.com, linux-arm-kernel@lists.infradead.org References: <20230105134729.59542-1-m.tretter@pengutronix.de> <20230105134729.59542-9-m.tretter@pengutronix.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-Accept-Language: de,en X-Accept-Content-Type: text/plain User-Agent: Mutt/1.10.1 (2018-07-13) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: mtr@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: devicetree@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Fri, 06 Jan 2023 14:36:41 +0200, Laurent Pinchart wrote: > Hi Michael, > > Thank you for the patch. > > On Thu, Jan 05, 2023 at 02:47:29PM +0100, Michael Tretter wrote: > > The i.MX7d contains a Pixel Pipeline in version 3.0. Add the device tree > > node to make it available. > > > > Signed-off-by: Michael Tretter > > --- > > arch/arm/boot/dts/imx7d.dtsi | 9 +++++++++ > > 1 file changed, 9 insertions(+) > > > > diff --git a/arch/arm/boot/dts/imx7d.dtsi b/arch/arm/boot/dts/imx7d.dtsi > > index 7ceb7c09f7ad..728cc9413a7c 100644 > > --- a/arch/arm/boot/dts/imx7d.dtsi > > +++ b/arch/arm/boot/dts/imx7d.dtsi > > @@ -165,6 +165,15 @@ pcie_phy: pcie-phy@306d0000 { > > reg = <0x306d0000 0x10000>; > > status = "disabled"; > > }; > > + > > + pxp: pxp@30700000 { > > + compatible = "fsl,imx7d-pxp"; > > Hmmm... The i.MX7S also has a PXP that seems compatible. I thus wonder > if we shouldn't move this node to imx7s.dtsi. The i.MX7S has a PXP at the same address, but the architecture in the reference manual (Figure 13-71. PXP Architecture, p. 3797) looks slightly different wrt. the location of the multiplexers. The reference manual is also conspicuously lacking documentation of the DATA_PATH_CTRL0 register. I wouldn't risk adding the node to the imx7s.dtsi and would rather keep the option to add a different compatible for the i.MX7S to be able to handle the difference. Michael > > > + reg = <0x30700000 0x10000>; > > + interrupts = , > > + ; > > Nitpicking, alignment ? > > > + clocks = <&clks IMX7D_PXP_CLK>; > > + clock-names = "axi"; > > + }; > > }; > > > > &aips3 { From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 64E6BC4708D for ; Fri, 6 Jan 2023 14:37:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=tP16OAN37KEr/tKUMQB1s5XDPINWegZJPP4IwWN/GH0=; b=lKwqzBb+WjyJLT Qt+OCEt9OFHjoxLjxiJyqIXwCRDGXzOfAbqMEFNPAGl68T/iQzpJXDrS34Pw/onw1k0A8mLEVjrXL pSlO8zWz9ti34RLUp7cKFzsJKlhgldEX+5PnjKjfzNE+DSJghh12lCGoSw4/957uxNo/YvXSI/rQT leZjXjvTIJWFlK5zLvj2YhY21jt5z+mTK91YdWTS5CFLDIVOCK7ynbG3rDpDL8/JZeE7UhTlR0zeY SDGFiigbOCRoDExq+kw/PuZGbkscha3pqlQH6nqmqv9iLRTKaWDVhBC4QP4vtKGBcVxA2YdiKa7z2 Bz6rlb/ID6/OcoFQYlVQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pDnpj-008qIw-NX; Fri, 06 Jan 2023 14:36:35 +0000 Received: from metis.ext.pengutronix.de ([2001:67c:670:201:290:27ff:fe1d:cc33]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pDnpf-008qGv-V8 for linux-arm-kernel@lists.infradead.org; Fri, 06 Jan 2023 14:36:33 +0000 Received: from ptx.hi.pengutronix.de ([2001:67c:670:100:1d::c0]) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1pDnpV-0007Td-UF; Fri, 06 Jan 2023 15:36:21 +0100 Received: from mtr by ptx.hi.pengutronix.de with local (Exim 4.92) (envelope-from ) id 1pDnpV-0005gf-80; Fri, 06 Jan 2023 15:36:21 +0100 Date: Fri, 6 Jan 2023 15:36:21 +0100 From: Michael Tretter To: Laurent Pinchart Cc: linux-media@vger.kernel.org, devicetree@vger.kernel.org, Philipp Zabel , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Fabio Estevam , kernel@pengutronix.de, linux-imx@nxp.com, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 8/8] ARM: dts: imx7d: add node for PXP Message-ID: <20230106143621.GF24101@pengutronix.de> Mail-Followup-To: Michael Tretter , Laurent Pinchart , linux-media@vger.kernel.org, devicetree@vger.kernel.org, Philipp Zabel , Mauro Carvalho Chehab , Rob Herring , Krzysztof Kozlowski , Fabio Estevam , kernel@pengutronix.de, linux-imx@nxp.com, linux-arm-kernel@lists.infradead.org References: <20230105134729.59542-1-m.tretter@pengutronix.de> <20230105134729.59542-9-m.tretter@pengutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: X-Sent-From: Pengutronix Hildesheim X-URL: http://www.pengutronix.de/ X-Accept-Language: de,en X-Accept-Content-Type: text/plain User-Agent: Mutt/1.10.1 (2018-07-13) X-SA-Exim-Connect-IP: 2001:67c:670:100:1d::c0 X-SA-Exim-Mail-From: mtr@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: linux-arm-kernel@lists.infradead.org X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230106_063632_012773_F7B4BC81 X-CRM114-Status: GOOD ( 24.80 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, 06 Jan 2023 14:36:41 +0200, Laurent Pinchart wrote: > Hi Michael, > > Thank you for the patch. > > On Thu, Jan 05, 2023 at 02:47:29PM +0100, Michael Tretter wrote: > > The i.MX7d contains a Pixel Pipeline in version 3.0. Add the device tree > > node to make it available. > > > > Signed-off-by: Michael Tretter > > --- > > arch/arm/boot/dts/imx7d.dtsi | 9 +++++++++ > > 1 file changed, 9 insertions(+) > > > > diff --git a/arch/arm/boot/dts/imx7d.dtsi b/arch/arm/boot/dts/imx7d.dtsi > > index 7ceb7c09f7ad..728cc9413a7c 100644 > > --- a/arch/arm/boot/dts/imx7d.dtsi > > +++ b/arch/arm/boot/dts/imx7d.dtsi > > @@ -165,6 +165,15 @@ pcie_phy: pcie-phy@306d0000 { > > reg = <0x306d0000 0x10000>; > > status = "disabled"; > > }; > > + > > + pxp: pxp@30700000 { > > + compatible = "fsl,imx7d-pxp"; > > Hmmm... The i.MX7S also has a PXP that seems compatible. I thus wonder > if we shouldn't move this node to imx7s.dtsi. The i.MX7S has a PXP at the same address, but the architecture in the reference manual (Figure 13-71. PXP Architecture, p. 3797) looks slightly different wrt. the location of the multiplexers. The reference manual is also conspicuously lacking documentation of the DATA_PATH_CTRL0 register. I wouldn't risk adding the node to the imx7s.dtsi and would rather keep the option to add a different compatible for the i.MX7S to be able to handle the difference. Michael > > > + reg = <0x30700000 0x10000>; > > + interrupts = , > > + ; > > Nitpicking, alignment ? > > > + clocks = <&clks IMX7D_PXP_CLK>; > > + clock-names = "axi"; > > + }; > > }; > > > > &aips3 { _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel